From: Bartosz Golaszewski <brgl@bgdev.pl>
To: Linus Walleij <linus.walleij@linaro.org>,
Bartosz Golaszewski <brgl@bgdev.pl>,
Kent Gibson <warthog618@gmail.com>
Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
Subject: [PATCH v2 3/6] gpiolib: add a per-gpio_device line state notification workqueue
Date: Thu, 10 Oct 2024 11:10:24 +0200 [thread overview]
Message-ID: <20241010-gpio-notify-in-kernel-events-v2-3-b560411f7c59@linaro.org> (raw)
In-Reply-To: <20241010-gpio-notify-in-kernel-events-v2-0-b560411f7c59@linaro.org>
From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
In order to prepare the line state notification mechanism for working in
atomic context as well, add a dedicated, high-priority, ordered
workqueue to GPIO device which will be used to queue the events fron any
context for them to be emitted always in process context.
Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
---
drivers/gpio/gpiolib-cdev.c | 6 ++++++
drivers/gpio/gpiolib.h | 4 ++++
2 files changed, 10 insertions(+)
diff --git a/drivers/gpio/gpiolib-cdev.c b/drivers/gpio/gpiolib-cdev.c
index 8c48a53b4fa8..dec6c9a6005f 100644
--- a/drivers/gpio/gpiolib-cdev.c
+++ b/drivers/gpio/gpiolib-cdev.c
@@ -2869,6 +2869,11 @@ int gpiolib_cdev_register(struct gpio_device *gdev, dev_t devt)
gdev->chrdev.owner = THIS_MODULE;
gdev->dev.devt = MKDEV(MAJOR(devt), gdev->id);
+ gdev->line_state_wq = alloc_ordered_workqueue(dev_name(&gdev->dev),
+ WQ_HIGHPRI);
+ if (!gdev->line_state_wq)
+ return -ENOMEM;
+
ret = cdev_device_add(&gdev->chrdev, &gdev->dev);
if (ret)
return ret;
@@ -2885,6 +2890,7 @@ int gpiolib_cdev_register(struct gpio_device *gdev, dev_t devt)
void gpiolib_cdev_unregister(struct gpio_device *gdev)
{
+ destroy_workqueue(gdev->line_state_wq);
cdev_device_del(&gdev->chrdev, &gdev->dev);
blocking_notifier_call_chain(&gdev->device_notifier, 0, NULL);
}
diff --git a/drivers/gpio/gpiolib.h b/drivers/gpio/gpiolib.h
index 067197d61d57..d24cd9e8b17c 100644
--- a/drivers/gpio/gpiolib.h
+++ b/drivers/gpio/gpiolib.h
@@ -17,6 +17,7 @@
#include <linux/module.h>
#include <linux/notifier.h>
#include <linux/srcu.h>
+#include <linux/workqueue.h>
#define GPIOCHIP_NAME "gpiochip"
@@ -44,6 +45,8 @@
* @list: links gpio_device:s together for traversal
* @line_state_notifier: used to notify subscribers about lines being
* requested, released or reconfigured
+ * @line_state_wq: used to emit line state events from a separate thread in
+ * process context
* @device_notifier: used to notify character device wait queues about the GPIO
* device being unregistered
* @srcu: protects the pointer to the underlying GPIO chip
@@ -70,6 +73,7 @@ struct gpio_device {
void *data;
struct list_head list;
struct blocking_notifier_head line_state_notifier;
+ struct workqueue_struct *line_state_wq;
struct blocking_notifier_head device_notifier;
struct srcu_struct srcu;
--
2.43.0
next prev parent reply other threads:[~2024-10-10 9:10 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-10 9:10 [PATCH v2 0/6] gpio: notify user-space about config changes in the kernel Bartosz Golaszewski
2024-10-10 9:10 ` [PATCH v2 1/6] gpiolib: notify user-space when a driver requests its own desc Bartosz Golaszewski
2024-10-10 9:10 ` [PATCH v2 2/6] gpio: cdev: prepare gpio_desc_to_lineinfo() for being called from atomic Bartosz Golaszewski
2024-10-14 1:58 ` Kent Gibson
2024-10-14 7:45 ` Bartosz Golaszewski
2024-10-14 8:32 ` Kent Gibson
2024-10-14 8:41 ` Bartosz Golaszewski
2024-10-10 9:10 ` Bartosz Golaszewski [this message]
2024-10-10 9:10 ` [PATCH v2 4/6] gpio: cdev: put emitting the line state events on a workqueue Bartosz Golaszewski
2024-10-14 2:09 ` Kent Gibson
2024-10-14 7:47 ` Bartosz Golaszewski
2024-10-10 9:10 ` [PATCH v2 5/6] gpiolib: switch the line state notifier to atomic Bartosz Golaszewski
2024-10-14 2:11 ` Kent Gibson
2024-10-14 7:48 ` Bartosz Golaszewski
2024-10-14 9:24 ` Kent Gibson
2024-10-14 9:27 ` Bartosz Golaszewski
2024-10-14 9:29 ` Kent Gibson
2024-10-14 9:32 ` Bartosz Golaszewski
2024-10-14 9:55 ` Kent Gibson
2024-10-14 9:57 ` Bartosz Golaszewski
2024-10-10 9:10 ` [PATCH v2 6/6] gpiolib: notify user-space about in-kernel line state changes Bartosz Golaszewski
2024-10-14 2:24 ` Kent Gibson
2024-10-14 8:13 ` Bartosz Golaszewski
2024-10-14 8:42 ` Kent Gibson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241010-gpio-notify-in-kernel-events-v2-3-b560411f7c59@linaro.org \
--to=brgl@bgdev.pl \
--cc=bartosz.golaszewski@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=warthog618@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).