* [PATCH] pinctrl: nuvoton: fix a double free in ma35_pinctrl_dt_node_to_map_func()
@ 2024-10-10 20:52 Harshit Mogalapalli
2024-10-11 19:55 ` Linus Walleij
0 siblings, 1 reply; 2+ messages in thread
From: Harshit Mogalapalli @ 2024-10-10 20:52 UTC (permalink / raw)
To: christophe.jaillet, Jacky Huang, Shan-Chun Hung, Linus Walleij,
linux-arm-kernel, linux-gpio, linux-kernel
Cc: dan.carpenter, kernel-janitors, error27, harshit.m.mogalapalli,
stable
'new_map' is allocated using devm_* which takes care of freeing the
allocated data on device removal, call to
.dt_free_map = pinconf_generic_dt_free_map
double frees the map as pinconf_generic_dt_free_map() calls
pinctrl_utils_free_map().
Fix this by using kcalloc() instead of auto-managed devm_kcalloc().
Cc: stable@vger.kernel.org
Fixes: f805e356313b ("pinctrl: nuvoton: Add ma35d1 pinctrl and GPIO driver")
Reported-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Signed-off-by: Harshit Mogalapalli <harshit.m.mogalapalli@oracle.com>
---
This is based on static analysis and reading code, only compile tested.
Added the stable tag as the commit in Fixes is also in 6.11.y
---
drivers/pinctrl/nuvoton/pinctrl-ma35.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pinctrl/nuvoton/pinctrl-ma35.c b/drivers/pinctrl/nuvoton/pinctrl-ma35.c
index 1fa00a23534a..59c4e7c6cdde 100644
--- a/drivers/pinctrl/nuvoton/pinctrl-ma35.c
+++ b/drivers/pinctrl/nuvoton/pinctrl-ma35.c
@@ -218,7 +218,7 @@ static int ma35_pinctrl_dt_node_to_map_func(struct pinctrl_dev *pctldev,
}
map_num += grp->npins;
- new_map = devm_kcalloc(pctldev->dev, map_num, sizeof(*new_map), GFP_KERNEL);
+ new_map = kcalloc(map_num, sizeof(*new_map), GFP_KERNEL);
if (!new_map)
return -ENOMEM;
--
2.39.3
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] pinctrl: nuvoton: fix a double free in ma35_pinctrl_dt_node_to_map_func()
2024-10-10 20:52 [PATCH] pinctrl: nuvoton: fix a double free in ma35_pinctrl_dt_node_to_map_func() Harshit Mogalapalli
@ 2024-10-11 19:55 ` Linus Walleij
0 siblings, 0 replies; 2+ messages in thread
From: Linus Walleij @ 2024-10-11 19:55 UTC (permalink / raw)
To: Harshit Mogalapalli
Cc: christophe.jaillet, Jacky Huang, Shan-Chun Hung, linux-arm-kernel,
linux-gpio, linux-kernel, dan.carpenter, kernel-janitors, error27,
stable
On Thu, Oct 10, 2024 at 10:52 PM Harshit Mogalapalli
<harshit.m.mogalapalli@oracle.com> wrote:
> 'new_map' is allocated using devm_* which takes care of freeing the
> allocated data on device removal, call to
>
> .dt_free_map = pinconf_generic_dt_free_map
>
> double frees the map as pinconf_generic_dt_free_map() calls
> pinctrl_utils_free_map().
>
> Fix this by using kcalloc() instead of auto-managed devm_kcalloc().
>
> Cc: stable@vger.kernel.org
> Fixes: f805e356313b ("pinctrl: nuvoton: Add ma35d1 pinctrl and GPIO driver")
> Reported-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> Signed-off-by: Harshit Mogalapalli <harshit.m.mogalapalli@oracle.com>
Patch applied for fixes.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-10-11 19:55 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-10-10 20:52 [PATCH] pinctrl: nuvoton: fix a double free in ma35_pinctrl_dt_node_to_map_func() Harshit Mogalapalli
2024-10-11 19:55 ` Linus Walleij
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).