From: Kent Gibson <warthog618@gmail.com>
To: Bartosz Golaszewski <brgl@bgdev.pl>
Cc: Linus Walleij <linus.walleij@linaro.org>,
linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
Subject: Re: [PATCH v2 2/6] gpio: cdev: prepare gpio_desc_to_lineinfo() for being called from atomic
Date: Mon, 14 Oct 2024 09:58:17 +0800 [thread overview]
Message-ID: <20241014015817.GA20620@rigel> (raw)
In-Reply-To: <20241010-gpio-notify-in-kernel-events-v2-2-b560411f7c59@linaro.org>
On Thu, Oct 10, 2024 at 11:10:23AM +0200, Bartosz Golaszewski wrote:
> From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
>
> In order to prepare gpio_desc_to_lineinfo() to being called from atomic
> context, add a new argument - bool atomic - which, if set, indicates
> that no sleeping functions must be called (currently: only
> pinctrl_gpio_can_use_line()).
>
> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
> ---
> drivers/gpio/gpiolib-cdev.c | 16 ++++++++++------
> 1 file changed, 10 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/gpio/gpiolib-cdev.c b/drivers/gpio/gpiolib-cdev.c
> index b0050250ac3a..8c48a53b4fa8 100644
> --- a/drivers/gpio/gpiolib-cdev.c
> +++ b/drivers/gpio/gpiolib-cdev.c
> @@ -2361,7 +2361,7 @@ static void gpio_v2_line_info_changed_to_v1(
> #endif /* CONFIG_GPIO_CDEV_V1 */
>
> static void gpio_desc_to_lineinfo(struct gpio_desc *desc,
> - struct gpio_v2_line_info *info)
> + struct gpio_v2_line_info *info, bool atomic)
> {
> unsigned long dflags;
> const char *label;
> @@ -2402,9 +2402,13 @@ static void gpio_desc_to_lineinfo(struct gpio_desc *desc,
> test_bit(FLAG_USED_AS_IRQ, &dflags) ||
> test_bit(FLAG_EXPORT, &dflags) ||
> test_bit(FLAG_SYSFS, &dflags) ||
> - !gpiochip_line_is_valid(guard.gc, info->offset) ||
> - !pinctrl_gpio_can_use_line(guard.gc, info->offset))
> + !gpiochip_line_is_valid(guard.gc, info->offset))
> info->flags |= GPIO_V2_LINE_FLAG_USED;
> +
> + if (!atomic) {
> + if (!pinctrl_gpio_can_use_line(guard.gc, info->offset))
> + info->flags |= GPIO_V2_LINE_FLAG_USED;
> + }
>
Should be else if.
Cheers,
Kent.
> if (test_bit(FLAG_IS_OUT, &dflags))
> info->flags |= GPIO_V2_LINE_FLAG_OUTPUT;
> @@ -2502,7 +2506,7 @@ static int lineinfo_get_v1(struct gpio_chardev_data *cdev, void __user *ip,
> return -EBUSY;
> }
>
> - gpio_desc_to_lineinfo(desc, &lineinfo_v2);
> + gpio_desc_to_lineinfo(desc, &lineinfo_v2, false);
> gpio_v2_line_info_to_v1(&lineinfo_v2, &lineinfo);
>
> if (copy_to_user(ip, &lineinfo, sizeof(lineinfo))) {
> @@ -2539,7 +2543,7 @@ static int lineinfo_get(struct gpio_chardev_data *cdev, void __user *ip,
> if (test_and_set_bit(lineinfo.offset, cdev->watched_lines))
> return -EBUSY;
> }
> - gpio_desc_to_lineinfo(desc, &lineinfo);
> + gpio_desc_to_lineinfo(desc, &lineinfo, false);
> supinfo_to_lineinfo(desc, &lineinfo);
>
> if (copy_to_user(ip, &lineinfo, sizeof(lineinfo))) {
> @@ -2632,7 +2636,7 @@ static int lineinfo_changed_notify(struct notifier_block *nb,
> memset(&chg, 0, sizeof(chg));
> chg.event_type = action;
> chg.timestamp_ns = ktime_get_ns();
> - gpio_desc_to_lineinfo(desc, &chg.info);
> + gpio_desc_to_lineinfo(desc, &chg.info, false);
> supinfo_to_lineinfo(desc, &chg.info);
>
> ret = kfifo_in_spinlocked(&cdev->events, &chg, 1, &cdev->wait.lock);
>
> --
> 2.43.0
>
next prev parent reply other threads:[~2024-10-14 1:58 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-10 9:10 [PATCH v2 0/6] gpio: notify user-space about config changes in the kernel Bartosz Golaszewski
2024-10-10 9:10 ` [PATCH v2 1/6] gpiolib: notify user-space when a driver requests its own desc Bartosz Golaszewski
2024-10-10 9:10 ` [PATCH v2 2/6] gpio: cdev: prepare gpio_desc_to_lineinfo() for being called from atomic Bartosz Golaszewski
2024-10-14 1:58 ` Kent Gibson [this message]
2024-10-14 7:45 ` Bartosz Golaszewski
2024-10-14 8:32 ` Kent Gibson
2024-10-14 8:41 ` Bartosz Golaszewski
2024-10-10 9:10 ` [PATCH v2 3/6] gpiolib: add a per-gpio_device line state notification workqueue Bartosz Golaszewski
2024-10-10 9:10 ` [PATCH v2 4/6] gpio: cdev: put emitting the line state events on a workqueue Bartosz Golaszewski
2024-10-14 2:09 ` Kent Gibson
2024-10-14 7:47 ` Bartosz Golaszewski
2024-10-10 9:10 ` [PATCH v2 5/6] gpiolib: switch the line state notifier to atomic Bartosz Golaszewski
2024-10-14 2:11 ` Kent Gibson
2024-10-14 7:48 ` Bartosz Golaszewski
2024-10-14 9:24 ` Kent Gibson
2024-10-14 9:27 ` Bartosz Golaszewski
2024-10-14 9:29 ` Kent Gibson
2024-10-14 9:32 ` Bartosz Golaszewski
2024-10-14 9:55 ` Kent Gibson
2024-10-14 9:57 ` Bartosz Golaszewski
2024-10-10 9:10 ` [PATCH v2 6/6] gpiolib: notify user-space about in-kernel line state changes Bartosz Golaszewski
2024-10-14 2:24 ` Kent Gibson
2024-10-14 8:13 ` Bartosz Golaszewski
2024-10-14 8:42 ` Kent Gibson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241014015817.GA20620@rigel \
--to=warthog618@gmail.com \
--cc=bartosz.golaszewski@linaro.org \
--cc=brgl@bgdev.pl \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).