From: Conor Dooley <conor@kernel.org>
To: Bartosz Golaszewski <brgl@bgdev.pl>
Cc: linux-gpio@vger.kernel.org,
Conor Dooley <conor.dooley@microchip.com>,
Daire McNamara <daire.mcnamara@microchip.com>,
valentina.fernandezalanis@microchip.com,
Linus Walleij <linus.walleij@linaro.org>,
Lewis Hanly <lewis.hanly@microchip.com>
Subject: Re: [PATCH v8 1/1] gpio: mpfs: add polarfire soc gpio support
Date: Thu, 24 Oct 2024 11:32:49 +0100 [thread overview]
Message-ID: <20241024-scuba-figment-d5a40aa3beba@spud> (raw)
In-Reply-To: <CAMRc=Md7sqoXbn2tSu23PqjLRat_3dUe80x0QpCHyppEZLacsw@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 385 bytes --]
On Thu, Oct 24, 2024 at 11:57:04AM +0200, Bartosz Golaszewski wrote:
> On Thu, Oct 24, 2024 at 11:21 AM Conor Dooley <conor@kernel.org> wrote:
> > + ret = gpiochip_add_data(&mpfs_gpio->gc, mpfs_gpio);
>
> Use devm_gpiochip_add_data() and remove remove()?
You know, I feel like an idiot. I grepped for this, with the goal of
dropping the remove, and must have typoed.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
prev parent reply other threads:[~2024-10-24 10:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-24 9:20 [PATCH v8 0/1] Polarfire SoC GPIO support Conor Dooley
2024-10-24 9:20 ` [PATCH v8 1/1] gpio: mpfs: add polarfire soc gpio support Conor Dooley
2024-10-24 9:57 ` Bartosz Golaszewski
2024-10-24 10:32 ` Conor Dooley [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241024-scuba-figment-d5a40aa3beba@spud \
--to=conor@kernel.org \
--cc=brgl@bgdev.pl \
--cc=conor.dooley@microchip.com \
--cc=daire.mcnamara@microchip.com \
--cc=lewis.hanly@microchip.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=valentina.fernandezalanis@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).