* [PATCH v1 1/1] pinctrl: intel: Add a human readable decoder for pull bias values
@ 2024-10-24 15:10 Andy Shevchenko
2024-10-24 15:28 ` Mika Westerberg
0 siblings, 1 reply; 3+ messages in thread
From: Andy Shevchenko @ 2024-10-24 15:10 UTC (permalink / raw)
To: Andy Shevchenko, linux-gpio, linux-kernel
Cc: Mika Westerberg, Andy Shevchenko, Linus Walleij
Add a human readable decoder for pull bias values in the comment.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
drivers/pinctrl/intel/pinctrl-intel.c | 12 ++++++++++++
1 file changed, 12 insertions(+)
diff --git a/drivers/pinctrl/intel/pinctrl-intel.c b/drivers/pinctrl/intel/pinctrl-intel.c
index f6f6d3970d5d..86cabb73904f 100644
--- a/drivers/pinctrl/intel/pinctrl-intel.c
+++ b/drivers/pinctrl/intel/pinctrl-intel.c
@@ -85,6 +85,18 @@
#define PADCFG1_TERM_UP BIT(13)
#define PADCFG1_TERM_SHIFT 10
#define PADCFG1_TERM_MASK GENMASK(12, 10)
+/*
+ * Bit 0 Bit 1 Bit 2 Value, Ohms
+ *
+ * 0 0 0 -
+ * 0 0 1 20000
+ * 0 1 0 5000
+ * 0 1 1 ~4000
+ * 1 0 0 1000 (if supported)
+ * 1 0 1 ~952 (if supported)
+ * 1 1 0 ~833 (if supported)
+ * 1 1 1 ~800 (if supported)
+ */
#define PADCFG1_TERM_20K BIT(2)
#define PADCFG1_TERM_5K BIT(1)
#define PADCFG1_TERM_4K (BIT(2) | BIT(1))
--
2.43.0.rc1.1336.g36b5255a03ac
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v1 1/1] pinctrl: intel: Add a human readable decoder for pull bias values
2024-10-24 15:10 [PATCH v1 1/1] pinctrl: intel: Add a human readable decoder for pull bias values Andy Shevchenko
@ 2024-10-24 15:28 ` Mika Westerberg
2024-10-24 15:49 ` Andy Shevchenko
0 siblings, 1 reply; 3+ messages in thread
From: Mika Westerberg @ 2024-10-24 15:28 UTC (permalink / raw)
To: Andy Shevchenko; +Cc: linux-gpio, linux-kernel, Andy Shevchenko, Linus Walleij
On Thu, Oct 24, 2024 at 06:10:44PM +0300, Andy Shevchenko wrote:
> Add a human readable decoder for pull bias values in the comment.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
This is nice!
Acked-by: Mika Westerberg <mika.westerberg@linux.intel.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v1 1/1] pinctrl: intel: Add a human readable decoder for pull bias values
2024-10-24 15:28 ` Mika Westerberg
@ 2024-10-24 15:49 ` Andy Shevchenko
0 siblings, 0 replies; 3+ messages in thread
From: Andy Shevchenko @ 2024-10-24 15:49 UTC (permalink / raw)
To: Mika Westerberg; +Cc: linux-gpio, linux-kernel, Linus Walleij
On Thu, Oct 24, 2024 at 06:28:02PM +0300, Mika Westerberg wrote:
> On Thu, Oct 24, 2024 at 06:10:44PM +0300, Andy Shevchenko wrote:
> > Add a human readable decoder for pull bias values in the comment.
> >
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
>
> This is nice!
>
> Acked-by: Mika Westerberg <mika.westerberg@linux.intel.com>
Pushed to my review and testing queue, thanks!
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-10-24 15:49 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-10-24 15:10 [PATCH v1 1/1] pinctrl: intel: Add a human readable decoder for pull bias values Andy Shevchenko
2024-10-24 15:28 ` Mika Westerberg
2024-10-24 15:49 ` Andy Shevchenko
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).