From: mathieu.dubois-briand@bootlin.com
To: "Lee Jones" <lee@kernel.org>, "Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Kamel Bouhara" <kamel.bouhara@bootlin.com>,
"Linus Walleij" <linus.walleij@linaro.org>,
"Bartosz Golaszewski" <brgl@bgdev.pl>,
"Dmitry Torokhov" <dmitry.torokhov@gmail.com>,
"Uwe Kleine-König" <ukleinek@kernel.org>
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-gpio@vger.kernel.org, linux-input@vger.kernel.org,
linux-pwm@vger.kernel.org,
"Grégory Clement" <gregory.clement@bootlin.com>,
"Thomas Petazzoni" <thomas.petazzoni@bootlin.com>,
"Mathieu Dubois-Briand" <mathieu.dubois-briand@bootlin.com>
Subject: [PATCH 4/8] pwm: max7360: Add MAX7360 PWM support
Date: Thu, 19 Dec 2024 17:21:21 +0100 [thread overview]
Message-ID: <20241219-mdb-max7360-support-v1-4-8e8317584121@bootlin.com> (raw)
In-Reply-To: <20241219-mdb-max7360-support-v1-0-8e8317584121@bootlin.com>
From: Kamel Bouhara <kamel.bouhara@bootlin.com>
Add driver for Maxim Integrated MAX7360 PWM controller, supporting up to
8 independent PWM outputs.
Signed-off-by: Kamel Bouhara <kamel.bouhara@bootlin.com>
Signed-off-by: Mathieu Dubois-Briand <mathieu.dubois-briand@bootlin.com>
---
drivers/pwm/Kconfig | 11 +++
drivers/pwm/Makefile | 1 +
drivers/pwm/pwm-max7360.c | 173 ++++++++++++++++++++++++++++++++++++++++++++++
3 files changed, 185 insertions(+)
diff --git a/drivers/pwm/Kconfig b/drivers/pwm/Kconfig
index 0915c1e7df16..399dc3f76e92 100644
--- a/drivers/pwm/Kconfig
+++ b/drivers/pwm/Kconfig
@@ -745,4 +745,15 @@ config PWM_XILINX
To compile this driver as a module, choose M here: the module
will be called pwm-xilinx.
+config PWM_MAX7360
+ tristate "MAX7360 PWMs"
+ depends on MFD_MAX7360
+ depends on OF_GPIO
+ help
+ PWM driver for Maxim Integrated MAX7360 multifunction device, with
+ support for up to 8 PWM outputs.
+
+ To compile this driver as a module, choose M here: the module
+ will be called pwm-max7360.
+
endif
diff --git a/drivers/pwm/Makefile b/drivers/pwm/Makefile
index 9081e0c0e9e0..ae8908ffc892 100644
--- a/drivers/pwm/Makefile
+++ b/drivers/pwm/Makefile
@@ -36,6 +36,7 @@ obj-$(CONFIG_PWM_LPC32XX) += pwm-lpc32xx.o
obj-$(CONFIG_PWM_LPSS) += pwm-lpss.o
obj-$(CONFIG_PWM_LPSS_PCI) += pwm-lpss-pci.o
obj-$(CONFIG_PWM_LPSS_PLATFORM) += pwm-lpss-platform.o
+obj-$(CONFIG_PWM_MAX7360) += pwm-max7360.o
obj-$(CONFIG_PWM_MESON) += pwm-meson.o
obj-$(CONFIG_PWM_MEDIATEK) += pwm-mediatek.o
obj-$(CONFIG_PWM_MICROCHIP_CORE) += pwm-microchip-core.o
diff --git a/drivers/pwm/pwm-max7360.c b/drivers/pwm/pwm-max7360.c
new file mode 100644
index 000000000000..b1cde3e86864
--- /dev/null
+++ b/drivers/pwm/pwm-max7360.c
@@ -0,0 +1,173 @@
+// SPDX-License-Identifier: GPL-2.0-only
+/*
+ * Copyright 2024 Bootlin
+ *
+ * Author: Kamel BOUHARA <kamel.bouhara@bootlin.com>
+ */
+#include <linux/math.h>
+#include <linux/mfd/max7360.h>
+#include <linux/mod_devicetable.h>
+#include <linux/module.h>
+#include <linux/of.h>
+#include <linux/platform_device.h>
+#include <linux/pwm.h>
+#include <linux/regmap.h>
+
+#define MAX7360_NUM_PWMS 8
+#define MAX7360_PWM_MAX_RES 256
+#define MAX7360_PWM_PERIOD_NS 2000000 /* 500 Hz */
+#define MAX7360_PWM_COMMON_PWN BIT(5)
+#define MAX7360_PWM_CTRL_ENABLE(n) BIT(n)
+#define MAX7360_PWM_PORT(n) BIT(n)
+
+struct max7360_pwm {
+ struct device *dev;
+ struct regmap *regmap;
+};
+
+static inline struct max7360_pwm *to_max7360_pwm(struct pwm_chip *chip)
+{
+ return pwmchip_get_drvdata(chip);
+}
+
+static int max7360_pwm_request(struct pwm_chip *chip, struct pwm_device *pwm)
+{
+ struct max7360_pwm *max7360_pwm;
+ int ret;
+
+ max7360_pwm = to_max7360_pwm(chip);
+ ret = max7360_port_pin_request(max7360_pwm->dev->parent, pwm->hwpwm,
+ true);
+ if (ret) {
+ dev_err(&chip->dev, "failed to request pwm-%d\n", pwm->hwpwm);
+ return ret;
+ }
+
+ ret = regmap_write_bits(max7360_pwm->regmap,
+ MAX7360_REG_PWMCFG + pwm->hwpwm,
+ MAX7360_PWM_COMMON_PWN,
+ 0);
+ if (ret) {
+ dev_err(&chip->dev, "failed to write pwm-%d cfg register, error %d\n",
+ pwm->hwpwm, ret);
+ return ret;
+ }
+
+ ret = regmap_write_bits(max7360_pwm->regmap, MAX7360_REG_PORTS,
+ MAX7360_PWM_PORT(pwm->hwpwm),
+ MAX7360_PWM_PORT(pwm->hwpwm));
+ if (ret) {
+ dev_err(&chip->dev, "failed to write pwm-%d ports register, error %d\n",
+ pwm->hwpwm, ret);
+ return ret;
+ }
+
+ return 0;
+}
+
+static void max7360_pwm_free(struct pwm_chip *chip, struct pwm_device *pwm)
+{
+ struct max7360_pwm *max7360_pwm;
+ int ret;
+
+ max7360_pwm = to_max7360_pwm(chip);
+ ret = regmap_write_bits(max7360_pwm->regmap, MAX7360_REG_GPIOCTRL,
+ MAX7360_PWM_CTRL_ENABLE(pwm->hwpwm),
+ 0);
+ if (ret)
+ dev_err(&chip->dev, "failed to enable pwm-%d , error %d\n",
+ pwm->hwpwm, ret);
+
+ max7360_port_pin_request(max7360_pwm->dev->parent, pwm->hwpwm,
+ false);
+}
+
+static int max7360_pwm_apply(struct pwm_chip *chip, struct pwm_device *pwm,
+ const struct pwm_state *state)
+{
+ struct max7360_pwm *max7360_pwm;
+ u64 duty_steps = state->duty_cycle * MAX7360_PWM_MAX_RES;
+ int ret;
+
+ if (state->polarity != PWM_POLARITY_NORMAL)
+ return -EINVAL;
+
+ max7360_pwm = to_max7360_pwm(chip);
+ ret = regmap_write_bits(max7360_pwm->regmap, MAX7360_REG_GPIOCTRL,
+ MAX7360_PWM_CTRL_ENABLE(pwm->hwpwm),
+ MAX7360_PWM_CTRL_ENABLE(pwm->hwpwm));
+ if (ret) {
+ dev_err(&chip->dev, "failed to enable pwm-%d , error %d\n",
+ pwm->hwpwm, ret);
+ return ret;
+ }
+
+ do_div(duty_steps, MAX7360_PWM_PERIOD_NS);
+
+ ret = regmap_write(max7360_pwm->regmap, MAX7360_REG_PWMBASE + pwm->hwpwm,
+ duty_steps >= 255 ? 255 : duty_steps);
+ if (ret) {
+ dev_err(&chip->dev,
+ "failed to apply pwm duty_cycle %llu on pwm-%d, error %d\n",
+ duty_steps, pwm->hwpwm, ret);
+ return ret;
+ }
+
+ return 0;
+}
+
+static const struct pwm_ops max7360_pwm_ops = {
+ .request = max7360_pwm_request,
+ .free = max7360_pwm_free,
+ .apply = max7360_pwm_apply,
+};
+
+static int max7360_pwm_probe(struct platform_device *pdev)
+{
+ struct max7360_pwm *max7360_pwm;
+ struct pwm_chip *chip;
+
+ if (!pdev->dev.parent) {
+ dev_err(&pdev->dev, "no parent device\n");
+ return -ENODEV;
+ }
+
+ chip = devm_pwmchip_alloc(&pdev->dev, MAX7360_NUM_PWMS,
+ sizeof(*max7360_pwm));
+ if (IS_ERR(chip))
+ return PTR_ERR(chip);
+ chip->ops = &max7360_pwm_ops;
+
+ max7360_pwm = to_max7360_pwm(chip);
+ max7360_pwm->dev = &pdev->dev;
+
+ max7360_pwm->regmap = dev_get_regmap(pdev->dev.parent, NULL);
+ if (!max7360_pwm->regmap) {
+ dev_err(&pdev->dev, "could not get parent regmap\n");
+ return -ENODEV;
+ }
+
+ return devm_pwmchip_add(&pdev->dev, chip);
+}
+
+#ifdef CONFIG_OF
+static const struct of_device_id max7360_pwm_of_match[] = {
+ { .compatible = "maxim,max7360-pwm", },
+ { }
+};
+MODULE_DEVICE_TABLE(of, max7360_pwm_of_match);
+#endif
+
+static struct platform_driver max7360_pwm_driver = {
+ .driver = {
+ .name = "max7360-pwm",
+ .of_match_table = of_match_ptr(max7360_pwm_of_match),
+ },
+ .probe = max7360_pwm_probe,
+};
+module_platform_driver(max7360_pwm_driver);
+
+MODULE_DESCRIPTION("MAX7360 PWM driver");
+MODULE_AUTHOR("Kamel BOUHARA <kamel.bouhara@bootlin.com>");
+MODULE_ALIAS("platform:max7360-pwm");
+MODULE_LICENSE("GPL");
--
2.39.5
next prev parent reply other threads:[~2024-12-19 16:21 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-19 16:21 [PATCH 0/8] Add support for MAX7360 multifunction device Mathieu Dubois-Briand
2024-12-19 16:21 ` [PATCH 1/8] dt-bindings: Add MAX7360 MFD device Mathieu Dubois-Briand
2024-12-21 20:28 ` Krzysztof Kozlowski
2024-12-19 16:21 ` [PATCH 2/8] dt-bindings: Add MAX7360 subdevices Mathieu Dubois-Briand
2024-12-19 21:54 ` Uwe Kleine-König
2024-12-21 20:34 ` Krzysztof Kozlowski
2024-12-23 15:20 ` Mathieu Dubois-Briand
2024-12-24 9:00 ` Krzysztof Kozlowski
2024-12-24 12:10 ` Mathieu Dubois-Briand
2024-12-19 16:21 ` [PATCH 3/8] mfd: Add max7360 support mathieu.dubois-briand
2024-12-20 23:01 ` kernel test robot
2024-12-19 16:21 ` mathieu.dubois-briand [this message]
2024-12-19 21:53 ` [PATCH 4/8] pwm: max7360: Add MAX7360 PWM support Uwe Kleine-König
2024-12-23 15:26 ` Mathieu Dubois-Briand
2024-12-20 5:51 ` Uwe Kleine-König
2024-12-21 20:35 ` Krzysztof Kozlowski
2024-12-19 16:21 ` [PATCH 5/8] gpio: max7360: Add MAX7360 gpio support Mathieu Dubois-Briand
2024-12-20 15:54 ` kernel test robot
2024-12-20 16:39 ` kernel test robot
2024-12-19 16:21 ` [PATCH 6/8] input: keyboard: Add support for MAX7360 keypad Mathieu Dubois-Briand
2024-12-19 19:35 ` Dmitry Torokhov
2024-12-23 15:38 ` Mathieu Dubois-Briand
2024-12-20 17:12 ` kernel test robot
2024-12-19 16:21 ` [PATCH 7/8] input: misc: Add support for MAX7360 rotary Mathieu Dubois-Briand
2024-12-19 16:21 ` [PATCH 8/8] MAINTAINERS: Add entry on MAX7360 driver Mathieu Dubois-Briand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241219-mdb-max7360-support-v1-4-8e8317584121@bootlin.com \
--to=mathieu.dubois-briand@bootlin.com \
--cc=brgl@bgdev.pl \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=gregory.clement@bootlin.com \
--cc=kamel.bouhara@bootlin.com \
--cc=krzk+dt@kernel.org \
--cc=lee@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=robh@kernel.org \
--cc=thomas.petazzoni@bootlin.com \
--cc=ukleinek@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox