From: Artur Weber <aweber.kernel@gmail.com>
To: Ray Jui <rjui@broadcom.com>,
Broadcom internal kernel review list
<bcm-kernel-feedback-list@broadcom.com>,
Linus Walleij <linus.walleij@linaro.org>,
Bartosz Golaszewski <brgl@bgdev.pl>,
Florian Fainelli <florian.fainelli@broadcom.com>,
Scott Branden <sbranden@broadcom.com>,
Markus Mayer <markus.mayer@linaro.org>,
Tim Kryger <tim.kryger@linaro.org>,
Matt Porter <matt.porter@linaro.org>,
Markus Mayer <mmayer@broadcom.com>,
Christian Daudt <csd@broadcom.com>
Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
~postmarketos/upstreaming@lists.sr.ht,
Artur Weber <aweber.kernel@gmail.com>
Subject: [PATCH 0/3] gpio: bcm-kona: Various GPIO fixups
Date: Thu, 30 Jan 2025 18:10:36 +0100 [thread overview]
Message-ID: <20250130-kona-gpio-fixes-v1-0-dd61e0c0a9e7@gmail.com> (raw)
Fixes two issues that were preventing GPIO from working correctly:
- Lock/unlock functions tried to write the wrong bit to the unlock
registers for GPIOs with numbers larger than 32
- GPIOs only initialized as IRQs did not unlock the configuration
registers, causing IRQ-related configuration (e.g. setting the IRQ
type) to fail.
Also includes a minor fix to add a missing newline to an error message.
Tested on a Samsung Galaxy Grand Neo (baffinlite rev02) with a BCM23550
(DTS not yet in mainline).
Signed-off-by: Artur Weber <aweber.kernel@gmail.com>
---
Artur Weber (3):
gpio: bcm-kona: Fix GPIO lock/unlock for banks above bank 0
gpio: bcm-kona: Make sure GPIO bits are unlocked when requesting IRQ
gpio: bcm-kona: Add missing newline to dev_err format string
drivers/gpio/gpio-bcm-kona.c | 73 ++++++++++++++++++++++++++++++++++++--------
1 file changed, 60 insertions(+), 13 deletions(-)
---
base-commit: ffd294d346d185b70e28b1a28abe367bbfe53c04
change-id: 20250130-kona-gpio-fixes-6e74595e69f2
Best regards,
--
Artur Weber <aweber.kernel@gmail.com>
next reply other threads:[~2025-01-30 17:10 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-30 17:10 Artur Weber [this message]
2025-01-30 17:10 ` [PATCH 1/3] gpio: bcm-kona: Fix GPIO lock/unlock for banks above bank 0 Artur Weber
2025-01-30 21:33 ` Florian Fainelli
2025-01-30 22:00 ` Markus Mayer
2025-01-30 17:10 ` [PATCH 2/3] gpio: bcm-kona: Make sure GPIO bits are unlocked when requesting IRQ Artur Weber
2025-01-30 21:35 ` Florian Fainelli
2025-01-30 21:46 ` Artur Weber
2025-01-30 22:07 ` Florian Fainelli
2025-01-30 22:13 ` Florian Fainelli
2025-01-30 22:36 ` Markus Mayer
2025-01-30 17:10 ` [PATCH 3/3] gpio: bcm-kona: Add missing newline to dev_err format string Artur Weber
2025-01-30 18:41 ` Florian Fainelli
2025-01-30 22:08 ` Markus Mayer
2025-02-06 9:34 ` [PATCH 0/3] gpio: bcm-kona: Various GPIO fixups Linus Walleij
2025-02-06 9:36 ` Linus Walleij
2025-02-06 15:37 ` Artur Weber
2025-02-06 17:48 ` Artur Weber
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250130-kona-gpio-fixes-v1-0-dd61e0c0a9e7@gmail.com \
--to=aweber.kernel@gmail.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=brgl@bgdev.pl \
--cc=csd@broadcom.com \
--cc=florian.fainelli@broadcom.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=markus.mayer@linaro.org \
--cc=matt.porter@linaro.org \
--cc=mmayer@broadcom.com \
--cc=rjui@broadcom.com \
--cc=sbranden@broadcom.com \
--cc=tim.kryger@linaro.org \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).