From: Bartosz Golaszewski <brgl@bgdev.pl>
To: Vincent Fazio <vfazio@xes-inc.com>,
Kent Gibson <warthog618@gmail.com>,
Linus Walleij <linus.walleij@linaro.org>,
Erik Schilling <erik.schilling@linaro.org>,
Phil Howard <phil@gadgetoid.com>,
Viresh Kumar <viresh.kumar@linaro.org>
Cc: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>,
linux-gpio@vger.kernel.org
Subject: [PATCH libgpiod v3 09/16] dbus: improve comments in API xml
Date: Thu, 06 Feb 2025 13:22:06 +0100 [thread overview]
Message-ID: <20250206-improve-docs-v3-9-2065191fff6f@linaro.org> (raw)
In-Reply-To: <20250206-improve-docs-v3-0-2065191fff6f@linaro.org>
From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
The current comments don't follow any particular formatting so the
resulting .rst generated with gdbus-codegen is all mangled up. Use
proper .rst formatting to make docs better.
Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
---
dbus/lib/io.gpiod1.xml | 98 ++++++++++++++++++++++++++------------------------
1 file changed, 52 insertions(+), 46 deletions(-)
diff --git a/dbus/lib/io.gpiod1.xml b/dbus/lib/io.gpiod1.xml
index ace7d72..411ea6e 100644
--- a/dbus/lib/io.gpiod1.xml
+++ b/dbus/lib/io.gpiod1.xml
@@ -1,5 +1,5 @@
<!-- SPDX-License-Identifier: CC-BY-SA-4.0 -->
-<!-- SPDX-FileCopyrightText: 2022-2024 Bartosz Golaszewski <bartosz.golaszewski@linaro.org> -->
+<!-- SPDX-FileCopyrightText: 2022-2025 Bartosz Golaszewski <bartosz.golaszewski@linaro.org> -->
<!DOCTYPE node PUBLIC "-//freedesktop//DTD D-BUS Object Introspection 1.0//EN"
"http://www.freedesktop.org/standards/dbus/1.0/introspect.dtd">
@@ -54,58 +54,60 @@
contains the list of default output values which are only used in output
mode.
- Available line config options:
+ **Available line config options:**
- "direction" => String representing the line direction. Accepts the
- following values: "input", "output".
- "edge" => String representing the edge detection setting. Accepts the
- following values: "falling", "rising", "both".
- "active-low" => Boolean representing the active-low setting.
- "drive" => String representing the drive settings. Accepts the
- following values: "push-pull", "open-drain", "open-source".
- "bias" => String representing the internal bias settings. Accepts the
- following values: "disabled", "pull-up", "pull-down", "as-is".
- "debounce-period" => Debounce period in microseconds represented as a
- signed, 64-bit integer.
- "event-clock" => String representing the clock used to timestamp edge
- events. Accepts the following values: "monotonic",
- "realtime", "hte".
+ - **"direction"**: String representing the line direction.
+ Accepts the following values: "input", "output".
+ - **"edge"**: String representing the edge detection setting.
+ Accepts the following values: "falling", "rising", "both".
+ - **"active-low"**: Boolean representing the active-low setting.
+ - **"drive"**: String representing the drive settings.
+ Accepts the following values: "push-pull", "open-drain", "open-source".
+ - **"bias"**: String representing the internal bias settings.
+ Accepts the following values: "disabled", "pull-up", "pull-down", "as-is".
+ - **"debounce-period"**: Debounce period in microseconds, represented as a
+ signed 64-bit integer.
+ - **"event-clock"**: String representing the clock used to timestamp edge
+ events.
+ Accepts the following values: "monotonic", "realtime", "hte".
Output values are applied to the lines in the order they appear in the
settings mappings.
- Example variant that allows to request lines at offsets 1, 5 and 11 in
- output, push-pull and active-low modes and specifies the output values
- as active (as visualized with g_variant_print()):
+ **Example variant** that allows requesting lines at offsets 1, 5, and 11
+ in output, push-pull, and active-low modes, and specifies the output
+ values as active (as visualized with `g_variant_print()`):
- // Line config tuple
- (
- // Array of line settings mappings
- [
- // Single mapping tuple
- (
- // Offsets to map
- [1, 5, 11],
- // Line settings dict
- {
- 'direction': <'output'>,
- 'drive': <'push-pull'>,
- 'active-low': <true>
- }
- )
- ],
- // Output values
- [1, 1, 1]
- )
+ .. code-block:: none
+
+ // Line config tuple
+ (
+ // Array of line settings mappings
+ [
+ // Single mapping tuple
+ (
+ // Offsets to map
+ [1, 5, 11],
+ // Line settings dict
+ {
+ 'direction': <'output'>,
+ 'drive': <'push-pull'>,
+ 'active-low': <true>
+ }
+ )
+ ],
+ // Output values
+ [1, 1, 1]
+ )
Request configuration is a hashmap mapping names of the available config
options to their values wrapped in a variant.
- Available request config options:
+ **Available request config options:**
- "consumer" => Consumer name as a string
- "event-buffer-size" => Requested size of the in-kernel edge event
- buffer as an unsigned 32-bit integer.
+ - **"consumer"**: Consumer name as a string.
+ - **"event-buffer-size"**: Requested size of the in-kernel edge event buffer,
+ as an unsigned 32-bit integer.
The object path to the new request is returned on success. The user
should wait for it to appear before trying to use the requested lines in
@@ -239,8 +241,7 @@
<!--
EdgeEvent:
- @event_data: Contains the edge (1 for rising, 0 for falling), timestamp
- in nanoseconds and the global & line-local sequence numbers.
+ @event_data: Edge, timestamp and the global & line-local sequence numbers.
If the line is managed by the gpio-manager and is requested with edge
detection enabled then this signal will be emitted for every edge event
@@ -249,6 +250,9 @@
D-Bus EdgeEvent signals are designed for low-to-medium frequency
interrupts. If you performance better than the order of tens of HZ, you
should probably access the line directly using the kernel uAPI.
+
+ The edge contains 1 for rising and 0 for falling. The timestamp is
+ expressed in nanoseconds.
-->
<signal name='EdgeEvent'>
<arg name='event_data' type='(ittt)'/>
@@ -287,11 +291,13 @@
<!--
ReconfigureLines:
- @line_config: Line configuration. Refer to the RequestLines method of
- the io.gpiod1.Chip interface for details.
+ @line_config: Line configuration.
Change the configuration of lines held by this request object without
releasing them.
+
+ Refer to the RequestLines method of the io.gpiod1.Chip interface for
+ details on line configuration.
-->
<method name='ReconfigureLines'>
<arg name='line_config' direction='in' type='(a(aua{sv})ai)'/>
--
2.45.2
next prev parent reply other threads:[~2025-02-06 12:22 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-06 12:21 [PATCH libgpiod v3 00/16] doc: improvements for ReadTheDocs Bartosz Golaszewski
2025-02-06 12:21 ` [PATCH libgpiod v3 01/16] build: set PACKAGE_URL Bartosz Golaszewski
2025-02-06 12:21 ` [PATCH libgpiod v3 02/16] bindings: cxx: doc: remove the gpiod_cxx doxygen group Bartosz Golaszewski
2025-02-06 12:22 ` [PATCH libgpiod v3 03/16] bindings: python: doc: update the docstring for gpiod.request_lines() Bartosz Golaszewski
2025-02-06 12:22 ` [PATCH libgpiod v3 04/16] bindings: python: doc: make code examples appear as such in sphinx Bartosz Golaszewski
2025-02-06 12:22 ` [PATCH libgpiod v3 05/16] bindings: python: doc: describe undocumented members Bartosz Golaszewski
2025-02-06 12:22 ` [PATCH libgpiod v3 06/16] bindings: glib: add the configuration file for gi-docgen Bartosz Golaszewski
2025-02-06 12:22 ` [PATCH libgpiod v3 07/16] dbus: daemon: add a more detailed description to help text Bartosz Golaszewski
2025-02-06 12:22 ` [PATCH libgpiod v3 08/16] dbus: client: tweak " Bartosz Golaszewski
2025-02-06 12:22 ` Bartosz Golaszewski [this message]
2025-02-06 12:22 ` [PATCH libgpiod v3 10/16] doc: create man entries for gpio-manager and gpiocli Bartosz Golaszewski
2025-02-06 12:22 ` [PATCH libgpiod v3 11/16] doc: provide sphinx docs for the core C API and C++ bindings Bartosz Golaszewski
2025-02-10 14:53 ` [External] - " Vincent Fazio
2025-02-11 12:19 ` Bartosz Golaszewski
2025-02-06 12:22 ` [PATCH libgpiod v3 12/16] doc: add documentation for python bindings Bartosz Golaszewski
2025-02-06 12:22 ` [PATCH libgpiod v3 13/16] doc: add documentation for GLib bindings Bartosz Golaszewski
2025-02-10 15:10 ` [External] - " Vincent Fazio
2025-02-11 12:51 ` Bartosz Golaszewski
2025-02-06 12:22 ` [PATCH libgpiod v3 14/16] doc: add documentation for gpio-tools Bartosz Golaszewski
2025-02-06 12:22 ` [PATCH libgpiod v3 15/16] doc: add documentation for D-Bus API, daemon and command-line client Bartosz Golaszewski
2025-02-06 12:22 ` [PATCH libgpiod v3 16/16] doc: move README contents to sphinx docs Bartosz Golaszewski
2025-02-10 13:48 ` [External] - " Vincent Fazio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250206-improve-docs-v3-9-2065191fff6f@linaro.org \
--to=brgl@bgdev.pl \
--cc=bartosz.golaszewski@linaro.org \
--cc=erik.schilling@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=phil@gadgetoid.com \
--cc=vfazio@xes-inc.com \
--cc=viresh.kumar@linaro.org \
--cc=warthog618@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).