Linux GPIO subsystem development
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: Koichiro Den <koichiro.den@canonical.com>, linux-gpio@vger.kernel.org
Cc: oe-kbuild-all@lists.linux.dev, brgl@bgdev.pl,
	geert+renesas@glider.be, linus.walleij@linaro.org,
	maciej.borzecki@canonical.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 05/13] gpio: virtuser: convert to use gpio-pseudo utilities
Date: Sun, 16 Feb 2025 23:32:47 +0800	[thread overview]
Message-ID: <202502162345.FT5z7kr9-lkp@intel.com> (raw)
In-Reply-To: <20250216125816.14430-6-koichiro.den@canonical.com>

Hi Koichiro,

kernel test robot noticed the following build errors:

[auto build test ERROR on brgl/gpio/for-next]
[also build test ERROR on linus/master v6.14-rc2 next-20250214]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Koichiro-Den/gpio-aggregator-reorder-functions-to-prepare-for-configfs-introduction/20250216-210413
base:   https://git.kernel.org/pub/scm/linux/kernel/git/brgl/linux.git gpio/for-next
patch link:    https://lore.kernel.org/r/20250216125816.14430-6-koichiro.den%40canonical.com
patch subject: [PATCH v3 05/13] gpio: virtuser: convert to use gpio-pseudo utilities
config: csky-randconfig-002-20250216 (https://download.01.org/0day-ci/archive/20250216/202502162345.FT5z7kr9-lkp@intel.com/config)
compiler: csky-linux-gcc (GCC) 14.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250216/202502162345.FT5z7kr9-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202502162345.FT5z7kr9-lkp@intel.com/

All errors (new ones prefixed by >>):

   drivers/gpio/gpio-pseudo.c: In function 'pseudo_gpio_register':
>> drivers/gpio/gpio-pseudo.c:62:17: error: implicit declaration of function 'kfree'; did you mean 'kvfree'? [-Wimplicit-function-declaration]
      62 |                 kfree(common->name);
         |                 ^~~~~
         |                 kvfree


vim +62 drivers/gpio/gpio-pseudo.c

ef524a2229b717 Koichiro Den 2025-02-16  43  
ef524a2229b717 Koichiro Den 2025-02-16  44  int pseudo_gpio_register(struct pseudo_gpio_common *common,
ef524a2229b717 Koichiro Den 2025-02-16  45  			 struct platform_device_info *pdevinfo)
ef524a2229b717 Koichiro Den 2025-02-16  46  {
ef524a2229b717 Koichiro Den 2025-02-16  47  	struct platform_device *pdev;
ef524a2229b717 Koichiro Den 2025-02-16  48  	char *name;
ef524a2229b717 Koichiro Den 2025-02-16  49  
ef524a2229b717 Koichiro Den 2025-02-16  50  	name = kasprintf(GFP_KERNEL, "%s.%u", pdevinfo->name, pdevinfo->id);
ef524a2229b717 Koichiro Den 2025-02-16  51  	if (!name)
ef524a2229b717 Koichiro Den 2025-02-16  52  		return -ENOMEM;
ef524a2229b717 Koichiro Den 2025-02-16  53  
ef524a2229b717 Koichiro Den 2025-02-16  54  	common->driver_bound = false;
ef524a2229b717 Koichiro Den 2025-02-16  55  	common->name = name;
ef524a2229b717 Koichiro Den 2025-02-16  56  	reinit_completion(&common->probe_completion);
ef524a2229b717 Koichiro Den 2025-02-16  57  	bus_register_notifier(&platform_bus_type, &common->bus_notifier);
ef524a2229b717 Koichiro Den 2025-02-16  58  
ef524a2229b717 Koichiro Den 2025-02-16  59  	pdev = platform_device_register_full(pdevinfo);
ef524a2229b717 Koichiro Den 2025-02-16  60  	if (IS_ERR(pdev)) {
ef524a2229b717 Koichiro Den 2025-02-16  61  		bus_unregister_notifier(&platform_bus_type, &common->bus_notifier);
ef524a2229b717 Koichiro Den 2025-02-16 @62  		kfree(common->name);
ef524a2229b717 Koichiro Den 2025-02-16  63  		return PTR_ERR(pdev);
ef524a2229b717 Koichiro Den 2025-02-16  64  	}
ef524a2229b717 Koichiro Den 2025-02-16  65  
ef524a2229b717 Koichiro Den 2025-02-16  66  	wait_for_completion(&common->probe_completion);
ef524a2229b717 Koichiro Den 2025-02-16  67  	bus_unregister_notifier(&platform_bus_type, &common->bus_notifier);
ef524a2229b717 Koichiro Den 2025-02-16  68  
ef524a2229b717 Koichiro Den 2025-02-16  69  	if (!common->driver_bound) {
ef524a2229b717 Koichiro Den 2025-02-16  70  		platform_device_unregister(pdev);
ef524a2229b717 Koichiro Den 2025-02-16  71  		kfree(common->name);
ef524a2229b717 Koichiro Den 2025-02-16  72  		return -ENXIO;
ef524a2229b717 Koichiro Den 2025-02-16  73  	}
ef524a2229b717 Koichiro Den 2025-02-16  74  
ef524a2229b717 Koichiro Den 2025-02-16  75  	common->pdev = pdev;
ef524a2229b717 Koichiro Den 2025-02-16  76  	return 0;
ef524a2229b717 Koichiro Den 2025-02-16  77  }
ef524a2229b717 Koichiro Den 2025-02-16  78  EXPORT_SYMBOL_GPL(pseudo_gpio_register);
ef524a2229b717 Koichiro Den 2025-02-16  79  

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

  reply	other threads:[~2025-02-16 15:33 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-16 12:58 [PATCH v3 00/13] Introduce configfs-based interface for gpio-aggregator Koichiro Den
2025-02-16 12:58 ` [PATCH v3 01/13] gpio: aggregator: reorder functions to prepare for configfs introduction Koichiro Den
2025-02-17 13:07   ` Geert Uytterhoeven
2025-02-17 14:34     ` Koichiro Den
2025-02-16 12:58 ` [PATCH v3 02/13] gpio: aggregator: protect driver attr handlers against module unload Koichiro Den
2025-02-16 12:58 ` [PATCH v3 03/13] gpio: pseudo: common helper functions for pseudo gpio devices Koichiro Den
2025-02-16 12:58 ` [PATCH v3 04/13] gpio: sim: convert to use gpio-pseudo utilities Koichiro Den
2025-02-16 12:58 ` [PATCH v3 05/13] gpio: virtuser: " Koichiro Den
2025-02-16 15:32   ` kernel test robot [this message]
2025-02-16 16:25   ` kernel test robot
2025-02-16 12:58 ` [PATCH v3 06/13] gpio: aggregator: " Koichiro Den
2025-02-16 12:58 ` [PATCH v3 07/13] gpio: aggregator: add aggr_alloc()/aggr_free() Koichiro Den
2025-02-16 12:58 ` [PATCH v3 08/13] gpio: aggregator: introduce basic configfs interface Koichiro Den
2025-02-16 12:58 ` [PATCH v3 09/13] gpio: aggregator: add 'name' attribute for custom GPIO line names Koichiro Den
2025-02-16 12:58 ` [PATCH v3 10/13] gpio: aggregator: rename 'name' to 'key' in aggr_parse() Koichiro Den
2025-02-17 13:08   ` Geert Uytterhoeven
2025-02-16 12:58 ` [PATCH v3 11/13] gpio: aggregator: expose aggregator created via legacy sysfs to configfs Koichiro Den
2025-02-16 12:58 ` [PATCH v3 12/13] gpio: aggregator: cancel deferred probe for devices created via configfs Koichiro Den
2025-02-16 12:58 ` [PATCH v3 13/13] Documentation: gpio: document configfs interface for gpio-aggregator Koichiro Den
2025-02-16 15:56 ` [PATCH v3 00/13] Introduce configfs-based " Bartosz Golaszewski
2025-02-17  1:07   ` Koichiro Den
2025-02-17  1:17     ` Koichiro Den
2025-02-17  8:12       ` Bartosz Golaszewski
2025-02-17 12:42         ` Koichiro Den

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202502162345.FT5z7kr9-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=brgl@bgdev.pl \
    --cc=geert+renesas@glider.be \
    --cc=koichiro.den@canonical.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maciej.borzecki@canonical.com \
    --cc=oe-kbuild-all@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox