linux-gpio.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Bartosz Golaszewski <brgl@bgdev.pl>
To: "Linus Walleij" <linus.walleij@linaro.org>,
	"Bartosz Golaszewski" <brgl@bgdev.pl>,
	"Michael Walle" <mwalle@kernel.org>,
	"Bamvor Jian Zhang" <bamv2005@gmail.com>,
	"Geert Uytterhoeven" <geert+renesas@glider.be>,
	Keerthy <j-keerthy@ti.com>,
	"Uwe Kleine-König" <ukleinek@kernel.org>
Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
	 linux-pwm@vger.kernel.org,
	 Bartosz Golaszewski <bartosz.golaszewski@linaro.org>,
	 Lee Jones <lee@kernel.org>, Pavel Machek <pavel@kernel.org>,
	 linux-leds@vger.kernel.org, kernel test robot <lkp@intel.com>
Subject: [PATCH v2 01/15] leds: aw200xx: don't use return with gpiod_set_value() variants
Date: Thu, 20 Feb 2025 10:56:58 +0100	[thread overview]
Message-ID: <20250220-gpio-set-retval-v2-1-bc4cfd38dae3@linaro.org> (raw)
In-Reply-To: <20250220-gpio-set-retval-v2-0-bc4cfd38dae3@linaro.org>

From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>

While gpiod_set_value() currently returns void, it will soon be converted
to return an integer instead. Don't do `return gpiod_set...`.

Cc: Lee Jones <lee@kernel.org>
Cc: Pavel Machek <pavel@kernel.org>
Cc: linux-leds@vger.kernel.org
Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202502121512.CmoMg9Q7-lkp@intel.com/
Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
---
 drivers/leds/leds-aw200xx.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/leds/leds-aw200xx.c b/drivers/leds/leds-aw200xx.c
index 08cca128458c..fe223d363a5d 100644
--- a/drivers/leds/leds-aw200xx.c
+++ b/drivers/leds/leds-aw200xx.c
@@ -379,7 +379,7 @@ static void aw200xx_enable(const struct aw200xx *const chip)
 
 static void aw200xx_disable(const struct aw200xx *const chip)
 {
-	return gpiod_set_value_cansleep(chip->hwen, 0);
+	gpiod_set_value_cansleep(chip->hwen, 0);
 }
 
 static int aw200xx_probe_get_display_rows(struct device *dev,

-- 
2.45.2


  reply	other threads:[~2025-02-20  9:57 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-20  9:56 [PATCH v2 00/15] gpiolib: indicate errors in value setters Bartosz Golaszewski
2025-02-20  9:56 ` Bartosz Golaszewski [this message]
2025-03-06 22:51   ` (subset) [PATCH v2 01/15] leds: aw200xx: don't use return with gpiod_set_value() variants Lee Jones
2025-03-07  7:03     ` Bartosz Golaszewski
2025-03-13 15:29       ` Lee Jones
2025-02-20  9:56 ` [PATCH v2 02/15] gpiolib: make value setters have return values Bartosz Golaszewski
2025-02-20  9:57 ` [PATCH v2 03/15] gpiolib: wrap gpio_chip::set() Bartosz Golaszewski
2025-02-20  9:57 ` [PATCH v2 04/15] gpiolib: rework the wrapper around gpio_chip::set_multiple() Bartosz Golaszewski
2025-02-20  9:57 ` [PATCH v2 05/15] gpiolib: introduce gpio_chip setters that return values Bartosz Golaszewski
     [not found]   ` <CGME20250227140054eucas1p2bf6e3f2416e11e3c62a704682bf052bf@eucas1p2.samsung.com>
2025-02-27 14:00     ` Marek Szyprowski
2025-02-27 14:10       ` Bartosz Golaszewski
2025-02-20  9:57 ` [PATCH v2 06/15] gpio: sim: use value returning setters Bartosz Golaszewski
2025-02-20  9:57 ` [PATCH v2 07/15] gpio: regmap: " Bartosz Golaszewski
2025-02-20 10:08   ` Michael Walle
2025-02-20  9:57 ` [PATCH v2 08/15] gpio: pca953x: " Bartosz Golaszewski
2025-02-20  9:57 ` [PATCH v2 09/15] gpio: mockup: " Bartosz Golaszewski
2025-02-20  9:57 ` [PATCH v2 10/15] gpio: aggregator: " Bartosz Golaszewski
2025-02-20  9:57 ` [PATCH v2 11/15] gpio: max77650: " Bartosz Golaszewski
2025-02-20  9:57 ` [PATCH v2 12/15] gpio: latch: use lock guards Bartosz Golaszewski
2025-02-20  9:57 ` [PATCH v2 13/15] gpio: latch: use value returning setters Bartosz Golaszewski
2025-02-20  9:57 ` [PATCH v2 14/15] gpio: davinci: " Bartosz Golaszewski
2025-02-20  9:57 ` [PATCH v2 15/15] gpio: mvebu: " Bartosz Golaszewski
2025-02-21  9:33 ` [PATCH v2 00/15] gpiolib: indicate errors in value setters Uwe Kleine-König
2025-02-26 10:19 ` Bartosz Golaszewski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250220-gpio-set-retval-v2-1-bc4cfd38dae3@linaro.org \
    --to=brgl@bgdev.pl \
    --cc=bamv2005@gmail.com \
    --cc=bartosz.golaszewski@linaro.org \
    --cc=geert+renesas@glider.be \
    --cc=j-keerthy@ti.com \
    --cc=lee@kernel.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-leds@vger.kernel.org \
    --cc=linux-pwm@vger.kernel.org \
    --cc=lkp@intel.com \
    --cc=mwalle@kernel.org \
    --cc=pavel@kernel.org \
    --cc=ukleinek@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).