Re: [PATCH 2/6] dt-bindings: gpio: add max77759 binding

[Rob Herring <robh@kernel.org>]

On Mon, Feb 24, 2025 at 10:28:50AM +0000, André Draszik wrote:
> Add the DT binding document for the GPIO module of the Maxim MAX77759.
> 
> Signed-off-by: André Draszik <andre.draszik@linaro.org>
> ---
>  .../bindings/gpio/maxim,max77759-gpio.yaml         | 47 ++++++++++++++++++++++
>  1 file changed, 47 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/gpio/maxim,max77759-gpio.yaml b/Documentation/devicetree/bindings/gpio/maxim,max77759-gpio.yaml
> new file mode 100644
> index 000000000000..9bafb16ad688
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/gpio/maxim,max77759-gpio.yaml
> @@ -0,0 +1,47 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/gpio/maxim,max77759-gpio.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Maxim Integrated MAX77759 GPIO
> +
> +maintainers:
> +  - André Draszik <andre.draszik@linaro.org>
> +
> +description: |
> +  This module is part of the MAX77759 PMIC. For additional information, see
> +  Documentation/devicetree/bindings/mfd/maxim,max77759.yaml.
> +
> +  The MAX77759 is a PMIC integrating, amongst others, a GPIO controller
> +  including interrupt support for 2 GPIO lines.
> +
> +properties:
> +  compatible:
> +    const: maxim,max77759-gpio
> +
> +  "#interrupt-cells":
> +    const: 2
> +
> +  interrupt-controller: true
> +
> +  interrupts:
> +    maxItems: 2

You need to define what each interrupt is.

> +
> +  "#gpio-cells":
> +    const: 2
> +
> +  gpio-controller: true
> +
> +  gpio-line-names:
> +    minItems: 1
> +    maxItems: 2
> +
> +required:
> +  - compatible
> +  - "#gpio-cells"
> +  - gpio-controller
> +  - "#interrupt-cells"
> +  - interrupt-controller
> +
> +additionalProperties: false
> 
> -- 
> 2.48.1.658.g4767266eb4-goog
>