[PATCH] pinctrl-mcp23s08: Reset all pins to input at probe

[PATCH] pinctrl-mcp23s08: Reset all pins to input at probe

[Mike Looijmans]

At startup, the driver just assumes that all registers have their
default values. But after a soft reset, the chip will just be in the
state it was, and some pins may have been configured as outputs. Any
modification of the output register will cause these pins to be driven
low, which leads to unexpected/unwanted effects. To prevent this from
happening, set the chip's IO configuration register to a known safe
mode (all inputs) before toggling any other bits.

Signed-off-by: Mike Looijmans <mike.looijmans@topic.nl>
---

 drivers/pinctrl/pinctrl-mcp23s08.c | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/drivers/pinctrl/pinctrl-mcp23s08.c b/drivers/pinctrl/pinctrl-mcp23s08.c
index b96e6368a956..de2147cfe83f 100644
--- a/drivers/pinctrl/pinctrl-mcp23s08.c
+++ b/drivers/pinctrl/pinctrl-mcp23s08.c
@@ -619,6 +619,14 @@ int mcp23s08_probe_one(struct mcp23s08 *mcp, struct device *dev,
 
 	mcp->reset_gpio = devm_gpiod_get_optional(dev, "reset", GPIOD_OUT_LOW);
 
+	/*
+	 * Reset the chip - we don't really know what state it's in, so reset
+	 * all pins to input first to prevent surprises.
+	 */
+	ret = mcp_write(mcp, MCP_IODIR, mcp->chip.ngpio == 16 ? 0xFFFF : 0xFF);
+	if (ret < 0)
+		return ret;
+
 	/* verify MCP_IOCON.SEQOP = 0, so sequential reads work,
 	 * and MCP_IOCON.HAEN = 1, so we work with all chips.
 	 */
-- 
2.43.0


Met vriendelijke groet / kind regards,

Mike Looijmans
System Expert


TOPIC Embedded Products B.V.
Materiaalweg 4, 5681 RJ Best
The Netherlands

T: +31 (0) 499 33 69 69
E: mike.looijmans@topic.nl
W: www.topic.nl

Please consider the environment before printing this e-mail

Re: [PATCH] pinctrl-mcp23s08: Reset all pins to input at probe

[Linus Walleij]

On Fri, Mar 14, 2025 at 4:18 PM Mike Looijmans <mike.looijmans@topic.nl> wrote:


> At startup, the driver just assumes that all registers have their
> default values. But after a soft reset, the chip will just be in the
> state it was, and some pins may have been configured as outputs. Any
> modification of the output register will cause these pins to be driven
> low, which leads to unexpected/unwanted effects. To prevent this from
> happening, set the chip's IO configuration register to a known safe
> mode (all inputs) before toggling any other bits.
>
> Signed-off-by: Mike Looijmans <mike.looijmans@topic.nl>

Patch tentatively applied for v6.16.

CC to some mcp23s08 users so they can check it out.

Yours,
Linus Walleij