linux-gpio.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Bartosz Golaszewski <brgl@bgdev.pl>
To: Linus Walleij <linus.walleij@linaro.org>,
	 Bartosz Golaszewski <brgl@bgdev.pl>
Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
	 Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
Subject: [PATCH 3/6] gpio: TODO: remove the pinctrl integration task
Date: Fri, 21 Mar 2025 16:49:35 +0100	[thread overview]
Message-ID: <20250321-gpio-todo-updates-v1-3-7b38f07110ee@linaro.org> (raw)
In-Reply-To: <20250321-gpio-todo-updates-v1-0-7b38f07110ee@linaro.org>

From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>

While there are surely some arguments in favor of integrating the GPIO
and pinctrl subsystems into one, I believe this is not the right
approach.

The GPIO subsystem uses intricate locking with SRCU to handle the fact
that both consumers and providers may run in different contexts.
Pin-controller drivers are always meant to run in process context. This
alone is a huge obstacle to any attempt at integration as evident by
many problems we already encountered during the hotplug rework.

The current glue code is pretty minimal and for most part already allows
GPIO controllers to query pinctrl about the information they need.

I suggest to drop this task and keep the subsystems separate even if
many pin-controllers implement GPIO functionality in addition to pin
functions.

Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
---
 drivers/gpio/TODO | 11 -----------
 1 file changed, 11 deletions(-)

diff --git a/drivers/gpio/TODO b/drivers/gpio/TODO
index ff955befd0ccf..08ff60c65abbb 100644
--- a/drivers/gpio/TODO
+++ b/drivers/gpio/TODO
@@ -136,17 +136,6 @@ try to cover any generic kind of irqchip cascaded from a GPIO.
   dry-code conversions to gpiolib irqchip for maintainers to test
 
 
-Increase integration with pin control
-
-There are already ways to use pin control as back-end for GPIO and
-it may make sense to bring these subsystems closer. One reason for
-creating pin control as its own subsystem was that we could avoid any
-use of the global GPIO numbers. Once the above is complete, it may
-make sense to simply join the subsystems into one and make pin
-multiplexing, pin configuration, GPIO, etc selectable options in one
-and the same pin control and GPIO subsystem.
-
-
 Moving over to immutable irq_chip structures
 
 Most of the gpio chips implementing interrupt support rely on gpiolib

-- 
2.45.2


  parent reply	other threads:[~2025-03-21 15:49 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-21 15:49 [PATCH 0/6] gpio: update the TODO list Bartosz Golaszewski
2025-03-21 15:49 ` [PATCH 1/6] gpio: TODO: remove the item about the new debugfs interface Bartosz Golaszewski
2025-03-22 20:26   ` Linus Walleij
2025-03-21 15:49 ` [PATCH 2/6] gpio: TODO: remove task duplication Bartosz Golaszewski
2025-03-22 20:27   ` Linus Walleij
2025-03-21 15:49 ` Bartosz Golaszewski [this message]
2025-03-22 20:28   ` [PATCH 3/6] gpio: TODO: remove the pinctrl integration task Linus Walleij
2025-03-21 15:49 ` [PATCH 4/6] gpio: TODO: add delimiters between tasks for better readability Bartosz Golaszewski
2025-03-22 20:28   ` Linus Walleij
2025-03-21 15:49 ` [PATCH 5/6] gpio: TODO: add an item to track the conversion to the new value setters Bartosz Golaszewski
2025-03-22 20:30   ` Linus Walleij
2025-03-21 15:49 ` [PATCH 6/6] gpio: TODO: add an item to track reworking the sysfs interface Bartosz Golaszewski
2025-03-22 20:31   ` Linus Walleij
2025-03-24  9:35 ` [PATCH 0/6] gpio: update the TODO list Bartosz Golaszewski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250321-gpio-todo-updates-v1-3-7b38f07110ee@linaro.org \
    --to=brgl@bgdev.pl \
    --cc=bartosz.golaszewski@linaro.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).