From: Greg KH <gregkh@linuxfoundation.org>
To: Raag Jadav <raag.jadav@intel.com>
Cc: Lee Jones <lee@kernel.org>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
giometti@enneenne.com, raymond.tan@intel.com,
linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 1/5] mfd: intel_ehl_pse_gpio: Introduce Intel Elkhart Lake PSE GPIO and TIO
Date: Fri, 21 Mar 2025 06:04:38 -0700 [thread overview]
Message-ID: <2025032115-gloomily-cubbyhole-dd8e@gregkh> (raw)
In-Reply-To: <Z9z49lfWV6LjUnaI@black.fi.intel.com>
On Fri, Mar 21, 2025 at 07:28:22AM +0200, Raag Jadav wrote:
> On Fri, Mar 14, 2025 at 01:57:35PM +0000, Lee Jones wrote:
> > On Fri, 14 Mar 2025, Andy Shevchenko wrote:
> > > On Fri, Mar 14, 2025 at 12:44:50PM +0000, Lee Jones wrote:
> > > > On Fri, 07 Mar 2025, Raag Jadav wrote:
>
> ...
>
> > > > > +static void ehl_pse_gpio_remove(struct pci_dev *pdev)
> > > > > +{
> > > > > + mfd_remove_devices(&pdev->dev);
> > > > > + pci_free_irq_vectors(pdev);
> > > > > +}
> > >
> > > Same here.
> >
> > Also, Greg has been quite vocal about converting PCI devices to Platform
> > ones in the past. We may wish to run this past him before continuing.
>
> Greg, any objections on moving forward with platform device?
I have no context here at all, why would a PCI device EVER be a platform
device? That feels wrong on so many levels...
next prev parent reply other threads:[~2025-03-21 13:05 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-07 5:22 [PATCH v3 0/5] Introduce Intel Elkhart Lake PSE TIO Raag Jadav
2025-03-07 5:22 ` [PATCH v3 1/5] mfd: intel_ehl_pse_gpio: Introduce Intel Elkhart Lake PSE GPIO and TIO Raag Jadav
2025-03-14 12:44 ` Lee Jones
2025-03-14 13:39 ` Andy Shevchenko
2025-03-14 13:57 ` Lee Jones
2025-03-14 14:20 ` Andy Shevchenko
2025-03-14 18:01 ` Raag Jadav
2025-03-21 5:28 ` Raag Jadav
2025-03-21 13:04 ` Greg KH [this message]
2025-03-21 13:22 ` Andy Shevchenko
2025-03-26 0:45 ` Greg KH
2025-03-26 9:01 ` Andy Shevchenko
2025-03-26 13:50 ` Greg KH
2025-03-07 5:22 ` [PATCH v3 2/5] gpio: elkhartlake: depend on MFD_INTEL_EHL_PSE_GPIO Raag Jadav
2025-03-11 6:37 ` Raag Jadav
2025-03-12 11:00 ` Andy Shevchenko
2025-03-12 17:03 ` Raag Jadav
2025-03-12 18:32 ` Andy Shevchenko
2025-03-13 9:19 ` Raag Jadav
2025-03-13 14:00 ` Andy Shevchenko
2025-03-13 14:24 ` Raag Jadav
2025-03-07 5:22 ` [PATCH v3 3/5] pps: generators: tio: split pps_gen_tio.h Raag Jadav
2025-03-07 5:22 ` [PATCH v3 4/5] pps: generators: tio: move to match_data() model Raag Jadav
2025-03-07 5:22 ` [PATCH v3 5/5] pps: generators: tio: Introduce Intel Elkhart Lake PSE TIO Raag Jadav
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2025032115-gloomily-cubbyhole-dd8e@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=giometti@enneenne.com \
--cc=lee@kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=raag.jadav@intel.com \
--cc=raymond.tan@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).