* [PATCH 1/2] dt-bindings: pinctrl: mediatek: Drop unrelated nodes from DTS example
@ 2025-03-24 12:51 Krzysztof Kozlowski
2025-03-24 12:51 ` [PATCH 2/2] dt-bindings: pinctrl: mediatek: Correct indentation and style in " Krzysztof Kozlowski
` (3 more replies)
0 siblings, 4 replies; 7+ messages in thread
From: Krzysztof Kozlowski @ 2025-03-24 12:51 UTC (permalink / raw)
To: Sean Wang, Linus Walleij, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Matthias Brugger, AngeloGioacchino Del Regno,
Andy Teng, linux-mediatek, linux-gpio, devicetree, linux-kernel,
linux-arm-kernel
Cc: Krzysztof Kozlowski
Binding example should not contain other nodes, e.g. consumers of
pinctrl of, because this is completely redundant and adds unnecessary
bloat.
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
.../bindings/pinctrl/mediatek,mt65xx-pinctrl.yaml | 10 ----------
.../bindings/pinctrl/mediatek,mt6779-pinctrl.yaml | 5 -----
2 files changed, 15 deletions(-)
diff --git a/Documentation/devicetree/bindings/pinctrl/mediatek,mt65xx-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/mediatek,mt65xx-pinctrl.yaml
index bccff08a5ba3..5f2808212f39 100644
--- a/Documentation/devicetree/bindings/pinctrl/mediatek,mt65xx-pinctrl.yaml
+++ b/Documentation/devicetree/bindings/pinctrl/mediatek,mt65xx-pinctrl.yaml
@@ -136,16 +136,6 @@ examples:
#address-cells = <2>;
#size-cells = <2>;
- syscfg_pctl_a: syscfg-pctl-a@10005000 {
- compatible = "mediatek,mt8135-pctl-a-syscfg", "syscon";
- reg = <0 0x10005000 0 0x1000>;
- };
-
- syscfg_pctl_b: syscfg-pctl-b@1020c020 {
- compatible = "mediatek,mt8135-pctl-b-syscfg", "syscon";
- reg = <0 0x1020C020 0 0x1000>;
- };
-
pinctrl@1c20800 {
compatible = "mediatek,mt8135-pinctrl";
reg = <0 0x1000B000 0 0x1000>;
diff --git a/Documentation/devicetree/bindings/pinctrl/mediatek,mt6779-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/mediatek,mt6779-pinctrl.yaml
index 3bbc00df5548..f4bab7a132d3 100644
--- a/Documentation/devicetree/bindings/pinctrl/mediatek,mt6779-pinctrl.yaml
+++ b/Documentation/devicetree/bindings/pinctrl/mediatek,mt6779-pinctrl.yaml
@@ -245,9 +245,4 @@ examples:
};
};
};
-
- mmc0 {
- pinctrl-0 = <&mmc0_pins_default>;
- pinctrl-names = "default";
- };
};
--
2.43.0
^ permalink raw reply related [flat|nested] 7+ messages in thread* [PATCH 2/2] dt-bindings: pinctrl: mediatek: Correct indentation and style in DTS example 2025-03-24 12:51 [PATCH 1/2] dt-bindings: pinctrl: mediatek: Drop unrelated nodes from DTS example Krzysztof Kozlowski @ 2025-03-24 12:51 ` Krzysztof Kozlowski 2025-03-24 20:23 ` Rob Herring 2025-04-10 7:41 ` AngeloGioacchino Del Regno 2025-03-24 20:18 ` [PATCH 1/2] dt-bindings: pinctrl: mediatek: Drop unrelated nodes from " Rob Herring (Arm) ` (2 subsequent siblings) 3 siblings, 2 replies; 7+ messages in thread From: Krzysztof Kozlowski @ 2025-03-24 12:51 UTC (permalink / raw) To: Sean Wang, Linus Walleij, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Matthias Brugger, AngeloGioacchino Del Regno, Andy Teng, linux-mediatek, linux-gpio, devicetree, linux-kernel, linux-arm-kernel Cc: Krzysztof Kozlowski DTS example in the bindings should be indented with 2- or 4-spaces and aligned with opening '- |', so correct any differences like 3-spaces or mixtures 2- and 4-spaces in one binding. No functional changes here, but saves some comments during reviews of new patches built on existing code. Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> --- .../pinctrl/mediatek,mt65xx-pinctrl.yaml | 83 +++++++------------ .../pinctrl/mediatek,mt7622-pinctrl.yaml | 48 +++++------ .../pinctrl/mediatek,mt8183-pinctrl.yaml | 68 +++++++-------- .../pinctrl/mediatek,mt8192-pinctrl.yaml | 76 ++++++++--------- 4 files changed, 127 insertions(+), 148 deletions(-) diff --git a/Documentation/devicetree/bindings/pinctrl/mediatek,mt65xx-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/mediatek,mt65xx-pinctrl.yaml index 5f2808212f39..b9680b896f12 100644 --- a/Documentation/devicetree/bindings/pinctrl/mediatek,mt65xx-pinctrl.yaml +++ b/Documentation/devicetree/bindings/pinctrl/mediatek,mt65xx-pinctrl.yaml @@ -137,64 +137,43 @@ examples: #size-cells = <2>; pinctrl@1c20800 { - compatible = "mediatek,mt8135-pinctrl"; - reg = <0 0x1000B000 0 0x1000>; - mediatek,pctl-regmap = <&syscfg_pctl_a>, <&syscfg_pctl_b>; - gpio-controller; - #gpio-cells = <2>; - interrupt-controller; - #interrupt-cells = <2>; - interrupts = <GIC_SPI 116 IRQ_TYPE_LEVEL_HIGH>, - <GIC_SPI 117 IRQ_TYPE_LEVEL_HIGH>, - <GIC_SPI 118 IRQ_TYPE_LEVEL_HIGH>; + compatible = "mediatek,mt8135-pinctrl"; + reg = <0 0x1000B000 0 0x1000>; + mediatek,pctl-regmap = <&syscfg_pctl_a>, <&syscfg_pctl_b>; + gpio-controller; + #gpio-cells = <2>; + interrupt-controller; + #interrupt-cells = <2>; + interrupts = <GIC_SPI 116 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 117 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 118 IRQ_TYPE_LEVEL_HIGH>; - i2c0_pins_a: i2c0-pins { - pins1 { - pinmux = <MT8135_PIN_100_SDA0__FUNC_SDA0>, - <MT8135_PIN_101_SCL0__FUNC_SCL0>; - bias-disable; - }; - }; - - i2c1_pins_a: i2c1-pins { - pins { - pinmux = <MT8135_PIN_195_SDA1__FUNC_SDA1>, - <MT8135_PIN_196_SCL1__FUNC_SCL1>; - bias-pull-up = <MTK_PUPD_SET_R1R0_01>; - }; - }; - - i2c2_pins_a: i2c2-pins { - pins1 { - pinmux = <MT8135_PIN_193_SDA2__FUNC_SDA2>; - bias-pull-down; + i2c0_pins_a: i2c0-pins { + pins1 { + pinmux = <MT8135_PIN_100_SDA0__FUNC_SDA0>, + <MT8135_PIN_101_SCL0__FUNC_SCL0>; + bias-disable; + }; }; - pins2 { - pinmux = <MT8135_PIN_49_WATCHDOG__FUNC_GPIO49>; - bias-pull-up; - }; - }; - - i2c3_pins_a: i2c3-pins { - pins1 { - pinmux = <MT8135_PIN_40_DAC_CLK__FUNC_GPIO40>, - <MT8135_PIN_41_DAC_WS__FUNC_GPIO41>; - bias-pull-up = <MTK_PUPD_SET_R1R0_01>; + i2c1_pins_a: i2c1-pins { + pins { + pinmux = <MT8135_PIN_195_SDA1__FUNC_SDA1>, + <MT8135_PIN_196_SCL1__FUNC_SCL1>; + bias-pull-up = <MTK_PUPD_SET_R1R0_01>; + }; }; - pins2 { - pinmux = <MT8135_PIN_35_SCL3__FUNC_SCL3>, - <MT8135_PIN_36_SDA3__FUNC_SDA3>; - output-low; - bias-pull-up = <MTK_PUPD_SET_R1R0_01>; - }; + i2c2_pins_a: i2c2-pins { + pins1 { + pinmux = <MT8135_PIN_193_SDA2__FUNC_SDA2>; + bias-pull-down; + }; - pins3 { - pinmux = <MT8135_PIN_57_JTCK__FUNC_GPIO57>, - <MT8135_PIN_60_JTDI__FUNC_JTDI>; - drive-strength = <32>; + pins2 { + pinmux = <MT8135_PIN_49_WATCHDOG__FUNC_GPIO49>; + bias-pull-up; + }; }; - }; }; }; diff --git a/Documentation/devicetree/bindings/pinctrl/mediatek,mt7622-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/mediatek,mt7622-pinctrl.yaml index d74cae9d4d65..9acca85184fa 100644 --- a/Documentation/devicetree/bindings/pinctrl/mediatek,mt7622-pinctrl.yaml +++ b/Documentation/devicetree/bindings/pinctrl/mediatek,mt7622-pinctrl.yaml @@ -366,34 +366,34 @@ examples: #size-cells = <2>; pio: pinctrl@10211000 { - compatible = "mediatek,mt7622-pinctrl"; - reg = <0 0x10211000 0 0x1000>; - gpio-controller; - #gpio-cells = <2>; + compatible = "mediatek,mt7622-pinctrl"; + reg = <0 0x10211000 0 0x1000>; + gpio-controller; + #gpio-cells = <2>; - pinctrl_eth_default: eth-pins { - mux-mdio { - groups = "mdc_mdio"; - function = "eth"; - drive-strength = <12>; - }; + pinctrl_eth_default: eth-pins { + mux-mdio { + groups = "mdc_mdio"; + function = "eth"; + drive-strength = <12>; + }; - mux-gmac2 { - groups = "rgmii_via_gmac2"; - function = "eth"; - drive-strength = <12>; - }; + mux-gmac2 { + groups = "rgmii_via_gmac2"; + function = "eth"; + drive-strength = <12>; + }; - mux-esw { - groups = "esw"; - function = "eth"; - drive-strength = <8>; - }; + mux-esw { + groups = "esw"; + function = "eth"; + drive-strength = <8>; + }; - conf-mdio { - pins = "MDC"; - bias-pull-up; + conf-mdio { + pins = "MDC"; + bias-pull-up; + }; }; - }; }; }; diff --git a/Documentation/devicetree/bindings/pinctrl/mediatek,mt8183-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/mediatek,mt8183-pinctrl.yaml index 8507bd15f243..464879274cae 100644 --- a/Documentation/devicetree/bindings/pinctrl/mediatek,mt8183-pinctrl.yaml +++ b/Documentation/devicetree/bindings/pinctrl/mediatek,mt8183-pinctrl.yaml @@ -195,43 +195,43 @@ examples: #size-cells = <2>; pio: pinctrl@10005000 { - compatible = "mediatek,mt8183-pinctrl"; - reg = <0 0x10005000 0 0x1000>, - <0 0x11f20000 0 0x1000>, - <0 0x11e80000 0 0x1000>, - <0 0x11e70000 0 0x1000>, - <0 0x11e90000 0 0x1000>, - <0 0x11d30000 0 0x1000>, - <0 0x11d20000 0 0x1000>, - <0 0x11c50000 0 0x1000>, - <0 0x11f30000 0 0x1000>, - <0 0x1000b000 0 0x1000>; - reg-names = "iocfg0", "iocfg1", "iocfg2", - "iocfg3", "iocfg4", "iocfg5", - "iocfg6", "iocfg7", "iocfg8", - "eint"; - gpio-controller; - #gpio-cells = <2>; - gpio-ranges = <&pio 0 0 192>; - interrupt-controller; - interrupts = <GIC_SPI 177 IRQ_TYPE_LEVEL_HIGH>; - #interrupt-cells = <2>; + compatible = "mediatek,mt8183-pinctrl"; + reg = <0 0x10005000 0 0x1000>, + <0 0x11f20000 0 0x1000>, + <0 0x11e80000 0 0x1000>, + <0 0x11e70000 0 0x1000>, + <0 0x11e90000 0 0x1000>, + <0 0x11d30000 0 0x1000>, + <0 0x11d20000 0 0x1000>, + <0 0x11c50000 0 0x1000>, + <0 0x11f30000 0 0x1000>, + <0 0x1000b000 0 0x1000>; + reg-names = "iocfg0", "iocfg1", "iocfg2", + "iocfg3", "iocfg4", "iocfg5", + "iocfg6", "iocfg7", "iocfg8", + "eint"; + gpio-controller; + #gpio-cells = <2>; + gpio-ranges = <&pio 0 0 192>; + interrupt-controller; + interrupts = <GIC_SPI 177 IRQ_TYPE_LEVEL_HIGH>; + #interrupt-cells = <2>; - i2c0_pins_a: i2c0-pins { - pins1 { - pinmux = <PINMUX_GPIO48__FUNC_SCL5>, - <PINMUX_GPIO49__FUNC_SDA5>; - mediatek,pull-up-adv = <3>; - drive-strength-microamp = <1000>; + i2c0_pins_a: i2c0-pins { + pins1 { + pinmux = <PINMUX_GPIO48__FUNC_SCL5>, + <PINMUX_GPIO49__FUNC_SDA5>; + mediatek,pull-up-adv = <3>; + drive-strength-microamp = <1000>; + }; }; - }; - i2c1_pins_a: i2c1-pins { - pins { - pinmux = <PINMUX_GPIO50__FUNC_SCL3>, - <PINMUX_GPIO51__FUNC_SDA3>; - mediatek,pull-down-adv = <2>; + i2c1_pins_a: i2c1-pins { + pins { + pinmux = <PINMUX_GPIO50__FUNC_SCL3>, + <PINMUX_GPIO51__FUNC_SDA3>; + mediatek,pull-down-adv = <2>; + }; }; - }; }; }; diff --git a/Documentation/devicetree/bindings/pinctrl/mediatek,mt8192-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/mediatek,mt8192-pinctrl.yaml index 1686427eb854..949dcd6fd847 100644 --- a/Documentation/devicetree/bindings/pinctrl/mediatek,mt8192-pinctrl.yaml +++ b/Documentation/devicetree/bindings/pinctrl/mediatek,mt8192-pinctrl.yaml @@ -142,43 +142,43 @@ additionalProperties: false examples: - | - #include <dt-bindings/pinctrl/mt8192-pinfunc.h> - #include <dt-bindings/interrupt-controller/arm-gic.h> - pio: pinctrl@10005000 { - compatible = "mediatek,mt8192-pinctrl"; - reg = <0x10005000 0x1000>, - <0x11c20000 0x1000>, - <0x11d10000 0x1000>, - <0x11d30000 0x1000>, - <0x11d40000 0x1000>, - <0x11e20000 0x1000>, - <0x11e70000 0x1000>, - <0x11ea0000 0x1000>, - <0x11f20000 0x1000>, - <0x11f30000 0x1000>, - <0x1000b000 0x1000>; - reg-names = "iocfg0", "iocfg_rm", "iocfg_bm", - "iocfg_bl", "iocfg_br", "iocfg_lm", - "iocfg_lb", "iocfg_rt", "iocfg_lt", - "iocfg_tl", "eint"; - gpio-controller; - #gpio-cells = <2>; - gpio-ranges = <&pio 0 0 220>; - interrupt-controller; - interrupts = <GIC_SPI 212 IRQ_TYPE_LEVEL_HIGH 0>; - #interrupt-cells = <2>; + #include <dt-bindings/pinctrl/mt8192-pinfunc.h> + #include <dt-bindings/interrupt-controller/arm-gic.h> + pio: pinctrl@10005000 { + compatible = "mediatek,mt8192-pinctrl"; + reg = <0x10005000 0x1000>, + <0x11c20000 0x1000>, + <0x11d10000 0x1000>, + <0x11d30000 0x1000>, + <0x11d40000 0x1000>, + <0x11e20000 0x1000>, + <0x11e70000 0x1000>, + <0x11ea0000 0x1000>, + <0x11f20000 0x1000>, + <0x11f30000 0x1000>, + <0x1000b000 0x1000>; + reg-names = "iocfg0", "iocfg_rm", "iocfg_bm", + "iocfg_bl", "iocfg_br", "iocfg_lm", + "iocfg_lb", "iocfg_rt", "iocfg_lt", + "iocfg_tl", "eint"; + gpio-controller; + #gpio-cells = <2>; + gpio-ranges = <&pio 0 0 220>; + interrupt-controller; + interrupts = <GIC_SPI 212 IRQ_TYPE_LEVEL_HIGH 0>; + #interrupt-cells = <2>; - spi1-default-pins { - pins-cs-mosi-clk { - pinmux = <PINMUX_GPIO157__FUNC_SPI1_A_CSB>, - <PINMUX_GPIO159__FUNC_SPI1_A_MO>, - <PINMUX_GPIO156__FUNC_SPI1_A_CLK>; - bias-disable; - }; - - pins-miso { - pinmux = <PINMUX_GPIO158__FUNC_SPI1_A_MI>; - bias-pull-down; - }; - }; + spi1-default-pins { + pins-cs-mosi-clk { + pinmux = <PINMUX_GPIO157__FUNC_SPI1_A_CSB>, + <PINMUX_GPIO159__FUNC_SPI1_A_MO>, + <PINMUX_GPIO156__FUNC_SPI1_A_CLK>; + bias-disable; }; + + pins-miso { + pinmux = <PINMUX_GPIO158__FUNC_SPI1_A_MI>; + bias-pull-down; + }; + }; + }; -- 2.43.0 ^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH 2/2] dt-bindings: pinctrl: mediatek: Correct indentation and style in DTS example 2025-03-24 12:51 ` [PATCH 2/2] dt-bindings: pinctrl: mediatek: Correct indentation and style in " Krzysztof Kozlowski @ 2025-03-24 20:23 ` Rob Herring 2025-04-10 7:41 ` AngeloGioacchino Del Regno 1 sibling, 0 replies; 7+ messages in thread From: Rob Herring @ 2025-03-24 20:23 UTC (permalink / raw) To: Krzysztof Kozlowski Cc: Sean Wang, Linus Walleij, Krzysztof Kozlowski, Conor Dooley, Matthias Brugger, AngeloGioacchino Del Regno, Andy Teng, linux-mediatek, linux-gpio, devicetree, linux-kernel, linux-arm-kernel On Mon, Mar 24, 2025 at 01:51:05PM +0100, Krzysztof Kozlowski wrote: > DTS example in the bindings should be indented with 2- or 4-spaces and > aligned with opening '- |', so correct any differences like 3-spaces or > mixtures 2- and 4-spaces in one binding. > > No functional changes here, but saves some comments during reviews of > new patches built on existing code. > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > --- > .../pinctrl/mediatek,mt65xx-pinctrl.yaml | 83 +++++++------------ > .../pinctrl/mediatek,mt7622-pinctrl.yaml | 48 +++++------ > .../pinctrl/mediatek,mt8183-pinctrl.yaml | 68 +++++++-------- > .../pinctrl/mediatek,mt8192-pinctrl.yaml | 76 ++++++++--------- > 4 files changed, 127 insertions(+), 148 deletions(-) > > diff --git a/Documentation/devicetree/bindings/pinctrl/mediatek,mt65xx-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/mediatek,mt65xx-pinctrl.yaml > index 5f2808212f39..b9680b896f12 100644 > --- a/Documentation/devicetree/bindings/pinctrl/mediatek,mt65xx-pinctrl.yaml > +++ b/Documentation/devicetree/bindings/pinctrl/mediatek,mt65xx-pinctrl.yaml > @@ -137,64 +137,43 @@ examples: > #size-cells = <2>; > > pinctrl@1c20800 { > - compatible = "mediatek,mt8135-pinctrl"; > - reg = <0 0x1000B000 0 0x1000>; > - mediatek,pctl-regmap = <&syscfg_pctl_a>, <&syscfg_pctl_b>; > - gpio-controller; > - #gpio-cells = <2>; > - interrupt-controller; > - #interrupt-cells = <2>; > - interrupts = <GIC_SPI 116 IRQ_TYPE_LEVEL_HIGH>, > - <GIC_SPI 117 IRQ_TYPE_LEVEL_HIGH>, > - <GIC_SPI 118 IRQ_TYPE_LEVEL_HIGH>; > + compatible = "mediatek,mt8135-pinctrl"; > + reg = <0 0x1000B000 0 0x1000>; > + mediatek,pctl-regmap = <&syscfg_pctl_a>, <&syscfg_pctl_b>; > + gpio-controller; > + #gpio-cells = <2>; > + interrupt-controller; > + #interrupt-cells = <2>; > + interrupts = <GIC_SPI 116 IRQ_TYPE_LEVEL_HIGH>, > + <GIC_SPI 117 IRQ_TYPE_LEVEL_HIGH>, > + <GIC_SPI 118 IRQ_TYPE_LEVEL_HIGH>; > > - i2c0_pins_a: i2c0-pins { > - pins1 { > - pinmux = <MT8135_PIN_100_SDA0__FUNC_SDA0>, > - <MT8135_PIN_101_SCL0__FUNC_SCL0>; > - bias-disable; > - }; > - }; > - > - i2c1_pins_a: i2c1-pins { > - pins { > - pinmux = <MT8135_PIN_195_SDA1__FUNC_SDA1>, > - <MT8135_PIN_196_SCL1__FUNC_SCL1>; > - bias-pull-up = <MTK_PUPD_SET_R1R0_01>; > - }; > - }; > - > - i2c2_pins_a: i2c2-pins { > - pins1 { > - pinmux = <MT8135_PIN_193_SDA2__FUNC_SDA2>; > - bias-pull-down; > + i2c0_pins_a: i2c0-pins { Perhaps drop the unused labels while you are here. Either way, Reviewed-by: Rob Herring (Arm) <robh@kernel.org> ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 2/2] dt-bindings: pinctrl: mediatek: Correct indentation and style in DTS example 2025-03-24 12:51 ` [PATCH 2/2] dt-bindings: pinctrl: mediatek: Correct indentation and style in " Krzysztof Kozlowski 2025-03-24 20:23 ` Rob Herring @ 2025-04-10 7:41 ` AngeloGioacchino Del Regno 1 sibling, 0 replies; 7+ messages in thread From: AngeloGioacchino Del Regno @ 2025-04-10 7:41 UTC (permalink / raw) To: Krzysztof Kozlowski, Sean Wang, Linus Walleij, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Matthias Brugger, Andy Teng, linux-mediatek, linux-gpio, devicetree, linux-kernel, linux-arm-kernel Il 24/03/25 13:51, Krzysztof Kozlowski ha scritto: > DTS example in the bindings should be indented with 2- or 4-spaces and > aligned with opening '- |', so correct any differences like 3-spaces or > mixtures 2- and 4-spaces in one binding. > > No functional changes here, but saves some comments during reviews of > new patches built on existing code. > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > --- > .../pinctrl/mediatek,mt65xx-pinctrl.yaml | 83 +++++++------------ > .../pinctrl/mediatek,mt7622-pinctrl.yaml | 48 +++++------ > .../pinctrl/mediatek,mt8183-pinctrl.yaml | 68 +++++++-------- > .../pinctrl/mediatek,mt8192-pinctrl.yaml | 76 ++++++++--------- > 4 files changed, 127 insertions(+), 148 deletions(-) > > diff --git a/Documentation/devicetree/bindings/pinctrl/mediatek,mt65xx-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/mediatek,mt65xx-pinctrl.yaml > index 5f2808212f39..b9680b896f12 100644 > --- a/Documentation/devicetree/bindings/pinctrl/mediatek,mt65xx-pinctrl.yaml > +++ b/Documentation/devicetree/bindings/pinctrl/mediatek,mt65xx-pinctrl.yaml > @@ -137,64 +137,43 @@ examples: > #size-cells = <2>; > > pinctrl@1c20800 { > - compatible = "mediatek,mt8135-pinctrl"; > - reg = <0 0x1000B000 0 0x1000>; > - mediatek,pctl-regmap = <&syscfg_pctl_a>, <&syscfg_pctl_b>; > - gpio-controller; > - #gpio-cells = <2>; > - interrupt-controller; > - #interrupt-cells = <2>; > - interrupts = <GIC_SPI 116 IRQ_TYPE_LEVEL_HIGH>, > - <GIC_SPI 117 IRQ_TYPE_LEVEL_HIGH>, > - <GIC_SPI 118 IRQ_TYPE_LEVEL_HIGH>; > + compatible = "mediatek,mt8135-pinctrl"; > + reg = <0 0x1000B000 0 0x1000>; > + mediatek,pctl-regmap = <&syscfg_pctl_a>, <&syscfg_pctl_b>; > + gpio-controller; > + #gpio-cells = <2>; > + interrupt-controller; > + #interrupt-cells = <2>; > + interrupts = <GIC_SPI 116 IRQ_TYPE_LEVEL_HIGH>, > + <GIC_SPI 117 IRQ_TYPE_LEVEL_HIGH>, > + <GIC_SPI 118 IRQ_TYPE_LEVEL_HIGH>; > > - i2c0_pins_a: i2c0-pins { > - pins1 { > - pinmux = <MT8135_PIN_100_SDA0__FUNC_SDA0>, > - <MT8135_PIN_101_SCL0__FUNC_SCL0>; > - bias-disable; > - }; > - }; > - > - i2c1_pins_a: i2c1-pins { > - pins { > - pinmux = <MT8135_PIN_195_SDA1__FUNC_SDA1>, > - <MT8135_PIN_196_SCL1__FUNC_SCL1>; > - bias-pull-up = <MTK_PUPD_SET_R1R0_01>; > - }; > - }; > - > - i2c2_pins_a: i2c2-pins { > - pins1 { > - pinmux = <MT8135_PIN_193_SDA2__FUNC_SDA2>; > - bias-pull-down; > + i2c0_pins_a: i2c0-pins { Agreeing with Rob - if you can please also remove the labels while at it, that'd be great, but regardless of that... Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 1/2] dt-bindings: pinctrl: mediatek: Drop unrelated nodes from DTS example 2025-03-24 12:51 [PATCH 1/2] dt-bindings: pinctrl: mediatek: Drop unrelated nodes from DTS example Krzysztof Kozlowski 2025-03-24 12:51 ` [PATCH 2/2] dt-bindings: pinctrl: mediatek: Correct indentation and style in " Krzysztof Kozlowski @ 2025-03-24 20:18 ` Rob Herring (Arm) 2025-04-10 7:41 ` AngeloGioacchino Del Regno 2025-04-15 22:10 ` Linus Walleij 3 siblings, 0 replies; 7+ messages in thread From: Rob Herring (Arm) @ 2025-03-24 20:18 UTC (permalink / raw) To: Krzysztof Kozlowski Cc: Krzysztof Kozlowski, Matthias Brugger, Andy Teng, linux-mediatek, Conor Dooley, devicetree, AngeloGioacchino Del Regno, linux-kernel, linux-gpio, linux-arm-kernel, Sean Wang, Linus Walleij On Mon, 24 Mar 2025 13:51:04 +0100, Krzysztof Kozlowski wrote: > Binding example should not contain other nodes, e.g. consumers of > pinctrl of, because this is completely redundant and adds unnecessary > bloat. > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > --- > .../bindings/pinctrl/mediatek,mt65xx-pinctrl.yaml | 10 ---------- > .../bindings/pinctrl/mediatek,mt6779-pinctrl.yaml | 5 ----- > 2 files changed, 15 deletions(-) > Acked-by: Rob Herring (Arm) <robh@kernel.org> ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 1/2] dt-bindings: pinctrl: mediatek: Drop unrelated nodes from DTS example 2025-03-24 12:51 [PATCH 1/2] dt-bindings: pinctrl: mediatek: Drop unrelated nodes from DTS example Krzysztof Kozlowski 2025-03-24 12:51 ` [PATCH 2/2] dt-bindings: pinctrl: mediatek: Correct indentation and style in " Krzysztof Kozlowski 2025-03-24 20:18 ` [PATCH 1/2] dt-bindings: pinctrl: mediatek: Drop unrelated nodes from " Rob Herring (Arm) @ 2025-04-10 7:41 ` AngeloGioacchino Del Regno 2025-04-15 22:10 ` Linus Walleij 3 siblings, 0 replies; 7+ messages in thread From: AngeloGioacchino Del Regno @ 2025-04-10 7:41 UTC (permalink / raw) To: Krzysztof Kozlowski, Sean Wang, Linus Walleij, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Matthias Brugger, Andy Teng, linux-mediatek, linux-gpio, devicetree, linux-kernel, linux-arm-kernel Il 24/03/25 13:51, Krzysztof Kozlowski ha scritto: > Binding example should not contain other nodes, e.g. consumers of > pinctrl of, because this is completely redundant and adds unnecessary > bloat. > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 1/2] dt-bindings: pinctrl: mediatek: Drop unrelated nodes from DTS example 2025-03-24 12:51 [PATCH 1/2] dt-bindings: pinctrl: mediatek: Drop unrelated nodes from DTS example Krzysztof Kozlowski ` (2 preceding siblings ...) 2025-04-10 7:41 ` AngeloGioacchino Del Regno @ 2025-04-15 22:10 ` Linus Walleij 3 siblings, 0 replies; 7+ messages in thread From: Linus Walleij @ 2025-04-15 22:10 UTC (permalink / raw) To: Krzysztof Kozlowski Cc: Sean Wang, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Matthias Brugger, AngeloGioacchino Del Regno, Andy Teng, linux-mediatek, linux-gpio, devicetree, linux-kernel, linux-arm-kernel On Mon, Mar 24, 2025 at 1:51 PM Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote: > Binding example should not contain other nodes, e.g. consumers of > pinctrl of, because this is completely redundant and adds unnecessary > bloat. > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Both patches applied, thanks! Yours, Linus Walleij ^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2025-04-15 22:10 UTC | newest] Thread overview: 7+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2025-03-24 12:51 [PATCH 1/2] dt-bindings: pinctrl: mediatek: Drop unrelated nodes from DTS example Krzysztof Kozlowski 2025-03-24 12:51 ` [PATCH 2/2] dt-bindings: pinctrl: mediatek: Correct indentation and style in " Krzysztof Kozlowski 2025-03-24 20:23 ` Rob Herring 2025-04-10 7:41 ` AngeloGioacchino Del Regno 2025-03-24 20:18 ` [PATCH 1/2] dt-bindings: pinctrl: mediatek: Drop unrelated nodes from " Rob Herring (Arm) 2025-04-10 7:41 ` AngeloGioacchino Del Regno 2025-04-15 22:10 ` Linus Walleij
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).