linux-gpio.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v1] dt-bindings: gpio: pca95xx: add Toradex Embedded Controller
@ 2025-03-28 12:29 Francesco Dolcini
  2025-03-31  7:03 ` Francesco Dolcini
  0 siblings, 1 reply; 2+ messages in thread
From: Francesco Dolcini @ 2025-03-28 12:29 UTC (permalink / raw)
  To: Linus Walleij, Bartosz Golaszewski, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley
  Cc: Emanuele Ghidoli, Krzysztof Kozlowski, linux-gpio, devicetree,
	linux-kernel, Francesco Dolcini

From: Emanuele Ghidoli <emanuele.ghidoli@toradex.com>

The Toradex Embedded Controller IO16 is a 16-bit I2C I/O expander
implemented using a small MCU.
Its register interface and behavior are compatible with the PCAL6416.

Signed-off-by: Emanuele Ghidoli <emanuele.ghidoli@toradex.com>
Signed-off-by: Francesco Dolcini <francesco.dolcini@toradex.com>
---
 Documentation/devicetree/bindings/gpio/gpio-pca95xx.yaml | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/Documentation/devicetree/bindings/gpio/gpio-pca95xx.yaml b/Documentation/devicetree/bindings/gpio/gpio-pca95xx.yaml
index 7b1eb08fa055..db1520ff38bd 100644
--- a/Documentation/devicetree/bindings/gpio/gpio-pca95xx.yaml
+++ b/Documentation/devicetree/bindings/gpio/gpio-pca95xx.yaml
@@ -16,6 +16,9 @@ description: |+
 properties:
   compatible:
     oneOf:
+      - items:
+          - const: toradex,embedded-controller-io16
+          - const: nxp,pcal6416
       - items:
           - const: diodes,pi4ioe5v6534q
           - const: nxp,pcal6534
@@ -132,6 +135,7 @@ allOf:
               - maxim,max7325
               - maxim,max7326
               - maxim,max7327
+              - toradex,embedded-controller-io16
     then:
       properties:
         reset-gpios: false
-- 
2.39.5


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH v1] dt-bindings: gpio: pca95xx: add Toradex Embedded Controller
  2025-03-28 12:29 [PATCH v1] dt-bindings: gpio: pca95xx: add Toradex Embedded Controller Francesco Dolcini
@ 2025-03-31  7:03 ` Francesco Dolcini
  0 siblings, 0 replies; 2+ messages in thread
From: Francesco Dolcini @ 2025-03-31  7:03 UTC (permalink / raw)
  To: Linus Walleij, Bartosz Golaszewski, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley
  Cc: Emanuele Ghidoli, linux-gpio, devicetree, linux-kernel,
	Francesco Dolcini

Hello,

On Fri, Mar 28, 2025 at 01:29:17PM +0100, Francesco Dolcini wrote:
> From: Emanuele Ghidoli <emanuele.ghidoli@toradex.com>
> 
> The Toradex Embedded Controller IO16 is a 16-bit I2C I/O expander
> implemented using a small MCU.
> Its register interface and behavior are compatible with the PCAL6416.
> 
> Signed-off-by: Emanuele Ghidoli <emanuele.ghidoli@toradex.com>
> Signed-off-by: Francesco Dolcini <francesco.dolcini@toradex.com>

Please ignore this patch, I'll send soon a v2.

The issue with this patch is that the compatible is too long, we are
going to re-use "embedded-controller" prefix for other devices and this
creates clashes with the i2c compatible match fallback function
(i2c_of_match_device_sysfs).

Francesco


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2025-03-31  7:03 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-03-28 12:29 [PATCH v1] dt-bindings: gpio: pca95xx: add Toradex Embedded Controller Francesco Dolcini
2025-03-31  7:03 ` Francesco Dolcini

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).