From: Bartosz Golaszewski <brgl@bgdev.pl>
To: Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>,
Linus Walleij <linus.walleij@linaro.org>,
Bartosz Golaszewski <brgl@bgdev.pl>
Cc: linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org,
Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
Subject: [PATCH 1/4] regulator: rpi-panel-attiny: don't double-check GPIO range
Date: Tue, 08 Apr 2025 09:36:28 +0200 [thread overview]
Message-ID: <20250408-gpiochip-set-rv-regulator-v1-1-a18b6154b31a@linaro.org> (raw)
In-Reply-To: <20250408-gpiochip-set-rv-regulator-v1-0-a18b6154b31a@linaro.org>
From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
GPIO core already checks GPIO ranges, there's no need to check it again
in the set() callback.
Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
---
drivers/regulator/rpi-panel-attiny-regulator.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/regulator/rpi-panel-attiny-regulator.c b/drivers/regulator/rpi-panel-attiny-regulator.c
index 6c3b6bfac961..f5ce50ced294 100644
--- a/drivers/regulator/rpi-panel-attiny-regulator.c
+++ b/drivers/regulator/rpi-panel-attiny-regulator.c
@@ -216,9 +216,6 @@ static void attiny_gpio_set(struct gpio_chip *gc, unsigned int off, int val)
struct attiny_lcd *state = gpiochip_get_data(gc);
u8 last_val;
- if (off >= NUM_GPIO)
- return;
-
mutex_lock(&state->lock);
last_val = attiny_get_port_state(state, mappings[off].reg);
--
2.45.2
next prev parent reply other threads:[~2025-04-08 7:36 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-08 7:36 [PATCH 0/4] regulator: rpi-panel-attiny: use new GPIO line value setter callbacks Bartosz Golaszewski
2025-04-08 7:36 ` Bartosz Golaszewski [this message]
2025-04-08 7:36 ` [PATCH 2/4] regulator: rpi-panel-attiny: use devres for mutex management Bartosz Golaszewski
2025-04-08 7:36 ` [PATCH 3/4] regulator: rpi-panel-attiny: use lock guards for the state mutex Bartosz Golaszewski
2025-04-08 7:36 ` [PATCH 4/4] regulator: rpi-panel-attiny: use new GPIO line value setter callbacks Bartosz Golaszewski
2025-04-08 16:31 ` [PATCH 0/4] " Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250408-gpiochip-set-rv-regulator-v1-1-a18b6154b31a@linaro.org \
--to=brgl@bgdev.pl \
--cc=bartosz.golaszewski@linaro.org \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).