From: Bartosz Golaszewski <brgl@bgdev.pl>
To: Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
Linus Walleij <linus.walleij@linaro.org>,
Bartosz Golaszewski <brgl@bgdev.pl>,
Peter Ujfalusi <peter.ujfalusi@gmail.com>,
Oder Chiou <oder_chiou@realtek.com>,
Shenghao Ding <shenghao-ding@ti.com>, Kevin Lu <kevin-lu@ti.com>,
Baojun Xu <baojun.xu@ti.com>,
Herve Codina <herve.codina@bootlin.com>,
David Rhodes <david.rhodes@cirrus.com>,
Richard Fitzgerald <rf@opensource.cirrus.com>
Cc: linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-gpio@vger.kernel.org, patches@opensource.cirrus.com,
Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
Subject: [PATCH 05/12] ASoC: codecs: rt5677: use new GPIO line value setter callbacks
Date: Tue, 08 Apr 2025 09:38:23 +0200 [thread overview]
Message-ID: <20250408-gpiochip-set-rv-sound-v1-5-dd54b6ca1ef9@linaro.org> (raw)
In-Reply-To: <20250408-gpiochip-set-rv-sound-v1-0-dd54b6ca1ef9@linaro.org>
From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
struct gpio_chip now has callbacks for setting line values that return
an integer, allowing to indicate failures. Convert the driver to using
them.
Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
---
sound/soc/codecs/rt5677.c | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/sound/soc/codecs/rt5677.c b/sound/soc/codecs/rt5677.c
index 6e4774148566..69a0fb8d7f77 100644
--- a/sound/soc/codecs/rt5677.c
+++ b/sound/soc/codecs/rt5677.c
@@ -4725,13 +4725,14 @@ static int rt5677_update_gpio_bits(struct rt5677_priv *rt5677, unsigned offset,
}
#ifdef CONFIG_GPIOLIB
-static void rt5677_gpio_set(struct gpio_chip *chip, unsigned offset, int value)
+static int rt5677_gpio_set(struct gpio_chip *chip, unsigned int offset,
+ int value)
{
struct rt5677_priv *rt5677 = gpiochip_get_data(chip);
int level = value ? RT5677_GPIOx_OUT_HI : RT5677_GPIOx_OUT_LO;
int m = RT5677_GPIOx_OUT_MASK;
- rt5677_update_gpio_bits(rt5677, offset, m, level);
+ return rt5677_update_gpio_bits(rt5677, offset, m, level);
}
static int rt5677_gpio_direction_out(struct gpio_chip *chip,
@@ -4834,7 +4835,7 @@ static const struct gpio_chip rt5677_template_chip = {
.label = RT5677_DRV_NAME,
.owner = THIS_MODULE,
.direction_output = rt5677_gpio_direction_out,
- .set = rt5677_gpio_set,
+ .set_rv = rt5677_gpio_set,
.direction_input = rt5677_gpio_direction_in,
.get = rt5677_gpio_get,
.to_irq = rt5677_to_irq,
--
2.45.2
next prev parent reply other threads:[~2025-04-08 7:38 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-08 7:38 [PATCH 00/12] ASoC: convert GPIO chips to using new value setters Bartosz Golaszewski
2025-04-08 7:38 ` [PATCH 01/12] ASoC: soc-ac97: use new GPIO line value setter callbacks Bartosz Golaszewski
2025-04-08 7:38 ` [PATCH 02/12] ASoC: ti: davinci-mcasp:: " Bartosz Golaszewski
2025-04-08 7:38 ` [PATCH 03/12] ASoC: codecs: wm8962: " Bartosz Golaszewski
2025-04-08 7:38 ` [PATCH 04/12] ASoC: codecs: wm5100: " Bartosz Golaszewski
2025-04-08 7:38 ` Bartosz Golaszewski [this message]
2025-04-08 7:38 ` [PATCH 06/12] ASoC: codecs: wm8996: " Bartosz Golaszewski
2025-04-08 7:38 ` [PATCH 07/12] ASoC: codecs: tlv320adc3xxx: " Bartosz Golaszewski
2025-04-08 7:38 ` [PATCH 08/12] ASoC: codecs: idt821034: " Bartosz Golaszewski
2025-04-08 8:16 ` Herve Codina
2025-04-08 7:38 ` [PATCH 09/12] ASoC: codecs: peb2466: " Bartosz Golaszewski
2025-04-08 8:18 ` Herve Codina
2025-04-08 7:38 ` [PATCH 10/12] ASoC: codecs: wm8903: " Bartosz Golaszewski
2025-04-08 7:38 ` [PATCH 11/12] ASoC: codecs: zl38060: " Bartosz Golaszewski
2025-04-08 7:38 ` [PATCH 12/12] ALSA: hda: cirrus_scodec_test: " Bartosz Golaszewski
2025-04-08 12:25 ` [PATCH 00/12] ASoC: convert GPIO chips to using new value setters Charles Keepax
2025-04-14 13:56 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250408-gpiochip-set-rv-sound-v1-5-dd54b6ca1ef9@linaro.org \
--to=brgl@bgdev.pl \
--cc=baojun.xu@ti.com \
--cc=bartosz.golaszewski@linaro.org \
--cc=broonie@kernel.org \
--cc=david.rhodes@cirrus.com \
--cc=herve.codina@bootlin.com \
--cc=kevin-lu@ti.com \
--cc=lgirdwood@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=oder_chiou@realtek.com \
--cc=patches@opensource.cirrus.com \
--cc=perex@perex.cz \
--cc=peter.ujfalusi@gmail.com \
--cc=rf@opensource.cirrus.com \
--cc=shenghao-ding@ti.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).