From: Bartosz Golaszewski <brgl@bgdev.pl>
To: Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
Linus Walleij <linus.walleij@linaro.org>,
Bartosz Golaszewski <brgl@bgdev.pl>,
Peter Ujfalusi <peter.ujfalusi@gmail.com>,
Oder Chiou <oder_chiou@realtek.com>,
Shenghao Ding <shenghao-ding@ti.com>, Kevin Lu <kevin-lu@ti.com>,
Baojun Xu <baojun.xu@ti.com>,
Herve Codina <herve.codina@bootlin.com>,
David Rhodes <david.rhodes@cirrus.com>,
Richard Fitzgerald <rf@opensource.cirrus.com>
Cc: linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-gpio@vger.kernel.org, patches@opensource.cirrus.com,
Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
Subject: [PATCH 09/12] ASoC: codecs: peb2466: use new GPIO line value setter callbacks
Date: Tue, 08 Apr 2025 09:38:27 +0200 [thread overview]
Message-ID: <20250408-gpiochip-set-rv-sound-v1-9-dd54b6ca1ef9@linaro.org> (raw)
In-Reply-To: <20250408-gpiochip-set-rv-sound-v1-0-dd54b6ca1ef9@linaro.org>
From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
struct gpio_chip now has callbacks for setting line values that return
an integer, allowing to indicate failures. Convert the driver to using
them.
Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
---
sound/soc/codecs/peb2466.c | 15 ++++++++++-----
1 file changed, 10 insertions(+), 5 deletions(-)
diff --git a/sound/soc/codecs/peb2466.c b/sound/soc/codecs/peb2466.c
index a989cfe058f0..b8905c03445e 100644
--- a/sound/soc/codecs/peb2466.c
+++ b/sound/soc/codecs/peb2466.c
@@ -1726,7 +1726,8 @@ static int peb2466_chip_gpio_update_bits(struct peb2466 *peb2466, unsigned int x
return ret;
}
-static void peb2466_chip_gpio_set(struct gpio_chip *c, unsigned int offset, int val)
+static int peb2466_chip_gpio_set(struct gpio_chip *c, unsigned int offset,
+ int val)
{
struct peb2466 *peb2466 = gpiochip_get_data(c);
unsigned int xr_reg;
@@ -1740,14 +1741,14 @@ static void peb2466_chip_gpio_set(struct gpio_chip *c, unsigned int offset, int
*/
dev_warn(&peb2466->spi->dev, "cannot set gpio %d (read-only)\n",
offset);
- return;
+ return -EINVAL;
}
ret = peb2466_chip_gpio_offset_to_data_regmask(offset, &xr_reg, &mask);
if (ret) {
dev_err(&peb2466->spi->dev, "cannot set gpio %d (%d)\n",
offset, ret);
- return;
+ return ret;
}
ret = peb2466_chip_gpio_update_bits(peb2466, xr_reg, mask, val ? mask : 0);
@@ -1755,6 +1756,8 @@ static void peb2466_chip_gpio_set(struct gpio_chip *c, unsigned int offset, int
dev_err(&peb2466->spi->dev, "set gpio %d (0x%x, 0x%x) failed (%d)\n",
offset, xr_reg, mask, ret);
}
+
+ return ret;
}
static int peb2466_chip_gpio_get(struct gpio_chip *c, unsigned int offset)
@@ -1879,7 +1882,9 @@ static int peb2466_chip_direction_output(struct gpio_chip *c, unsigned int offse
return -EINVAL;
}
- peb2466_chip_gpio_set(c, offset, val);
+ ret = peb2466_chip_gpio_set(c, offset, val);
+ if (ret)
+ return ret;
if (offset < 16) {
/* SOx_{0,1} */
@@ -1940,7 +1945,7 @@ static int peb2466_gpio_init(struct peb2466 *peb2466)
peb2466->gpio.gpio_chip.direction_input = peb2466_chip_direction_input;
peb2466->gpio.gpio_chip.direction_output = peb2466_chip_direction_output;
peb2466->gpio.gpio_chip.get = peb2466_chip_gpio_get;
- peb2466->gpio.gpio_chip.set = peb2466_chip_gpio_set;
+ peb2466->gpio.gpio_chip.set_rv = peb2466_chip_gpio_set;
peb2466->gpio.gpio_chip.can_sleep = true;
return devm_gpiochip_add_data(&peb2466->spi->dev, &peb2466->gpio.gpio_chip,
--
2.45.2
next prev parent reply other threads:[~2025-04-08 7:38 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-08 7:38 [PATCH 00/12] ASoC: convert GPIO chips to using new value setters Bartosz Golaszewski
2025-04-08 7:38 ` [PATCH 01/12] ASoC: soc-ac97: use new GPIO line value setter callbacks Bartosz Golaszewski
2025-04-08 7:38 ` [PATCH 02/12] ASoC: ti: davinci-mcasp:: " Bartosz Golaszewski
2025-04-08 7:38 ` [PATCH 03/12] ASoC: codecs: wm8962: " Bartosz Golaszewski
2025-04-08 7:38 ` [PATCH 04/12] ASoC: codecs: wm5100: " Bartosz Golaszewski
2025-04-08 7:38 ` [PATCH 05/12] ASoC: codecs: rt5677: " Bartosz Golaszewski
2025-04-08 7:38 ` [PATCH 06/12] ASoC: codecs: wm8996: " Bartosz Golaszewski
2025-04-08 7:38 ` [PATCH 07/12] ASoC: codecs: tlv320adc3xxx: " Bartosz Golaszewski
2025-04-08 7:38 ` [PATCH 08/12] ASoC: codecs: idt821034: " Bartosz Golaszewski
2025-04-08 8:16 ` Herve Codina
2025-04-08 7:38 ` Bartosz Golaszewski [this message]
2025-04-08 8:18 ` [PATCH 09/12] ASoC: codecs: peb2466: " Herve Codina
2025-04-08 7:38 ` [PATCH 10/12] ASoC: codecs: wm8903: " Bartosz Golaszewski
2025-04-08 7:38 ` [PATCH 11/12] ASoC: codecs: zl38060: " Bartosz Golaszewski
2025-04-08 7:38 ` [PATCH 12/12] ALSA: hda: cirrus_scodec_test: " Bartosz Golaszewski
2025-04-08 12:25 ` [PATCH 00/12] ASoC: convert GPIO chips to using new value setters Charles Keepax
2025-04-14 13:56 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250408-gpiochip-set-rv-sound-v1-9-dd54b6ca1ef9@linaro.org \
--to=brgl@bgdev.pl \
--cc=baojun.xu@ti.com \
--cc=bartosz.golaszewski@linaro.org \
--cc=broonie@kernel.org \
--cc=david.rhodes@cirrus.com \
--cc=herve.codina@bootlin.com \
--cc=kevin-lu@ti.com \
--cc=lgirdwood@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=oder_chiou@realtek.com \
--cc=patches@opensource.cirrus.com \
--cc=perex@perex.cz \
--cc=peter.ujfalusi@gmail.com \
--cc=rf@opensource.cirrus.com \
--cc=shenghao-ding@ti.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).