From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9B88C1F4E34; Sat, 12 Apr 2025 17:52:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744480328; cv=none; b=cmSc3N6fPkoosYAmXoI+zY7PsLnxAutP100t6e/hU+jGNS2D8DljzcTfi85xoDzdCv/znHTRcICjaxXpniJnWuj5IOPGiZh1P0hyCQIGSsAc5l3fkR6yskKT6iC1iU2EsFi01p9Q5w7V+9wS/37+RJtjRTESqZencKWik2rxSds= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744480328; c=relaxed/simple; bh=ZSemBqNWvxfXf7wozXPgFrv4J+FrxqsyyJvFkrck0zk=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=lvlK8aV3vEAM8XyAKRGcYWP5IIAEbXUZNnYQcWIZhfdSGzxWdGIYu0tsEumpWYu5XYtUWMNjcwetYATsYvJWjZh9RnI/DEGS1Y06G4R+9c4lwnClb09XWj3MRC3Xtq1n3c97jjtnoe1Q0cLZ9FpCBSWSqu7JCGisYRZVcxsxA2A= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=ITHxGCC+; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="ITHxGCC+" Received: by smtp.kernel.org (Postfix) with ESMTPSA id E89DAC4CEE3; Sat, 12 Apr 2025 17:52:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1744480328; bh=ZSemBqNWvxfXf7wozXPgFrv4J+FrxqsyyJvFkrck0zk=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=ITHxGCC+GRpClt8k59wiSW3ZuAI9ON8Dq6DYIPrvmYiFdo8me+kN7pmI+tCoK5D7G EdfhEtU6xRQJbxf+MtM382wYcLtXvHyyykqbWHUy/dYwnUPim7NtaUimUHYitSfush ARLLGvLhVal3mTJg3dZjZe4OkGnZzcSpwGK8T3sLV+Zqdy+cQjjM/b64qSkovpY2C9 WlqkcRCaJyLHNLGo5TMq98+aRyvYmkmlSox+tVAiHPdiyShsj6ZnSvxNSOrkkXHK4j 4Dnvn2HsqFTw/ChTRoVFcuF4Z6U4acXZm9LfVEPK/OXIYkAAZSBhIFQupkKnTdO7UI 1tGPZfWBCk1bQ== Date: Sat, 12 Apr 2025 18:51:58 +0100 From: Jonathan Cameron To: Jonathan Santos Cc: , , , , , , , , , , , , , , , , Subject: Re: [PATCH v5 05/14] iio: adc: ad7768-1: convert driver to use regmap Message-ID: <20250412185158.5d47e918@jic23-huawei> In-Reply-To: References: X-Mailer: Claws Mail 4.3.0 (GTK 3.24.48; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: linux-gpio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Fri, 11 Apr 2025 12:56:56 -0300 Jonathan Santos wrote: > Convert the AD7768-1 driver to use the regmap API for register > access. This change simplifies and standardizes register interactions, > reducing code duplication and improving maintainability. > > Create two regmap configurations, one for 8-bit register values and > other for 24-bit register values. > > Since we are using regmap now, define the remaining registers from 0x32 > to 0x34. > > Reviewed-by: David Lechner > Signed-off-by: Jonathan Santos Hi Jonathan, Given this is a fairly substantial set and some parts stand on their own, I'm going to pick up some patches now despite discussion being ongoing about bindings etc. Please rebase your next version on the testing branch of iio.git to take this into account. Applied this patch. Thanks, Jonathan