From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EB16F2DFA37; Tue, 15 Apr 2025 15:14:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744730083; cv=none; b=aj/MiXUZySsTtFaMW+VKU3mK2WSDpXjZBEK9Q/bOS0HEWSut7QnN5eV8LjpYTBYbm0F5fM52AVSSKerHqNvgVveML7jI318I3M3+bVejzdLnMaX+WNvxlOFzuqFcS3YCX0MvHrPsaM7o5RKq1zSYQJORwdwUTzoFQMU9rT8e+H8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744730083; c=relaxed/simple; bh=NNkg4KBG1XF1rTXXMic0/x6nqkOh+W1QMwlkngBnbt4=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=BmH4Cewb1XJFmDw1YDzB6BIScR0O4rKeQWUH6NCOMgj+tNCdFWOhbfhxij+qY1eBBHE7jRvMNGEsiqisXbp5MxUo4pkANUqQTPGE9WSoumGcGpKpMXp3Mt4dcP6TRiJ8z1fSFNL67MdQuVtyMjp6KBGbTGWSMxbzuedS2fPyroI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=W/pMlr3U; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="W/pMlr3U" Received: by smtp.kernel.org (Postfix) with ESMTPSA id BADF4C4CEEB; Tue, 15 Apr 2025 15:14:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1744730081; bh=NNkg4KBG1XF1rTXXMic0/x6nqkOh+W1QMwlkngBnbt4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=W/pMlr3UVFCYWBcvpZLOuCoJgy02g1s9zvI/HbBU0IB5Ekwz/NQIU4hYUtuS7/kGp gQPoFcHfZNCkuUntHqGxew5OAMaa9ofiCoclWpcBNC9IhsaNt1Ch6dIe9a1idXXebt 8X55QOY5Pi2zPWt2+UtyT/8B724qof+ccML8BPh0= Date: Tue, 15 Apr 2025 17:14:38 +0200 From: Greg Kroah-Hartman To: Herve Codina Cc: Andrea della Porta , Michael Turquette , Stephen Boyd , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Florian Fainelli , Broadcom internal kernel review list , Lorenzo Pieralisi , Krzysztof Wilczynski , Manivannan Sadhasivam , Bjorn Helgaas , Linus Walleij , Catalin Marinas , Will Deacon , Bartosz Golaszewski , Derek Kiernan , Dragan Cvetic , Arnd Bergmann , Saravana Kannan , linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, linux-gpio@vger.kernel.org, Masahiro Yamada , Stefan Wahren , Luca Ceresoli , Thomas Petazzoni , Andrew Lunn , Phil Elwell , Dave Stevenson , kernel-list@raspberrypi.com Subject: Re: [PATCH v8 08/13] misc: rp1: RaspberryPi RP1 misc driver Message-ID: <2025041531-dubiously-duchess-276a@gregkh> References: <3fbc487bc0e4b855ffbee8ed62cfb6bf3b0592e8.1742418429.git.andrea.porta@suse.com> <2025041557-masculine-abrasive-c372@gregkh> <20250415165505.0c05bc61@bootlin.com> Precedence: bulk X-Mailing-List: linux-gpio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250415165505.0c05bc61@bootlin.com> On Tue, Apr 15, 2025 at 04:55:05PM +0200, Herve Codina wrote: > Hi Greg, > > On Tue, 15 Apr 2025 16:06:43 +0200 > Greg Kroah-Hartman wrote: > > > On Wed, Mar 19, 2025 at 10:52:29PM +0100, Andrea della Porta wrote: > > > The RaspberryPi RP1 is a PCI multi function device containing > > > peripherals ranging from Ethernet to USB controller, I2C, SPI > > > and others. > > > > So shouldn't this be using the auxbus code? That's designed to "split > > up" PCI devices such that you can share them this way. > > > > Or did that get rejected somewhere previously? > > > > It doesn't use auxbus probably for the exact same reason that the > one given for the LAN966x PCI device driver [0] and [1]. > > Avoid all boiler plate needed with auxbus whereas drivers already exist > as platform drivers. Internal devices are handled by those platform drivers. > Those devi just need to be described as platform devices and device-tree is > fully relevant for that description. > > [0] https://lore.kernel.org/all/CAL_Jsq+1r3SSaXupdNAcXO-4rcV-_3_hwh0XJaBsB9fuX5nBCQ@mail.gmail.com/ > [1] https://lore.kernel.org/all/Y9kuxrL3XaCG+blk@kroah.com/ I really hate creating platform devices below a PCI device, so I'll keep complaining about this every time people try to do it. thanks, greg k-h