From: Bartosz Golaszewski <brgl@bgdev.pl>
To: Linus Walleij <linus.walleij@linaro.org>,
Bartosz Golaszewski <brgl@bgdev.pl>,
Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>,
Lixu Zhang <lixu.zhang@intel.com>,
Sakari Ailus <sakari.ailus@linux.intel.com>,
Yinbo Zhu <zhuyinbo@loongson.cn>
Cc: linux-gpio@vger.kernel.org, imx@lists.linux.dev,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
Subject: [PATCH 01/12] gpio: imx-scu: don't check the GPIO range
Date: Wed, 23 Apr 2025 09:15:03 +0200 [thread overview]
Message-ID: <20250423-gpiochip-set-rv-gpio-part2-v1-1-b22245cde81a@linaro.org> (raw)
In-Reply-To: <20250423-gpiochip-set-rv-gpio-part2-v1-0-b22245cde81a@linaro.org>
From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
Core GPIO code already does this for drivers, no need to duplicate the
check.
Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
---
drivers/gpio/gpio-imx-scu.c | 9 ---------
1 file changed, 9 deletions(-)
diff --git a/drivers/gpio/gpio-imx-scu.c b/drivers/gpio/gpio-imx-scu.c
index 13baf465aedf..403d03f18122 100644
--- a/drivers/gpio/gpio-imx-scu.c
+++ b/drivers/gpio/gpio-imx-scu.c
@@ -37,9 +37,6 @@ static int imx_scu_gpio_get(struct gpio_chip *chip, unsigned int offset)
int level;
int err;
- if (offset >= chip->ngpio)
- return -EINVAL;
-
mutex_lock(&priv->lock);
/* to read PIN state via scu api */
@@ -60,9 +57,6 @@ static void imx_scu_gpio_set(struct gpio_chip *chip, unsigned int offset, int va
struct scu_gpio_priv *priv = gpiochip_get_data(chip);
int err;
- if (offset >= chip->ngpio)
- return;
-
mutex_lock(&priv->lock);
/* to set PIN output level via scu api */
@@ -77,9 +71,6 @@ static void imx_scu_gpio_set(struct gpio_chip *chip, unsigned int offset, int va
static int imx_scu_gpio_get_direction(struct gpio_chip *chip, unsigned int offset)
{
- if (offset >= chip->ngpio)
- return -EINVAL;
-
return GPIO_LINE_DIRECTION_OUT;
}
--
2.45.2
next prev parent reply other threads:[~2025-04-23 7:15 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-23 7:15 [PATCH 00/12] gpio: convert more GPIO chips to using new value setters - part 2 for v6.16 Bartosz Golaszewski
2025-04-23 7:15 ` Bartosz Golaszewski [this message]
2025-04-23 7:15 ` [PATCH 02/12] gpio: imx-scu: use lock guards Bartosz Golaszewski
2025-04-23 7:15 ` [PATCH 03/12] gpio: imx-scu: destroy the mutex in detach path Bartosz Golaszewski
2025-04-23 7:15 ` [PATCH 04/12] gpio: imx-scu: use new line value setter callbacks Bartosz Golaszewski
2025-04-23 7:15 ` [PATCH 05/12] gpio: it87: " Bartosz Golaszewski
2025-12-07 4:55 ` Daniel Gibson
2025-12-08 4:48 ` Bartosz Golaszewski
2025-12-08 20:48 ` Daniel Gibson
2025-04-23 7:15 ` [PATCH 06/12] gpio: janz-ttl: " Bartosz Golaszewski
2025-04-23 7:15 ` [PATCH 07/12] gpio: kempld: " Bartosz Golaszewski
2025-04-23 7:15 ` [PATCH 08/12] gpio: ljca: " Bartosz Golaszewski
2025-04-23 7:28 ` Sakari Ailus
2025-04-23 7:15 ` [PATCH 09/12] gpio: logicvc: " Bartosz Golaszewski
2025-04-23 7:15 ` [PATCH 10/12] gpio: loongson-64bit: " Bartosz Golaszewski
2025-04-23 7:15 ` [PATCH 11/12] gpio: loongson: " Bartosz Golaszewski
2025-04-23 7:15 ` [PATCH 12/12] gpio: lp3943: " Bartosz Golaszewski
2025-04-23 10:58 ` [PATCH 00/12] gpio: convert more GPIO chips to using new value setters - part 2 for v6.16 Linus Walleij
2025-04-28 12:23 ` Peng Fan
2025-04-30 8:28 ` Bartosz Golaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250423-gpiochip-set-rv-gpio-part2-v1-1-b22245cde81a@linaro.org \
--to=brgl@bgdev.pl \
--cc=bartosz.golaszewski@linaro.org \
--cc=festevam@gmail.com \
--cc=imx@lists.linux.dev \
--cc=kernel@pengutronix.de \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lixu.zhang@intel.com \
--cc=s.hauer@pengutronix.de \
--cc=sakari.ailus@linux.intel.com \
--cc=shawnguo@kernel.org \
--cc=zhuyinbo@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).