PixArt touchpad not detected due to wrong pinctrl

PixArt touchpad not detected due to wrong pinctrl

[Guido Trentalancia via Bugspray Bot]

Guido Trentalancia writes via Kernel.org Bugzilla:

The I2C PixArt touchpad (PIXA3848) found on some laptops using the Intel Alderlake chipset, including several Acer laptops and the Framework Laptop 13 is not detected due to a bug in the pinctrl module: to use the touchpad it is necessary to use CONFIGURE_PINCTRL_TIGERLAKE in the kernel configuration, even though the laptop uses the newer Alderlake chipset (CONFIGURE_PINCTRL_ALDERLAKE).

See: PixArt touchpad: https://linux-hardware.org/?id=ps/2:3848-3848-pixa3848-00-093a-touchpad

See: Framework laptop configuration on Gentoo wiki: https://wiki.gentoo.org/wiki/Framework_Laptop_13

View: https://bugzilla.kernel.org/show_bug.cgi?id=220056#c0
You can reply to this message to join the discussion.
-- 
Deet-doot-dot, I am a bot.
Kernel.org Bugzilla (bugspray 0.1-dev)

Re: PixArt touchpad not detected due to wrong pinctrl

[Ariel Simulevski via Bugspray Bot]

Ariel Simulevski added an attachment on Kernel.org Bugzilla:

Created attachment 308024
Attached a patch that adds missing I2C pin definitions for Alder Lake. Needs testing on real hardware.

Hey! I tried fixing this as my first attempt at kernel hacking.
I added missing I2C2/I2C3/I2C4 pin definitions based on the Tiger Lake mappings.
This should definitely be tested on real hardware to verify if it resolves the touchpad detection issue.

File: 0001-pinctrl-alderlake-Add-missing-I2C2-I2C3-I2C4-pin-def.patch (application/mbox)
Size: 1.62 KiB
Link: https://bugzilla.kernel.org/attachment.cgi?id=308024
---
Attached a patch that adds missing I2C pin definitions for Alder Lake. Needs testing on real hardware.

You can reply to this message to join the discussion.
-- 
Deet-doot-dot, I am a bot.
Kernel.org Bugzilla (bugspray 0.1-dev)

Re: PixArt touchpad not detected due to wrong pinctrl

[Guido Trentalancia via Bugspray Bot]

Guido Trentalancia writes via Kernel.org Bugzilla:

I confirm that the proposed patch resolves the issue. Thanks.

View: https://bugzilla.kernel.org/show_bug.cgi?id=220056#c2
You can reply to this message to join the discussion.
-- 
Deet-doot-dot, I am a bot.
Kernel.org Bugzilla (bugspray 0.1-dev)

Re: PixArt touchpad not detected due to wrong pinctrl

[Guido Trentalancia via Bugspray Bot]

Guido Trentalancia added an attachment on Kernel.org Bugzilla:

Created attachment 308025
Proposed patch with correct pin numbering and comment

Revised patch which does at least introduce the new pins with an acceptable numbering

File: linux-add-missing-I2C-pin-defs-left-over-from-tigerlake.patch (text/plain)
Size: 1.69 KiB
Link: https://bugzilla.kernel.org/attachment.cgi?id=308025
---
Proposed patch with correct pin numbering and comment

You can reply to this message to join the discussion.
-- 
Deet-doot-dot, I am a bot.
Kernel.org Bugzilla (bugspray 0.1-dev)

Re: PixArt touchpad not detected due to wrong pinctrl

[Guido Trentalancia via Bugspray Bot]

Guido Trentalancia writes via Kernel.org Bugzilla:

Please see the attached revised patch: the comment has been improved and the new pins are introduced with at least an acceptable numbering, if you want to avoid reordering the whole list.

View: https://bugzilla.kernel.org/show_bug.cgi?id=220056#c4
You can reply to this message to join the discussion.
-- 
Deet-doot-dot, I am a bot.
Kernel.org Bugzilla (bugspray 0.1-dev)

Re: PixArt touchpad not detected due to wrong pinctrl

[Ariel Simulevski via Bugspray Bot]

Ariel Simulevski writes via Kernel.org Bugzilla:

Awesome, thanks!
Do you want to submit the patch or shall I?
As I'm learning, I'd like to give it a shot :)

View: https://bugzilla.kernel.org/show_bug.cgi?id=220056#c5
You can reply to this message to join the discussion.
-- 
Deet-doot-dot, I am a bot.
Kernel.org Bugzilla (bugspray 0.1-dev)

Re: PixArt touchpad not detected due to wrong pinctrl

[Guido Trentalancia via Bugspray Bot]

Guido Trentalancia added an attachment on Kernel.org Bugzilla:

Created attachment 308026
Second revision of the patch with an example on how to correct the structure bounds

Correct the community structure bounds.

File: linux-add-missing-I2C-pin-defs-left-over-from-tigerlake-v2.patch (text/plain)
Size: 2.42 KiB
Link: https://bugzilla.kernel.org/attachment.cgi?id=308026
---
Second revision of the patch with an example on how to correct the structure bounds

You can reply to this message to join the discussion.
-- 
Deet-doot-dot, I am a bot.
Kernel.org Bugzilla (bugspray 0.1-dev)

Re: PixArt touchpad not detected due to wrong pinctrl

[Guido Trentalancia via Bugspray Bot]

Guido Trentalancia writes via Kernel.org Bugzilla:

If you submit the patch as it is, it will probably be rejected even if it resolves the issue.

I don't have the Intel specifications, therefore I am not sure how to proceed. 

But please consider that the pin definitions are grouped in communities.

So, the structures at the bottom of the file also need to be updated...

Please see the latest revised patch on how in principle the bounds of the structure definitions need to be updated.

View: https://bugzilla.kernel.org/show_bug.cgi?id=220056#c7
You can reply to this message to join the discussion.
-- 
Deet-doot-dot, I am a bot.
Kernel.org Bugzilla (bugspray 0.1-dev)

Re: PixArt touchpad not detected due to wrong pinctrl

[Ariel Simulevski via Bugspray Bot]

Ariel Simulevski added an attachment on Kernel.org Bugzilla:

Created attachment 308027
Revised v2 patch: add missing I2C2/I2C3/I2C4 pins and update community structures

Hi Guido,

Thanks again for the feedback.

I have uploaded a revised v2 patch that corrects both the pin definitions and the community structures as you suggested.

Would appreciate your review before I send it upstream. Thanks!

File: 0001-pinctrl-alderlake-Add-missing-I2C2-I2C3-I2C4-pin-def-v2.patch (text/plain)
Size: 2.39 KiB
Link: https://bugzilla.kernel.org/attachment.cgi?id=308027
---
Revised v2 patch: add missing I2C2/I2C3/I2C4 pins and update community structures

You can reply to this message to join the discussion.
-- 
Deet-doot-dot, I am a bot.
Kernel.org Bugzilla (bugspray 0.1-dev)

Re: PixArt touchpad not detected due to wrong pinctrl

[Andy Shevchenko via Bugspray Bot]

Andy Shevchenko writes via Kernel.org Bugzilla:

Folks, I don't know what's going on here, but using the Tiger Lake driver is the correct approach. So, what's the problem?

View: https://bugzilla.kernel.org/show_bug.cgi?id=220056#c9
You can reply to this message to join the discussion.
-- 
Deet-doot-dot, I am a bot.
Kernel.org Bugzilla (bugspray 0.1-dev)

Re: PixArt touchpad not detected due to wrong pinctrl

[Andy Shevchenko via Bugspray Bot]

Andy Shevchenko writes via Kernel.org Bugzilla:

Note, the patch without shuffling the ACPI IDs does basically nothing, it adds random pins to random driver. I'm utterly confused on how it may solve anything, but adding problems.

View: https://bugzilla.kernel.org/show_bug.cgi?id=220056#c10
You can reply to this message to join the discussion.
-- 
Deet-doot-dot, I am a bot.
Kernel.org Bugzilla (bugspray 0.1-dev)

Re: PixArt touchpad not detected due to wrong pinctrl

[Ariel Simulevski via Bugspray Bot]

Ariel Simulevski writes via Kernel.org Bugzilla:

Thanks Andy for the clarification.

I'm still learning and don't fully understand all the platform details here yet, but I appreciate you explaining why patching the Alder Lake driver isn't the right approach.

Thanks again for taking the time to review this!

View: https://bugzilla.kernel.org/show_bug.cgi?id=220056#c11
You can reply to this message to join the discussion.
-- 
Deet-doot-dot, I am a bot.
Kernel.org Bugzilla (bugspray 0.1-dev)

Re: PixArt touchpad not detected due to wrong pinctrl

[Guido Trentalancia via Bugspray Bot]

Guido Trentalancia writes via Kernel.org Bugzilla:

How can using the pinctrl driver for another chipset be the right approach ?

An user which configures the kernel for a machine based on the Intel Alder Lake chipset cannot figure out that the pinctrl driver for another chipset needs to be used.

I have tried searching for the official Intel PCH specification, but it seems that no specifications are available:

https://www.intel.com/content/www/us/en/products/platforms/details/alder-lake-p/docs.html

I agree that the current patch from Ariel does not respect the proper grouping and ordering of communities (which need to be based on official specifications) and that therefore it is not ready for merging, but the solution in my opinion is to fix the patch so that the Alder Lake pinctrl module correctly defines the I2C pins.

View: https://bugzilla.kernel.org/show_bug.cgi?id=220056#c12
You can reply to this message to join the discussion.
-- 
Deet-doot-dot, I am a bot.
Kernel.org Bugzilla (bugspray 0.1-dev)

Re: PixArt touchpad not detected due to wrong pinctrl

[Guido Trentalancia via Bugspray Bot]

Guido Trentalancia writes via Kernel.org Bugzilla:

Marking it as REOPENED because the issue has not been resolved nor the specifications to resolve it have been provided.

View: https://bugzilla.kernel.org/show_bug.cgi?id=220056#c13
You can reply to this message to join the discussion.
-- 
Deet-doot-dot, I am a bot.
Kernel.org Bugzilla (bugspray 0.1-dev)

Re: PixArt touchpad not detected due to wrong pinctrl

[Ariel Simulevski via Bugspray Bot]

Ariel Simulevski writes via Kernel.org Bugzilla:

Yeah as it stands, this grouping is based on observation, not official documentation (I think I even wrote that in a comment in my first patch). As I don’t have access to the Intel PCH documentation (and am still getting into Kernel Hacking), these were more or less educated guesses.

Andy if you prefer, I am happy to withdraw the patch and instead suggest documenting the need to use CONFIG_PINCTRL_TIGERLAKE for affected systems.

I do agree with Guido tho that the status quo is sort of confusing.

View: https://bugzilla.kernel.org/show_bug.cgi?id=220056#c14
You can reply to this message to join the discussion.
-- 
Deet-doot-dot, I am a bot.
Kernel.org Bugzilla (bugspray 0.1-dev)

Re: PixArt touchpad not detected due to wrong pinctrl

[Andy Shevchenko via Bugspray Bot]

Andy Shevchenko writes via Kernel.org Bugzilla:

(In reply to Guido Trentalancia from comment #12)

TL;DR: Yes, we probably need to amend the help texts for the kernel configuration options, no code seem need to be fixed.

> How can using the pinctrl driver for another chipset be the right approach ?

This is the big misunderstanding here. Linux is NOT a Windows in a sense of the device driver model and what the approach is used for the supported platforms. Besides that the granularity of the platform is not a *chipset*, it's *an IP*. And this makes a lot of differences here. The whatever chipset or hardware in a sense may use and re-use the same IP blocks over and over. That's why one driver can span over several generations of the hardware. This approach applies to many vendors and much more hardware IPs than just this case. I suggest you to study this more (in case you want to go deep with it).

View: https://bugzilla.kernel.org/show_bug.cgi?id=220056#c15
You can reply to this message to join the discussion.
-- 
Deet-doot-dot, I am a bot.
Kernel.org Bugzilla (bugspray 0.1-dev)

Re: PixArt touchpad not detected due to wrong pinctrl

[Andy Shevchenko via Bugspray Bot]

Andy Shevchenko writes via Kernel.org Bugzilla:

(In reply to Guido Trentalancia from comment #13)
> Marking it as REOPENED because the issue has not been resolved nor the
> specifications to resolve it have been provided.

What *issue*?! The provided patch does NOT solve *anything*. It makes things worse. Please, try to explain the issue here, as I am completely out on what's going on here. Currently it's all red herring.

View: https://bugzilla.kernel.org/show_bug.cgi?id=220056#c16
You can reply to this message to join the discussion.
-- 
Deet-doot-dot, I am a bot.
Kernel.org Bugzilla (bugspray 0.1-dev)

Re: PixArt touchpad not detected due to wrong pinctrl

[Andy Shevchenko via Bugspray Bot]

Andy Shevchenko writes via Kernel.org Bugzilla:

(In reply to Ariel Simulevski from comment #14)
> Yeah as it stands, this grouping is based on observation, not official
> documentation (I think I even wrote that in a comment in my first patch). As
> I don’t have access to the Intel PCH documentation (and am still getting
> into Kernel Hacking), these were more or less educated guesses.
> 
> Andy if you prefer, I am happy to withdraw the patch and instead suggest
> documenting the need to use CONFIG_PINCTRL_TIGERLAKE for affected systems.
> 
> I do agree with Guido tho that the status quo is sort of confusing.

To understand the issue, I need to hear how you reproduce it and how this patch makes it different. The drivers are bound to the devices based on ID tables (ACPI ID table in this case). Your change doesn't alter that and hence it can't be involved in anything related to this case, it can't *fix* anything.

View: https://bugzilla.kernel.org/show_bug.cgi?id=220056#c17
You can reply to this message to join the discussion.
-- 
Deet-doot-dot, I am a bot.
Kernel.org Bugzilla (bugspray 0.1-dev)

Re: PixArt touchpad not detected due to wrong pinctrl

[Guido Trentalancia via Bugspray Bot]

Guido Trentalancia writes via Kernel.org Bugzilla:

Andy, the patch that Ariel provided did sort the issue of I2C PIXA touchpad detection, although it's pretty clear that it uses duplicated pin numbering that needs proper grouping and ordering within the existing communities.

So Ariel intuition sounds correct to me, in that the pin definitions for I2C SDA and SCL lines are missing in the Alder Lake pinctrl driver.

From an end-user point of view it's illogical and not intuitive that one has to use a kernel module targeting another chipset in order for I2C device detection to work properly.

Steps to reproduce:

 - grab an Intel Alder Lake based laptop using the PixArt touchpad from the list 
   provided at:
   https://linux-hardware.org/?id=ps/2:3848-3848-pixa3848-00-093a-touchpad

 - build a kernel with the pinctrl-alderlake module using the
   CONFIG_PINCTRL_ALDERLAKE kernel configuration option: this is what a normal
   end user does

 - install the newly built kernel and reboot

 - start an X session and realize that the touchpad is not working or otherwise
   use "dmesg | grep -i input" to realize from the kernel log that the I2C
   touchpad has not been detected

Steps to resolve the issue:

 - apply any of the patches provided in this bug report

 - rebuild the kernel, install it and reboot

 - start an X session or type "dmesg | grep -i input" and realize that the I2C
   PixArt touchpad is not detected, as the Alder Lake pinctrl driver now
   includes the definitions for the I2C SDA and SCL lines that were missing in
   the original version of the kernel Alder Lake pinctrl module

Steps that might possibly lead to the creation of a proper patch:

 - edit the drivers/pinctrl/intel/pinctrl-alderlake.c kernel module source code

 - ask Intel to kindly provide the official documentation for the Alder Lake PCH

 - add the definition for the 4 I2C SDA and SCL lines in the proper group and
   community: for example in the Tiger Lake driver that was group GPP_H and
   community 1

 - modify the bounds in the structures at the bottom of the kernel module source
   code in order to account for the newly added I2C SDA and SCL lines

I believe marking this as RESOLVED INVALID is not the way forward.

View: https://bugzilla.kernel.org/show_bug.cgi?id=220056#c18
You can reply to this message to join the discussion.
-- 
Deet-doot-dot, I am a bot.
Kernel.org Bugzilla (bugspray 0.1-dev)

Re: PixArt touchpad not detected due to wrong pinctrl

[Andy Shevchenko via Bugspray Bot]

Andy Shevchenko writes via Kernel.org Bugzilla:

(In reply to Guido Trentalancia from comment #18)
> Andy, the patch that Ariel provided did sort the issue of I2C PIXA touchpad
> detection, although it's pretty clear that it uses duplicated pin numbering
> that needs proper grouping and ordering within the existing communities.
> 
> So Ariel intuition sounds correct to me, in that the pin definitions for I2C
> SDA and SCL lines are missing in the Alder Lake pinctrl driver.

> From an end-user point of view it's illogical and not intuitive that one has
> to use a kernel module targeting another chipset in order for I2C device
> detection to work properly.

It's how the hardware world works like it or not. Yeah, same code-named hardware can use different IP blocks in different revisions. This is a headache for users, I agree, but I can't do anything about this.

> Steps to reproduce:
> 
>  - grab an Intel Alder Lake based laptop using the PixArt touchpad from the
> list 
>    provided at:
>    https://linux-hardware.org/?id=ps/2:3848-3848-pixa3848-00-093a-touchpad
> 
>  - build a kernel with the pinctrl-alderlake module using the
>    CONFIG_PINCTRL_ALDERLAKE kernel configuration option: this is what a
> normal
>    end user does
> 
>  - install the newly built kernel and reboot
> 
>  - start an X session and realize that the touchpad is not working or
> otherwise
>    use "dmesg | grep -i input" to realize from the kernel log that the I2C
>    touchpad has not been detected

Okay, this part is clear.

> Steps to resolve the issue:
> 
>  - apply any of the patches provided in this bug report

This is totally unclear. The list of pins is defined in the specification, the change like proposed messes things up with that. I suspect there is something else is going on here.

>  - rebuild the kernel, install it and reboot
> 
>  - start an X session or type "dmesg | grep -i input" and realize that the
> I2C
>    PixArt touchpad is not detected, as the Alder Lake pinctrl driver now
>    includes the definitions for the I2C SDA and SCL lines that were missing
> in
>    the original version of the kernel Alder Lake pinctrl module

Please, make this one crystal clear: Does the switch from Alder Lake pin control driver to Tiger Lake driver solve the issue *without* any patches?

> Steps that might possibly lead to the creation of a proper patch:
> 
>  - edit the drivers/pinctrl/intel/pinctrl-alderlake.c kernel module source
> code
> 
>  - ask Intel to kindly provide the official documentation for the Alder Lake
> PCH

The EDS usually is available via Intel official site. I can look for the links later on after I get more information about the HW you are talking about.

>  - add the definition for the 4 I2C SDA and SCL lines in the proper group and
>    community: for example in the Tiger Lake driver that was group GPP_H and
>    community 1

No, this won't happen. The pin control Alder Lake driver is written for Alder Lake-N and Alder Lake-S, you are probably talking about different version of the Alder Lake, or not Alder Lake at all. I will know more after the requested (below) information provided.

>  - modify the bounds in the structures at the bottom of the kernel module
> source
>    code in order to account for the newly added I2C SDA and SCL lines

> I believe marking this as RESOLVED INVALID is not the way forward.

Fair enough.

Okay, let's go long way. Please, attach the followin outputs (all should be run as root):
1) `dmesg` (from the boot to the shell) when kernel command line has 'ignore_loglevel initcall_debug`. Ideally kernel should be build with `CONFIG_DEBUG_PINCTRL=y` and `CONFIG_DEBUG_GPIO=y`. Also make sure you use vanilla kernel without any custom patches.
2) `lspci -nk -vv`
3) `acpidump -o adl-xx-tables.dat` (the mentioned *.dat file)
4) `cat /proc/interrupts`
5) `lscpu`
6) `cat /proc/iomem`
7) `grep -H 15 /sys/bus/acpi/devices/*/status`

I believe with this information I can see more, currently this report is no go (only I may agree on the documentation changes).

View: https://bugzilla.kernel.org/show_bug.cgi?id=220056#c19
You can reply to this message to join the discussion.
-- 
Deet-doot-dot, I am a bot.
Kernel.org Bugzilla (bugspray 0.1-dev)

Re: PixArt touchpad not detected due to wrong pinctrl

[Guido Trentalancia via Bugspray Bot]

Guido Trentalancia writes via Kernel.org Bugzilla:

The chipset is Alderlake-P as already said in https://bugzilla.kernel.org/show_bug.cgi?id=220056#c12

The issue is resolved by applying the patch from Ariel or by using the Tigerlake pinctrl kernel module, although I believe the latter approach is the wrong solution.

Some relevant system information follows. Please provide the link to the relevant official Intel PCH I2C specifications.

[dmesg | grep PIXA] || [dmesg | grep input] ** with the patch applied **
input: PIXA3848:01 093A:3848 Mouse as /devices/pci0000:00/0000:00:15.1/i2c_designware.1/i2c-1/i2c-PIXA3848:01/0018:093A:3848.0001/input/input3
input: PIXA3848:01 093A:3848 Touchpad as /devices/pci0000:00/0000:00:15.1/i2c_designware.1/i2c-1/i2c-PIXA3848:01/0018:093A:3848.0001/input/input4
hid-multitouch 0018:093A:3848.0001: input,hidraw0: I2C HID v1.00 Mouse [PIXA3848:01 093A:3848] on i2c-PIXA3848:01

without the patch applied or without the Tigerlake pinctrl kernel module the output of 'dmesg | grep PIXA' and 'dmesg | grep input' is blank
as the I2C PixArt touchpad device is not detected.

[cat /proc/interrupts] ** with patch applied **

 188:          0          0          0      58039          0          0          0          0          0          0          0          0 intel-gpio    3  PIXA3848:01

without the patch applied or without the Tigerlake pinctrl kernel module the output is blank, as the I2C PixArt touchpad device is not detected (see above).

[/sys/bus/acpi/devices/PIXA*/status]

cat /sys/bus/acpi/devices/PIXA3848\:0*/status
0
15

[acpidump | grep PIXA]

 71210: 0D 50 4E 50 30 43 35 30 00 12 1B 05 0A 1D 0A 68  .PNP0C50.......h
 71220: 0A 20 0D 50 49 58 41 33 38 34 38 00 0D 50 4E 50  . .PIXA3848..PNP
 71230: 30 43 35 30 00 12 16 05 0A 20 0A FF 0A FF 0D 45  0C50..... .....E
 71240: 54 44 30 35 31 38 00 0C 41 D0 0F 13 12 16 05 0A  TD0518..A.......
--
 71350: FF 0A FF 0D 45 54 44 30 35 32 32 00 0C 41 D0 0F  ....ETD0522..A..
 71360: 13 12 17 05 0A 2D 0A FF 0A FF 0D 50 49 58 41 33  .....-.....PIXA3
 71370: 38 34 38 00 0C 41 D0 0F 13 12 1A 05 0A FE 0A 15  848..A..........
 71380: 01 0D 45 4C 41 4E 30 35 30 34 00 0D 50 4E 50 30  ..ELAN0504..PNP0
--
 716E0: 50 30 43 35 30 00 12 1B 05 0A 1D 0A 68 0A 20 0D  P0C50.......h. .
 716F0: 50 49 58 41 33 38 34 38 00 0D 50 4E 50 30 43 35  PIXA3848..PNP0C5
 71700: 30 00 12 16 05 0A 20 0A FF 0A FF 0D 45 54 44 30  0..... .....ETD0
 71710: 35 31 38 00 0C 41 D0 0F 13 12 16 05 0A 21 0A FF  518..A.......!..
--
 71820: 0D 45 54 44 30 35 32 32 00 0C 41 D0 0F 13 12 17  .ETD0522..A.....
 71830: 05 0A 2D 0A FF 0A FF 0D 50 49 58 41 33 38 34 38  ..-.....PIXA3848
 71840: 00 0C 41 D0 0F 13 12 1A 05 0A FE 0A 15 01 0D 45  ..A............E
 71850: 4C 41 4E 30 35 30 34 00 0D 50 4E 50 30 43 35 30  LAN0504..PNP0C50

[lspci]

0000:00:15.0 Serial bus controller: Intel Corporation Alder Lake PCH Serial IO I2C Controller #0 (rev 01)
	Subsystem: Acer Incorporated [ALI] Device 161d
	Control: I/O- Mem+ BusMaster+ SpecCycle- MemWINV- VGASnoop- ParErr- Stepping- SERR- FastB2B- DisINTx-
	Status: Cap+ 66MHz- UDF- FastB2B- ParErr- DEVSEL=fast >TAbort- <TAbort- <MAbort- >SERR- <PERR- INTx-
	Latency: 0, Cache Line Size: 64 bytes
	Interrupt: pin A routed to IRQ 27
	IOMMU group: 10
	Region 0: Memory at 4017000000 (64-bit, non-prefetchable) [virtual] [size=4K]
	Capabilities: [80] Power Management version 3
		Flags: PMEClk- DSI- D1- D2- AuxCurrent=0mA PME(D0-,D1-,D2-,D3hot-,D3cold-)
		Status: D3 NoSoftRst+ PME-Enable- DSel=0 DScale=0 PME-
	Capabilities: [90] Vendor Specific Information: Len=14 <?>
	Kernel driver in use: intel-lpss

0000:00:15.1 Serial bus controller: Intel Corporation Alder Lake PCH Serial IO I2C Controller #1 (rev 01)
	Subsystem: Acer Incorporated [ALI] Device 161d
	Control: I/O- Mem+ BusMaster+ SpecCycle- MemWINV- VGASnoop- ParErr- Stepping- SERR- FastB2B- DisINTx-
	Status: Cap+ 66MHz- UDF- FastB2B- ParErr- DEVSEL=fast >TAbort- <TAbort- <MAbort- >SERR- <PERR- INTx-
	Latency: 0, Cache Line Size: 64 bytes
	Interrupt: pin B routed to IRQ 40
	IOMMU group: 10
	Region 0: Memory at 4017001000 (64-bit, non-prefetchable) [virtual] [size=4K]
	Capabilities: [80] Power Management version 3
		Flags: PMEClk- DSI- D1- D2- AuxCurrent=0mA PME(D0-,D1-,D2-,D3hot-,D3cold-)
		Status: D3 NoSoftRst+ PME-Enable- DSel=0 DScale=0 PME-
	Capabilities: [90] Vendor Specific Information: Len=14 <?>
	Kernel driver in use: intel-lpss

0000:00:19.0 Serial bus controller: Intel Corporation Alder Lake-P Serial IO I2C Controller #0 (rev 01)
	Subsystem: Acer Incorporated [ALI] Device 161d
	Control: I/O- Mem+ BusMaster+ SpecCycle- MemWINV- VGASnoop- ParErr- Stepping- SERR- FastB2B- DisINTx-
	Status: Cap+ 66MHz- UDF- FastB2B- ParErr- DEVSEL=fast >TAbort- <TAbort- <MAbort- >SERR- <PERR- INTx-
	Latency: 0, Cache Line Size: 64 bytes
	Interrupt: pin A routed to IRQ 31
	IOMMU group: 13
	Region 0: Memory at 4017002000 (64-bit, non-prefetchable) [size=4K]
	Capabilities: [80] Power Management version 3
		Flags: PMEClk- DSI- D1- D2- AuxCurrent=0mA PME(D0-,D1-,D2-,D3hot-,D3cold-)
		Status: D3 NoSoftRst+ PME-Enable- DSel=0 DScale=0 PME-
	Capabilities: [90] Vendor Specific Information: Len=14 <?>
	Kernel driver in use: intel-lpss

0000:00:19.1 Serial bus controller: Intel Corporation Alder Lake-P Serial IO I2C Controller #1 (rev 01)
	Subsystem: Acer Incorporated [ALI] Device 161d
	Control: I/O- Mem+ BusMaster+ SpecCycle- MemWINV- VGASnoop- ParErr- Stepping- SERR- FastB2B- DisINTx-
	Status: Cap+ 66MHz- UDF- FastB2B- ParErr- DEVSEL=fast >TAbort- <TAbort- <MAbort- >SERR- <PERR- INTx-
	Latency: 0, Cache Line Size: 64 bytes
	Interrupt: pin B routed to IRQ 32
	IOMMU group: 13
	Region 0: Memory at 4017003000 (64-bit, non-prefetchable) [virtual] [size=4K]
	Capabilities: [80] Power Management version 3
		Flags: PMEClk- DSI- D1- D2- AuxCurrent=0mA PME(D0-,D1-,D2-,D3hot-,D3cold-)
		Status: D3 NoSoftRst+ PME-Enable- DSel=0 DScale=0 PME-
	Capabilities: [90] Vendor Specific Information: Len=14 <?>
	Kernel driver in use: intel-lpss

0000:00:1f.4 SMBus: Intel Corporation Alder Lake PCH-P SMBus Host Controller (rev 01)
	Subsystem: Acer Incorporated [ALI] Device 161d
	Control: I/O+ Mem+ BusMaster- SpecCycle- MemWINV- VGASnoop- ParErr- Stepping- SERR- FastB2B- DisINTx-
	Status: Cap- 66MHz- UDF- FastB2B+ ParErr- DEVSEL=medium >TAbort- <TAbort- <MAbort- >SERR- <PERR- INTx-
	Interrupt: pin A routed to IRQ 16
	IOMMU group: 15
	Region 0: Memory at 601f27c000 (64-bit, non-prefetchable) [size=256]
	Region 4: I/O ports at efa0 [size=32]
	Kernel driver in use: i801_smbus
	Kernel modules: i2c_i801

View: https://bugzilla.kernel.org/show_bug.cgi?id=220056#c20
You can reply to this message to join the discussion.
-- 
Deet-doot-dot, I am a bot.
Kernel.org Bugzilla (bugspray 0.1-dev)

Re: PixArt touchpad not detected due to wrong pinctrl

[Andy Shevchenko via Bugspray Bot]

Andy Shevchenko writes via Kernel.org Bugzilla:

(In reply to Guido Trentalancia from comment #20)
> The chipset is Alderlake-P as already said in
> https://bugzilla.kernel.org/show_bug.cgi?id=220056#c12
> 
> The issue is resolved by applying the patch from Ariel or by using the
> Tigerlake pinctrl kernel module, although I believe the latter approach is
> the wrong solution.

No, that is the right solution. And I have no idea how the patch can solve it. You are really driving me crazy. I already explained to you how device is enumerated, the patch CAN NOT FIX ANYTHING.

> Some relevant system information follows. Please provide the link to the
> relevant official Intel PCH I2C specifications.

You have Alder Lake-P that re-uses Tiger Lake pin control IP. So, what's the problem (except documentation)? The resolution of this bug is correct, i.e. RESOLVED INVALID.

It seems that official specifications are confidential, but in any case, search for these documents.

https://www.intel.com/content/www/us/en/secure/content-details/626817/intel-600-series-chipset-family-and-intel-700-series-chipset-family-on-package-platform-controller-hub-pch-external-design-specification-volume-1-of-2.html?DocID=626817

https://www.intel.com/content/www/us/en/secure/content-details/630094/intel-600-series-and-intel-700-series-chipset-family-on-package-platform-controller-hub-pch-external-design-specification-volume-2-of-2.html?wapkw=630094&DocID=630094

...

> [cat /proc/interrupts] ** with patch applied **

I don't believe that patch solves anything. Check the `lsmod` output and other things, but it's impossible that this patch solves the problem. And again, it makes really wrong, there are no such pins in Alder Lake-N/S supported platforms.

View: https://bugzilla.kernel.org/show_bug.cgi?id=220056#c21
You can reply to this message to join the discussion.
-- 
Deet-doot-dot, I am a bot.
Kernel.org Bugzilla (bugspray 0.1-dev)

Re: PixArt touchpad not detected due to wrong pinctrl

[Guido Trentalancia via Bugspray Bot]

Guido Trentalancia writes via Kernel.org Bugzilla:

After further testing I can now confirm that the patch from Ariel does not resolve the issue and that adding CONFIG_PINCTRL_TIGERLAKE is the only possible solution so far.

Should CONFIG_PINCTRL_ALDERLAKE be disabled ?

Thanks for the links Andy, but I am not interested in accessing confidential information and in any case those links require a login which I am not interested in creating.

However, I believe the specifications should be made public, at the end users pay for their hardware.

View: https://bugzilla.kernel.org/show_bug.cgi?id=220056#c22
You can reply to this message to join the discussion.
-- 
Deet-doot-dot, I am a bot.
Kernel.org Bugzilla (bugspray 0.1-dev)

Re: PixArt touchpad not detected due to wrong pinctrl

[Andy Shevchenko via Bugspray Bot]

Andy Shevchenko writes via Kernel.org Bugzilla:

(In reply to Guido Trentalancia from comment #22)
> After further testing I can now confirm that the patch from Ariel does not
> resolve the issue and that adding CONFIG_PINCTRL_TIGERLAKE is the only
> possible solution so far.

Thank you for confirming this. I will prepare a documentation patch based on this bug report.

> Should CONFIG_PINCTRL_ALDERLAKE be disabled ?

Up to you. It it's harmless on your platform, but it takes resources passively (as memory footprint) and actively (as each boot is slightly delayed).

> Thanks for the links Andy, but I am not interested in accessing confidential
> information and in any case those links require a login which I am not
> interested in creating.
> 
> However, I believe the specifications should be made public, at the end
> users pay for their hardware.

I'm an engineer, I have no rights or even knowledge in the laywers' area. What I know that EDS is what all Intel customers (read: OEMs/ODMs) get with a chip they bought.

View: https://bugzilla.kernel.org/show_bug.cgi?id=220056#c23
You can reply to this message to join the discussion.
-- 
Deet-doot-dot, I am a bot.
Kernel.org Bugzilla (bugspray 0.1-dev)

Re: PixArt touchpad not detected due to wrong pinctrl

[Ariel Simulevski via Bugspray Bot]

Ariel Simulevski writes via Kernel.org Bugzilla:

Hi Andy,

Would it be okay if I prepare the documentation patch?  
I’d love to use this as a learning opportunity.

Thanks!

View: https://bugzilla.kernel.org/show_bug.cgi?id=220056#c24
You can reply to this message to join the discussion.
-- 
Deet-doot-dot, I am a bot.
Kernel.org Bugzilla (bugspray 0.1-dev)

Re: PixArt touchpad not detected due to wrong pinctrl

[Andy Shevchenko via Bugspray Bot]

Andy Shevchenko writes via Kernel.org Bugzilla:

(In reply to Ariel Simulevski from comment #24)
> Hi Andy,
> 
> Would it be okay if I prepare the documentation patch?  
> I’d love to use this as a learning opportunity.

Sure, it's low priority for me, so you have your time (a week or a couple of weeks) for that. Note, if you wish, you can also investigate other drivers that support more than one generation of the chipsets.

View: https://bugzilla.kernel.org/show_bug.cgi?id=220056#c25
You can reply to this message to join the discussion.
-- 
Deet-doot-dot, I am a bot.
Kernel.org Bugzilla (bugspray 0.1-dev)