From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f49.google.com (mail-wm1-f49.google.com [209.85.128.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 334F12701A7 for ; Tue, 6 May 2025 09:02:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746522126; cv=none; b=hgjwxSaN5knhJ0w49dK3lqV53oSs1rpa6GdQzsK/lq0kdQDx/pietYqKQvjDrw1jKFOrDy69zK88NNj9IHkhqgzrt2EWKGEDJc6/HU1eJ/WeOaTJtAVK1Oz5j3j/H65Z0MCKLCgPOcxT60HsYmt5BOgPCdJCQq6ECcjWI6LyrXg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746522126; c=relaxed/simple; bh=JFsmM57P/O8V67mF5am73nGzAoBwKLj9GVKn594zJu8=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=Vt0o21ywFiitjm8C25NOi6s97ZByGBXbOkAaJ1vZbZNauxT6f4vn0dbGBKuh9zATwt4nV2z0szkSnZIKz+jcpgcPmKEKNBgI6T1CBystRX0a0zRc/XB8BbppPI53LB8Z1e+91pCZXIRoUpHLilwWYl7cTIQigppu1icfjUeRdDY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=KiqDPwVr; arc=none smtp.client-ip=209.85.128.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="KiqDPwVr" Received: by mail-wm1-f49.google.com with SMTP id 5b1f17b1804b1-43cebe06e9eso33584835e9.3 for ; Tue, 06 May 2025 02:02:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1746522122; x=1747126922; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=RViy5sXSyCVllDQ7MtbJFUrGShqaZa6Mlg+17kGovwY=; b=KiqDPwVr/bqGRBpancIeuMJGK33ys3EC+5/gGnOiTmzlKk/K0VYeX8kgo15qFTHhay XgrnqhGnrGrcPS4vDQJIcAySVa5p4pWN2E5hnB7ov0rSYp4Wp/EY7rRjqs+iqQPE++SG 8ZgvX2KGamktM4UK8AFz6Xm8wW+c1ro3KZYWC2QVVLqk1oxY2m7GsazjDHbdztfVOv1M tfT3Wlk0ROfCqBdcLzQlHivmYF1tlNyubmTaTg5pecI2t851kYxHjpgO6AIEJuaU0+3g jTpSOOw36aJTgwyrIlR4gzkA1KMEWDEStMTx3VbLwt6eQ/DZ/rjbAMXAsT66LffXiF5T gFTg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1746522122; x=1747126922; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=RViy5sXSyCVllDQ7MtbJFUrGShqaZa6Mlg+17kGovwY=; b=M7pn3o2aDTWlTYkFcsWH87NabnypM4LDrK96ZcVj62sMSZ1t8zK9K5HCmgSKbnOoTJ Z9wNYHsNkh6MviMQVX70AK9Bc36hui4xsMzYUFTLP9GxBncITAxCz0Zx1jYAYFnIB2ZF o3Jd+m91TpzGZkm9adO+sJ+HtwpRaf3pRWhAxmzZCscVxlq69eAQJuIn/bVQxnjOGypv YwB/HJ9bKsUwFKXxVm99pOaDddVwXVUQ4BsvkhaYBcKyzjj1OLjA5HXkADfcg1vGyiN3 4Jbk5j4lgNrjxpg0Cyf4hRCq+gt9dcEaoN1UrpHDdaWfePewnxrKKaz4vbQDgJiuQk8w w1Ng== X-Gm-Message-State: AOJu0YwcdQQdRaQ2nY01lJmcn7Fcr1QqnVoszF5RWurWZVmr2QPxLvmx 565CWC/gAdABmgly0AsqbzY+SfT42MCwytmr3tUpd5uHEHu69A5mAcPUY1nTDsU= X-Gm-Gg: ASbGnctpoU2oOpyfrEuCRmIrBwkUoA0Ta/EzgFXEZmxA2ODpHb1QeKAyMXp/ps4F/PW aUAfIYK1C6Eusm4LTt2hmQQ5BfdLaLGsJxo6OhlQlqkcFO1pH4a3WoxCsDOCg6L1f4/EpA63atN w9tfPTljQ0rFcVF2dXSXHLhpIGBTZ4/Hm8/Sp8t/MvNWc8G9M72R3eFILBLIaH6bCne6Euc/ptU kzYR9UIRVdb/MY4L88evbZKgUmvf8CffO/OAjnbPyBofKHN9hVusnLL6TAXPP3UjYxAlwW9EWaQ eq9iOEQ9pPmyPoPkncosBtNoOKCJ53blHo8= X-Google-Smtp-Source: AGHT+IGdutjQDLWY4nxQmqNnyyXxS0dNKsu0ias92lCYMh/g/yYLkvUyWFqlVczz1tB/yWiChJXrVg== X-Received: by 2002:a05:600c:1c9b:b0:440:54ef:dfdc with SMTP id 5b1f17b1804b1-441d04fe785mr18148395e9.8.1746522122499; Tue, 06 May 2025 02:02:02 -0700 (PDT) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:bfd0:3ad7:fd8a:fe95]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-441bc83d471sm138125725e9.26.2025.05.06.02.02.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 May 2025 02:02:02 -0700 (PDT) From: Bartosz Golaszewski Date: Tue, 06 May 2025 11:01:52 +0200 Subject: [PATCH 09/12] gpio: max77620: use new GPIO line value setter callbacks Precedence: bulk X-Mailing-List: linux-gpio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20250506-gpiochip-set-rv-gpio-part3-v1-9-0fbdea5a9667@linaro.org> References: <20250506-gpiochip-set-rv-gpio-part3-v1-0-0fbdea5a9667@linaro.org> In-Reply-To: <20250506-gpiochip-set-rv-gpio-part3-v1-0-0fbdea5a9667@linaro.org> To: Linus Walleij , Bartosz Golaszewski , Vladimir Zapolskiy , Piotr Wojtaszczyk , Charles Keepax , Richard Fitzgerald , Andy Shevchenko Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sound@vger.kernel.org, patches@opensource.cirrus.com, Bartosz Golaszewski X-Mailer: b4 0.14.1 X-Developer-Signature: v=1; a=openpgp-sha256; l=1910; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=N25xpJo8Wn4hKIWS80X1OeMM9GyN+r2jXu3hvoWtCc0=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBoGc//2ujX9nyCkowWcEn/X2y1T3zJBYnvdxiIf DI/74eJ1XSJAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCaBnP/wAKCRARpy6gFHHX cglrD/9d2BqfRFTo/ZvbXdSOrxA5s7AwPuYI4BfypgQhHVodS2YDBzc38ssqw2XFiZLwZWBz3H1 yT5wAUAQQWE5s9wPYMUmf1RoawcD7o1WoJQHOR8SBDCgNxqt6AAw5p3Upal0icQAj1onotwcC42 oNnVxsffJn0EcIybOmVUS3TyWy//M9EPvurNHwQ1vHB57HsRCTqVyhlAVuSKDpPsUVQgJArFX/I 24hJt5bDP3QjFBrYQdhuHUdaAT7Mebw5Pf8e2tAfjCmsWaVwl0B7Q/0lx+ER809GOfvtwmlr6dr e8+bhQwIDDfkfDahHnGbsvEpeFgNvweIilQIyD9TWa6E0gO9dF4Wt3MZBAbTlAXXLDIt9zvBDiV FHzaje/uSGCjxE9b56QumVVPfB/u60CwCfAGv30O1Ftc8Nlm+t7vPOHzSuCLvIwVIq0uBgCdXTx 6vSsM1FOpiW8Wpxh1AVdHMAWNGJjhOMCjA9P/qc9UixgIihxDtU8XCvCGxjWNUkc3ozxh6LzXGz tRO2yeelJaxSePVRjF+pIuA7t4GLAlbuH7QCABaWhi9/cQI2fv557qemD5P1yTrLqvVyKzQP6fq lYkOBAWGLMIM+8AHGQ+5CXXpTGrzzE5LP/N0ABm64t1B3Uzn5AJ0cpN5WBiA5KuY61hBME/RAxd hntlJwr9tShuI5g== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 From: Bartosz Golaszewski struct gpio_chip now has callbacks for setting line values that return an integer, allowing to indicate failures. Convert the driver to using them. Signed-off-by: Bartosz Golaszewski --- drivers/gpio/gpio-max77620.c | 13 +++++-------- 1 file changed, 5 insertions(+), 8 deletions(-) diff --git a/drivers/gpio/gpio-max77620.c b/drivers/gpio/gpio-max77620.c index 8c2a5609161fd..af7af8e40afe4 100644 --- a/drivers/gpio/gpio-max77620.c +++ b/drivers/gpio/gpio-max77620.c @@ -223,20 +223,17 @@ static int max77620_gpio_set_debounce(struct max77620_gpio *mgpio, return ret; } -static void max77620_gpio_set(struct gpio_chip *gc, unsigned int offset, - int value) +static int max77620_gpio_set(struct gpio_chip *gc, unsigned int offset, + int value) { struct max77620_gpio *mgpio = gpiochip_get_data(gc); u8 val; - int ret; val = (value) ? MAX77620_CNFG_GPIO_OUTPUT_VAL_HIGH : MAX77620_CNFG_GPIO_OUTPUT_VAL_LOW; - ret = regmap_update_bits(mgpio->rmap, GPIO_REG_ADDR(offset), - MAX77620_CNFG_GPIO_OUTPUT_VAL_MASK, val); - if (ret < 0) - dev_err(mgpio->dev, "CNFG_GPIO_OUT update failed: %d\n", ret); + return regmap_update_bits(mgpio->rmap, GPIO_REG_ADDR(offset), + MAX77620_CNFG_GPIO_OUTPUT_VAL_MASK, val); } static int max77620_gpio_set_config(struct gpio_chip *gc, unsigned int offset, @@ -314,7 +311,7 @@ static int max77620_gpio_probe(struct platform_device *pdev) mgpio->gpio_chip.direction_input = max77620_gpio_dir_input; mgpio->gpio_chip.get = max77620_gpio_get; mgpio->gpio_chip.direction_output = max77620_gpio_dir_output; - mgpio->gpio_chip.set = max77620_gpio_set; + mgpio->gpio_chip.set_rv = max77620_gpio_set; mgpio->gpio_chip.set_config = max77620_gpio_set_config; mgpio->gpio_chip.ngpio = MAX77620_GPIO_NR; mgpio->gpio_chip.can_sleep = 1; -- 2.45.2