From: Gabor Juhos <j4g8y7@gmail.com>
To: Andrew Lunn <andrew@lunn.ch>,
Gregory Clement <gregory.clement@bootlin.com>,
Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>,
Linus Walleij <linus.walleij@linaro.org>,
Bartosz Golaszewski <brgl@bgdev.pl>
Cc: linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org,
linux-kernel@vger.kernel.org, Gabor Juhos <j4g8y7@gmail.com>,
stable@vger.kernel.org, Imre Kaloz <kaloz@openwrt.org>
Subject: [PATCH 6/7] pinctrl: armada-37xx: propagate error from armada_37xx_gpio_get_direction()
Date: Mon, 12 May 2025 16:22:42 +0200 [thread overview]
Message-ID: <20250512-pinctrl-a37xx-fixes-v1-6-d470fb1116a5@gmail.com> (raw)
In-Reply-To: <20250512-pinctrl-a37xx-fixes-v1-0-d470fb1116a5@gmail.com>
The regmap_read() function can fail, so propagate its error up to
the stack instead of silently ignoring that.
Cc: stable@vger.kernel.org
Fixes: 5715092a458c ("pinctrl: armada-37xx: Add gpio support")
Signed-off-by: Gabor Juhos <j4g8y7@gmail.com>
Signed-off-by: Imre Kaloz <kaloz@openwrt.org>
---
drivers/pinctrl/mvebu/pinctrl-armada-37xx.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/pinctrl/mvebu/pinctrl-armada-37xx.c b/drivers/pinctrl/mvebu/pinctrl-armada-37xx.c
index aed0069b085ced5867993e95e0244df7ccda556d..18c6c5026b26c294ee65e3deea02d2e852e10622 100644
--- a/drivers/pinctrl/mvebu/pinctrl-armada-37xx.c
+++ b/drivers/pinctrl/mvebu/pinctrl-armada-37xx.c
@@ -402,10 +402,13 @@ static int armada_37xx_gpio_get_direction(struct gpio_chip *chip,
struct armada_37xx_pinctrl *info = gpiochip_get_data(chip);
unsigned int reg = OUTPUT_EN;
unsigned int val, mask;
+ int ret;
armada_37xx_update_reg(®, &offset);
mask = BIT(offset);
- regmap_read(info->regmap, reg, &val);
+ ret = regmap_read(info->regmap, reg, &val);
+ if (ret)
+ return ret;
if (val & mask)
return GPIO_LINE_DIRECTION_OUT;
--
2.49.0
next prev parent reply other threads:[~2025-05-12 14:23 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-12 14:22 [PATCH 0/7] pinctrl: armada-37xx: a couple of small fixes Gabor Juhos
2025-05-12 14:22 ` [PATCH 1/7] pinctrl: armada-37xx: use correct OUTPUT_VAL register for GPIOs > 31 Gabor Juhos
2025-05-12 21:28 ` Andrew Lunn
2025-05-12 14:22 ` [PATCH 2/7] pinctrl: armada-37xx: propagate error from armada_37xx_gpio_direction_output() Gabor Juhos
2025-05-12 21:29 ` Andrew Lunn
2025-05-12 14:22 ` [PATCH 3/7] pinctrl: armada-37xx: set GPIO output value before setting direction Gabor Juhos
2025-05-12 21:30 ` Andrew Lunn
2025-05-12 14:22 ` [PATCH 4/7] pinctrl: armada-37xx: propagate error from armada_37xx_gpio_get() Gabor Juhos
2025-05-12 21:31 ` Andrew Lunn
2025-05-12 14:22 ` [PATCH 5/7] pinctrl: armada-37xx: propagate error from armada_37xx_pmx_gpio_set_direction() Gabor Juhos
2025-05-12 21:31 ` [PATCH 5/7] pinctrl: armada-37xx: propagate error from armada_37xx_pmx_gpio_set_direction()' Andrew Lunn
2025-05-12 14:22 ` Gabor Juhos [this message]
2025-05-12 21:31 ` [PATCH 6/7] pinctrl: armada-37xx: propagate error from armada_37xx_gpio_get_direction() Andrew Lunn
2025-05-12 14:22 ` [PATCH 7/7] pinctrl: armada-37xx: propagate error from armada_37xx_pmx_set_by_name() Gabor Juhos
2025-05-12 21:32 ` Andrew Lunn
2025-05-12 21:33 ` [PATCH 0/7] pinctrl: armada-37xx: a couple of small fixes Andrew Lunn
2025-05-13 13:36 ` Linus Walleij
2025-05-13 16:51 ` Gabor Juhos
2025-05-13 18:46 ` Andrew Lunn
2025-05-13 19:24 ` Gabor Juhos
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250512-pinctrl-a37xx-fixes-v1-6-d470fb1116a5@gmail.com \
--to=j4g8y7@gmail.com \
--cc=andrew@lunn.ch \
--cc=brgl@bgdev.pl \
--cc=gregory.clement@bootlin.com \
--cc=kaloz@openwrt.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sebastian.hesselbarth@gmail.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).