* [PATCH 6/9] dt-bindings: gpio: rockchip: Allow use of a power-domain
[not found] <20250518220707.669515-1-jonas@kwiboo.se>
@ 2025-05-18 22:06 ` Jonas Karlman
2025-05-27 19:34 ` Rob Herring
0 siblings, 1 reply; 3+ messages in thread
From: Jonas Karlman @ 2025-05-18 22:06 UTC (permalink / raw)
To: Heiko Stuebner, Ulf Hansson, Linus Walleij, Bartosz Golaszewski,
Rob Herring, Krzysztof Kozlowski, Conor Dooley
Cc: Yao Zi, Chukun Pan, linux-rockchip, linux-pm, devicetree,
linux-arm-kernel, Jonas Karlman, linux-gpio, linux-kernel
The GPIO controllers in most Rockchip SoCs are part or power domains
that are always powered on, i.e. PD_BUS or PD_PMU.
On RK3528 the GPIO controllers are spread out among the PD_RKVENC, PD_VO
and PD_VPU power domains.
Add support to describe power-domains for the GPIO controllers.
Signed-off-by: Jonas Karlman <jonas@kwiboo.se>
---
Documentation/devicetree/bindings/gpio/rockchip,gpio-bank.yaml | 3 +++
1 file changed, 3 insertions(+)
diff --git a/Documentation/devicetree/bindings/gpio/rockchip,gpio-bank.yaml b/Documentation/devicetree/bindings/gpio/rockchip,gpio-bank.yaml
index d76987ce8e50..bdd83f42615c 100644
--- a/Documentation/devicetree/bindings/gpio/rockchip,gpio-bank.yaml
+++ b/Documentation/devicetree/bindings/gpio/rockchip,gpio-bank.yaml
@@ -41,6 +41,9 @@ properties:
"#interrupt-cells":
const: 2
+ power-domains:
+ maxItems: 1
+
patternProperties:
"^.+-hog(-[0-9]+)?$":
type: object
--
2.49.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 6/9] dt-bindings: gpio: rockchip: Allow use of a power-domain
2025-05-18 22:06 ` [PATCH 6/9] dt-bindings: gpio: rockchip: Allow use of a power-domain Jonas Karlman
@ 2025-05-27 19:34 ` Rob Herring
2025-06-21 18:23 ` Jonas Karlman
0 siblings, 1 reply; 3+ messages in thread
From: Rob Herring @ 2025-05-27 19:34 UTC (permalink / raw)
To: Jonas Karlman
Cc: Heiko Stuebner, Ulf Hansson, Linus Walleij, Bartosz Golaszewski,
Krzysztof Kozlowski, Conor Dooley, Yao Zi, Chukun Pan,
linux-rockchip, linux-pm, devicetree, linux-arm-kernel,
linux-gpio, linux-kernel
On Sun, May 18, 2025 at 10:06:53PM +0000, Jonas Karlman wrote:
> The GPIO controllers in most Rockchip SoCs are part or power domains
> that are always powered on, i.e. PD_BUS or PD_PMU.
Are these described in DT, so this is valid to add for all SoCs?
> On RK3528 the GPIO controllers are spread out among the PD_RKVENC, PD_VO
> and PD_VPU power domains.
So should be required for RK3528?
>
> Add support to describe power-domains for the GPIO controllers.
>
> Signed-off-by: Jonas Karlman <jonas@kwiboo.se>
> ---
> Documentation/devicetree/bindings/gpio/rockchip,gpio-bank.yaml | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/gpio/rockchip,gpio-bank.yaml b/Documentation/devicetree/bindings/gpio/rockchip,gpio-bank.yaml
> index d76987ce8e50..bdd83f42615c 100644
> --- a/Documentation/devicetree/bindings/gpio/rockchip,gpio-bank.yaml
> +++ b/Documentation/devicetree/bindings/gpio/rockchip,gpio-bank.yaml
> @@ -41,6 +41,9 @@ properties:
> "#interrupt-cells":
> const: 2
>
> + power-domains:
> + maxItems: 1
> +
> patternProperties:
> "^.+-hog(-[0-9]+)?$":
> type: object
> --
> 2.49.0
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 6/9] dt-bindings: gpio: rockchip: Allow use of a power-domain
2025-05-27 19:34 ` Rob Herring
@ 2025-06-21 18:23 ` Jonas Karlman
0 siblings, 0 replies; 3+ messages in thread
From: Jonas Karlman @ 2025-06-21 18:23 UTC (permalink / raw)
To: Rob Herring
Cc: Heiko Stuebner, Ulf Hansson, Linus Walleij, Bartosz Golaszewski,
Krzysztof Kozlowski, Conor Dooley, Yao Zi, Chukun Pan,
linux-rockchip@lists.infradead.org, linux-pm@vger.kernel.org,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org
Hi Rob,
On 2025-05-27 21:34, Rob Herring wrote:
> On Sun, May 18, 2025 at 10:06:53PM +0000, Jonas Karlman wrote:
>> The GPIO controllers in most Rockchip SoCs are part or power domains
>> that are always powered on, i.e. PD_BUS or PD_PMU.
>
> Are these described in DT, so this is valid to add for all SoCs?
PD_BUS and PD_PMU for prior generation Rockchip SoCs has typically not
been fully described in device tree. Probably because they always needs
to be powered on or missing documentation.
>
>> On RK3528 the GPIO controllers are spread out among the PD_RKVENC, PD_VO
>> and PD_VPU power domains.
>
> So should be required for RK3528?
One of the five GPIO controllers on RK3528 is part of a power domain not
being described in the device tree. And without having access to any TRM
or other documentation it probably wont be. So requiring for RK3528 is
not fully possible, and for GPIO controllers in other Rockchip SoCs the
power-domain could theoretically be described in device tree.
Regards,
Jonas
>
>>
>> Add support to describe power-domains for the GPIO controllers.
>>
>> Signed-off-by: Jonas Karlman <jonas@kwiboo.se>
>> ---
>> Documentation/devicetree/bindings/gpio/rockchip,gpio-bank.yaml | 3 +++
>> 1 file changed, 3 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/gpio/rockchip,gpio-bank.yaml b/Documentation/devicetree/bindings/gpio/rockchip,gpio-bank.yaml
>> index d76987ce8e50..bdd83f42615c 100644
>> --- a/Documentation/devicetree/bindings/gpio/rockchip,gpio-bank.yaml
>> +++ b/Documentation/devicetree/bindings/gpio/rockchip,gpio-bank.yaml
>> @@ -41,6 +41,9 @@ properties:
>> "#interrupt-cells":
>> const: 2
>>
>> + power-domains:
>> + maxItems: 1
>> +
>> patternProperties:
>> "^.+-hog(-[0-9]+)?$":
>> type: object
>> --
>> 2.49.0
>>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-06-21 18:23 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20250518220707.669515-1-jonas@kwiboo.se>
2025-05-18 22:06 ` [PATCH 6/9] dt-bindings: gpio: rockchip: Allow use of a power-domain Jonas Karlman
2025-05-27 19:34 ` Rob Herring
2025-06-21 18:23 ` Jonas Karlman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).