linux-gpio.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Bartosz Golaszewski <brgl@bgdev.pl>
To: "Linus Walleij" <linus.walleij@linaro.org>,
	"Bartosz Golaszewski" <brgl@bgdev.pl>,
	"Marek Behún" <kabel@kernel.org>,
	"Conor Dooley" <conor.dooley@microchip.com>,
	"Daire McNamara" <daire.mcnamara@microchip.com>,
	"Daniel Palmer" <daniel@thingy.jp>,
	"Romain Perier" <romain.perier@gmail.com>,
	"Avi Fishman" <avifishman70@gmail.com>,
	"Tomer Maimon" <tmaimon77@gmail.com>,
	"Tali Perry" <tali.perry1@gmail.com>,
	"Patrick Venture" <venture@google.com>,
	"Nancy Yuen" <yuenn@google.com>,
	"Benjamin Fair" <benjaminfair@google.com>,
	"Grygorii Strashko" <grygorii.strashko@ti.com>,
	"Santosh Shilimkar" <ssantosh@kernel.org>,
	"Kevin Hilman" <khilman@kernel.org>
Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
	 linux-riscv@lists.infradead.org,
	linux-arm-kernel@lists.infradead.org,  openbmc@lists.ozlabs.org,
	linux-omap@vger.kernel.org,
	 Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
Subject: [PATCH 11/12] gpio: omap: use new GPIO line value setter callbacks
Date: Tue, 10 Jun 2025 14:33:21 +0200	[thread overview]
Message-ID: <20250610-gpiochip-set-rv-gpio-v1-11-3a9a3c1472ff@linaro.org> (raw)
In-Reply-To: <20250610-gpiochip-set-rv-gpio-v1-0-3a9a3c1472ff@linaro.org>

From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>

struct gpio_chip now has callbacks for setting line values that return
an integer, allowing to indicate failures. Convert the driver to using
them.

Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
---
 drivers/gpio/gpio-omap.c | 14 +++++++++-----
 1 file changed, 9 insertions(+), 5 deletions(-)

diff --git a/drivers/gpio/gpio-omap.c b/drivers/gpio/gpio-omap.c
index 54c4bfdccf56812b5f79435a97b6eb90904ca59c..ed5c88a5c5207063e1269763e6239441a42e0c3d 100644
--- a/drivers/gpio/gpio-omap.c
+++ b/drivers/gpio/gpio-omap.c
@@ -953,7 +953,7 @@ static int omap_gpio_set_config(struct gpio_chip *chip, unsigned offset,
 	return ret;
 }
 
-static void omap_gpio_set(struct gpio_chip *chip, unsigned offset, int value)
+static int omap_gpio_set(struct gpio_chip *chip, unsigned int offset, int value)
 {
 	struct gpio_bank *bank;
 	unsigned long flags;
@@ -962,10 +962,12 @@ static void omap_gpio_set(struct gpio_chip *chip, unsigned offset, int value)
 	raw_spin_lock_irqsave(&bank->lock, flags);
 	bank->set_dataout(bank, offset, value);
 	raw_spin_unlock_irqrestore(&bank->lock, flags);
+
+	return 0;
 }
 
-static void omap_gpio_set_multiple(struct gpio_chip *chip, unsigned long *mask,
-				   unsigned long *bits)
+static int omap_gpio_set_multiple(struct gpio_chip *chip, unsigned long *mask,
+				  unsigned long *bits)
 {
 	struct gpio_bank *bank = gpiochip_get_data(chip);
 	void __iomem *reg = bank->base + bank->regs->dataout;
@@ -977,6 +979,8 @@ static void omap_gpio_set_multiple(struct gpio_chip *chip, unsigned long *mask,
 	writel_relaxed(l, reg);
 	bank->context.dataout = l;
 	raw_spin_unlock_irqrestore(&bank->lock, flags);
+
+	return 0;
 }
 
 /*---------------------------------------------------------------------*/
@@ -1042,8 +1046,8 @@ static int omap_gpio_chip_init(struct gpio_bank *bank, struct device *pm_dev)
 	bank->chip.get_multiple = omap_gpio_get_multiple;
 	bank->chip.direction_output = omap_gpio_output;
 	bank->chip.set_config = omap_gpio_set_config;
-	bank->chip.set = omap_gpio_set;
-	bank->chip.set_multiple = omap_gpio_set_multiple;
+	bank->chip.set_rv = omap_gpio_set;
+	bank->chip.set_multiple_rv = omap_gpio_set_multiple;
 	if (bank->is_mpuio) {
 		bank->chip.label = "mpuio";
 		if (bank->regs->wkup_en)

-- 
2.48.1


  parent reply	other threads:[~2025-06-10 12:33 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-10 12:33 [PATCH 00/12] gpio: convert another round of GPIO drivers to using new line value setters Bartosz Golaszewski
2025-06-10 12:33 ` [PATCH 01/12] gpio: mmio: use new GPIO line value setter callbacks Bartosz Golaszewski
2025-06-10 21:16   ` Linus Walleij
2025-06-18 11:59   ` Klara Modin
2025-06-18 12:34     ` Bartosz Golaszewski
2025-06-18 16:21   ` Mark Brown
2025-06-18 16:24     ` Bartosz Golaszewski
     [not found]   ` <CGME20250618164320eucas1p28174732f38fd279fbba72f07887e5da5@eucas1p2.samsung.com>
2025-06-18 16:43     ` Marek Szyprowski
2025-06-18 17:00       ` Bartosz Golaszewski
2025-06-10 12:33 ` [PATCH 02/12] gpio: mm-lantiq: " Bartosz Golaszewski
2025-06-10 22:01   ` Linus Walleij
2025-06-10 12:33 ` [PATCH 03/12] gpio: moxtet: " Bartosz Golaszewski
2025-06-13 14:40   ` Marek Behún
2025-06-10 12:33 ` [PATCH 04/12] gpio: mpc5200: " Bartosz Golaszewski
2025-06-10 12:33 ` [PATCH 05/12] gpio: mpfs: " Bartosz Golaszewski
2025-06-10 12:33 ` [PATCH 06/12] gpio: mpsse: " Bartosz Golaszewski
2025-06-10 12:33 ` [PATCH 07/12] gpio: msc313: " Bartosz Golaszewski
2025-06-11 22:21   ` Daniel Palmer
2025-06-10 12:33 ` [PATCH 08/12] gpio: nomadik: " Bartosz Golaszewski
2025-06-10 22:06   ` Linus Walleij
2025-06-10 12:33 ` [PATCH 09/12] gpio: npcm-sgpio: " Bartosz Golaszewski
2025-06-10 12:33 ` [PATCH 10/12] gpio: octeon: " Bartosz Golaszewski
2025-06-10 12:33 ` Bartosz Golaszewski [this message]
2025-06-10 12:33 ` [PATCH 12/12] gpio: palmas: " Bartosz Golaszewski
2025-06-17  9:14 ` [PATCH 00/12] gpio: convert another round of GPIO drivers to using new line value setters Bartosz Golaszewski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250610-gpiochip-set-rv-gpio-v1-11-3a9a3c1472ff@linaro.org \
    --to=brgl@bgdev.pl \
    --cc=avifishman70@gmail.com \
    --cc=bartosz.golaszewski@linaro.org \
    --cc=benjaminfair@google.com \
    --cc=conor.dooley@microchip.com \
    --cc=daire.mcnamara@microchip.com \
    --cc=daniel@thingy.jp \
    --cc=grygorii.strashko@ti.com \
    --cc=kabel@kernel.org \
    --cc=khilman@kernel.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=linux-riscv@lists.infradead.org \
    --cc=openbmc@lists.ozlabs.org \
    --cc=romain.perier@gmail.com \
    --cc=ssantosh@kernel.org \
    --cc=tali.perry1@gmail.com \
    --cc=tmaimon77@gmail.com \
    --cc=venture@google.com \
    --cc=yuenn@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).