From: Bartosz Golaszewski <brgl@bgdev.pl>
To: "Linus Walleij" <linus.walleij@linaro.org>,
"Bartosz Golaszewski" <brgl@bgdev.pl>,
"Marek Behún" <kabel@kernel.org>,
"Conor Dooley" <conor.dooley@microchip.com>,
"Daire McNamara" <daire.mcnamara@microchip.com>,
"Daniel Palmer" <daniel@thingy.jp>,
"Romain Perier" <romain.perier@gmail.com>,
"Avi Fishman" <avifishman70@gmail.com>,
"Tomer Maimon" <tmaimon77@gmail.com>,
"Tali Perry" <tali.perry1@gmail.com>,
"Patrick Venture" <venture@google.com>,
"Nancy Yuen" <yuenn@google.com>,
"Benjamin Fair" <benjaminfair@google.com>,
"Grygorii Strashko" <grygorii.strashko@ti.com>,
"Santosh Shilimkar" <ssantosh@kernel.org>,
"Kevin Hilman" <khilman@kernel.org>
Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-riscv@lists.infradead.org,
linux-arm-kernel@lists.infradead.org, openbmc@lists.ozlabs.org,
linux-omap@vger.kernel.org,
Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
Subject: [PATCH 09/12] gpio: npcm-sgpio: use new GPIO line value setter callbacks
Date: Tue, 10 Jun 2025 14:33:19 +0200 [thread overview]
Message-ID: <20250610-gpiochip-set-rv-gpio-v1-9-3a9a3c1472ff@linaro.org> (raw)
In-Reply-To: <20250610-gpiochip-set-rv-gpio-v1-0-3a9a3c1472ff@linaro.org>
From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
struct gpio_chip now has callbacks for setting line values that return
an integer, allowing to indicate failures. Convert the driver to using
them.
Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
---
drivers/gpio/gpio-npcm-sgpio.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/gpio/gpio-npcm-sgpio.c b/drivers/gpio/gpio-npcm-sgpio.c
index 26057061454348d383129267e8bb0b8c506ea5c1..b3953d1ae8af45f4bce9b799434547cd8770d9df 100644
--- a/drivers/gpio/gpio-npcm-sgpio.c
+++ b/drivers/gpio/gpio-npcm-sgpio.c
@@ -226,7 +226,7 @@ static int npcm_sgpio_get_direction(struct gpio_chip *gc, unsigned int offset)
return GPIO_LINE_DIRECTION_IN;
}
-static void npcm_sgpio_set(struct gpio_chip *gc, unsigned int offset, int val)
+static int npcm_sgpio_set(struct gpio_chip *gc, unsigned int offset, int val)
{
struct npcm_sgpio *gpio = gpiochip_get_data(gc);
const struct npcm_sgpio_bank *bank = offset_to_bank(offset);
@@ -242,6 +242,8 @@ static void npcm_sgpio_set(struct gpio_chip *gc, unsigned int offset, int val)
reg &= ~BIT(GPIO_BIT(offset));
iowrite8(reg, addr);
+
+ return 0;
}
static int npcm_sgpio_get(struct gpio_chip *gc, unsigned int offset)
@@ -546,7 +548,7 @@ static int npcm_sgpio_probe(struct platform_device *pdev)
gpio->chip.direction_output = npcm_sgpio_dir_out;
gpio->chip.get_direction = npcm_sgpio_get_direction;
gpio->chip.get = npcm_sgpio_get;
- gpio->chip.set = npcm_sgpio_set;
+ gpio->chip.set_rv = npcm_sgpio_set;
gpio->chip.label = dev_name(&pdev->dev);
gpio->chip.base = -1;
--
2.48.1
next prev parent reply other threads:[~2025-06-10 12:33 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-10 12:33 [PATCH 00/12] gpio: convert another round of GPIO drivers to using new line value setters Bartosz Golaszewski
2025-06-10 12:33 ` [PATCH 01/12] gpio: mmio: use new GPIO line value setter callbacks Bartosz Golaszewski
2025-06-10 21:16 ` Linus Walleij
2025-06-18 11:59 ` Klara Modin
2025-06-18 12:34 ` Bartosz Golaszewski
2025-06-18 16:21 ` Mark Brown
2025-06-18 16:24 ` Bartosz Golaszewski
[not found] ` <CGME20250618164320eucas1p28174732f38fd279fbba72f07887e5da5@eucas1p2.samsung.com>
2025-06-18 16:43 ` Marek Szyprowski
2025-06-18 17:00 ` Bartosz Golaszewski
2025-06-10 12:33 ` [PATCH 02/12] gpio: mm-lantiq: " Bartosz Golaszewski
2025-06-10 22:01 ` Linus Walleij
2025-06-10 12:33 ` [PATCH 03/12] gpio: moxtet: " Bartosz Golaszewski
2025-06-13 14:40 ` Marek Behún
2025-06-10 12:33 ` [PATCH 04/12] gpio: mpc5200: " Bartosz Golaszewski
2025-06-10 12:33 ` [PATCH 05/12] gpio: mpfs: " Bartosz Golaszewski
2025-06-10 12:33 ` [PATCH 06/12] gpio: mpsse: " Bartosz Golaszewski
2025-06-10 12:33 ` [PATCH 07/12] gpio: msc313: " Bartosz Golaszewski
2025-06-11 22:21 ` Daniel Palmer
2025-06-10 12:33 ` [PATCH 08/12] gpio: nomadik: " Bartosz Golaszewski
2025-06-10 22:06 ` Linus Walleij
2025-06-10 12:33 ` Bartosz Golaszewski [this message]
2025-06-10 12:33 ` [PATCH 10/12] gpio: octeon: " Bartosz Golaszewski
2025-06-10 12:33 ` [PATCH 11/12] gpio: omap: " Bartosz Golaszewski
2025-06-10 12:33 ` [PATCH 12/12] gpio: palmas: " Bartosz Golaszewski
2025-06-17 9:14 ` [PATCH 00/12] gpio: convert another round of GPIO drivers to using new line value setters Bartosz Golaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250610-gpiochip-set-rv-gpio-v1-9-3a9a3c1472ff@linaro.org \
--to=brgl@bgdev.pl \
--cc=avifishman70@gmail.com \
--cc=bartosz.golaszewski@linaro.org \
--cc=benjaminfair@google.com \
--cc=conor.dooley@microchip.com \
--cc=daire.mcnamara@microchip.com \
--cc=daniel@thingy.jp \
--cc=grygorii.strashko@ti.com \
--cc=kabel@kernel.org \
--cc=khilman@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=openbmc@lists.ozlabs.org \
--cc=romain.perier@gmail.com \
--cc=ssantosh@kernel.org \
--cc=tali.perry1@gmail.com \
--cc=tmaimon77@gmail.com \
--cc=venture@google.com \
--cc=yuenn@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).