* [PATCH] gpio: spacemit: Add missing MODULE_DEVICE_TABLE
@ 2025-06-13 9:25 Vivian Wang
2025-06-13 9:33 ` Yixun Lan
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Vivian Wang @ 2025-06-13 9:25 UTC (permalink / raw)
To: Linus Walleij, Bartosz Golaszewski, Yixun Lan, Alex Elder
Cc: Vivian Wang, linux-gpio, linux-riscv, spacemit, linux-kernel,
Vivian Wang
The gpio-spacemit-k1 driver can be compiled as a module. Add missing
MODULE_DEVICE_TABLE so it can be matched by modalias and automatically
loaded by udev.
Fixes: d00553240ef8 ("gpio: spacemit: add support for K1 SoC")
Signed-off-by: Vivian Wang <wangruikang@iscas.ac.cn>
---
This patch is available at:
https://github.com/dramforever/linux/tree/k1/gpio-of-table/v1
---
drivers/gpio/gpio-spacemit-k1.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpio/gpio-spacemit-k1.c b/drivers/gpio/gpio-spacemit-k1.c
index f027066365ff8741f99da076d1e7b6339a6c1a22..3cc75c701ec40194e602b80d3f96f23204ce3b4d 100644
--- a/drivers/gpio/gpio-spacemit-k1.c
+++ b/drivers/gpio/gpio-spacemit-k1.c
@@ -278,6 +278,7 @@ static const struct of_device_id spacemit_gpio_dt_ids[] = {
{ .compatible = "spacemit,k1-gpio" },
{ /* sentinel */ }
};
+MODULE_DEVICE_TABLE(of, spacemit_gpio_dt_ids);
static struct platform_driver spacemit_gpio_driver = {
.probe = spacemit_gpio_probe,
---
base-commit: 19272b37aa4f83ca52bdf9c16d5d81bdd1354494
change-id: 20250613-k1-gpio-of-table-222b4b76b453
Best regards,
--
Vivian "dramforever" Wang
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] gpio: spacemit: Add missing MODULE_DEVICE_TABLE
2025-06-13 9:25 [PATCH] gpio: spacemit: Add missing MODULE_DEVICE_TABLE Vivian Wang
@ 2025-06-13 9:33 ` Yixun Lan
2025-06-16 7:44 ` Bartosz Golaszewski
2025-07-02 18:52 ` patchwork-bot+linux-riscv
2 siblings, 0 replies; 4+ messages in thread
From: Yixun Lan @ 2025-06-13 9:33 UTC (permalink / raw)
To: Vivian Wang
Cc: Linus Walleij, Bartosz Golaszewski, Alex Elder, Vivian Wang,
linux-gpio, linux-riscv, spacemit, linux-kernel
Hi Vivian,
On 17:25 Fri 13 Jun , Vivian Wang wrote:
> The gpio-spacemit-k1 driver can be compiled as a module. Add missing
> MODULE_DEVICE_TABLE so it can be matched by modalias and automatically
> loaded by udev.
>
> Fixes: d00553240ef8 ("gpio: spacemit: add support for K1 SoC")
> Signed-off-by: Vivian Wang <wangruikang@iscas.ac.cn>
LGTM
Reviewed-by: Yixun Lan <dlan@gentoo.org>
> ---
> This patch is available at:
>
> https://github.com/dramforever/linux/tree/k1/gpio-of-table/v1
> ---
> drivers/gpio/gpio-spacemit-k1.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpio/gpio-spacemit-k1.c b/drivers/gpio/gpio-spacemit-k1.c
> index f027066365ff8741f99da076d1e7b6339a6c1a22..3cc75c701ec40194e602b80d3f96f23204ce3b4d 100644
> --- a/drivers/gpio/gpio-spacemit-k1.c
> +++ b/drivers/gpio/gpio-spacemit-k1.c
> @@ -278,6 +278,7 @@ static const struct of_device_id spacemit_gpio_dt_ids[] = {
> { .compatible = "spacemit,k1-gpio" },
> { /* sentinel */ }
> };
> +MODULE_DEVICE_TABLE(of, spacemit_gpio_dt_ids);
>
> static struct platform_driver spacemit_gpio_driver = {
> .probe = spacemit_gpio_probe,
>
> ---
> base-commit: 19272b37aa4f83ca52bdf9c16d5d81bdd1354494
> change-id: 20250613-k1-gpio-of-table-222b4b76b453
>
> Best regards,
> --
> Vivian "dramforever" Wang
>
--
Yixun Lan (dlan)
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] gpio: spacemit: Add missing MODULE_DEVICE_TABLE
2025-06-13 9:25 [PATCH] gpio: spacemit: Add missing MODULE_DEVICE_TABLE Vivian Wang
2025-06-13 9:33 ` Yixun Lan
@ 2025-06-16 7:44 ` Bartosz Golaszewski
2025-07-02 18:52 ` patchwork-bot+linux-riscv
2 siblings, 0 replies; 4+ messages in thread
From: Bartosz Golaszewski @ 2025-06-16 7:44 UTC (permalink / raw)
To: Linus Walleij, Bartosz Golaszewski, Yixun Lan, Alex Elder,
Vivian Wang
Cc: Bartosz Golaszewski, Vivian Wang, linux-gpio, linux-riscv,
spacemit, linux-kernel
From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
On Fri, 13 Jun 2025 17:25:33 +0800, Vivian Wang wrote:
> The gpio-spacemit-k1 driver can be compiled as a module. Add missing
> MODULE_DEVICE_TABLE so it can be matched by modalias and automatically
> loaded by udev.
>
>
Applied, thanks!
[1/1] gpio: spacemit: Add missing MODULE_DEVICE_TABLE
https://git.kernel.org/brgl/linux/c/e6382fcf989074566bb9a54bbd3c514d7bb99397
Best regards,
--
Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] gpio: spacemit: Add missing MODULE_DEVICE_TABLE
2025-06-13 9:25 [PATCH] gpio: spacemit: Add missing MODULE_DEVICE_TABLE Vivian Wang
2025-06-13 9:33 ` Yixun Lan
2025-06-16 7:44 ` Bartosz Golaszewski
@ 2025-07-02 18:52 ` patchwork-bot+linux-riscv
2 siblings, 0 replies; 4+ messages in thread
From: patchwork-bot+linux-riscv @ 2025-07-02 18:52 UTC (permalink / raw)
To: Vivian Wang
Cc: linux-riscv, linus.walleij, brgl, dlan, elder, uwu, linux-gpio,
spacemit, linux-kernel
Hello:
This patch was applied to riscv/linux.git (fixes)
by Bartosz Golaszewski <bartosz.golaszewski@linaro.org>:
On Fri, 13 Jun 2025 17:25:33 +0800 you wrote:
> The gpio-spacemit-k1 driver can be compiled as a module. Add missing
> MODULE_DEVICE_TABLE so it can be matched by modalias and automatically
> loaded by udev.
>
> Fixes: d00553240ef8 ("gpio: spacemit: add support for K1 SoC")
> Signed-off-by: Vivian Wang <wangruikang@iscas.ac.cn>
>
> [...]
Here is the summary with links:
- gpio: spacemit: Add missing MODULE_DEVICE_TABLE
https://git.kernel.org/riscv/c/e6382fcf9890
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2025-07-02 18:52 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-06-13 9:25 [PATCH] gpio: spacemit: Add missing MODULE_DEVICE_TABLE Vivian Wang
2025-06-13 9:33 ` Yixun Lan
2025-06-16 7:44 ` Bartosz Golaszewski
2025-07-02 18:52 ` patchwork-bot+linux-riscv
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).