From: Yixun Lan <dlan@gentoo.org>
To: Vivian Wang <wangruikang@iscas.ac.cn>
Cc: Linus Walleij <linus.walleij@linaro.org>,
Bartosz Golaszewski <brgl@bgdev.pl>,
Alex Elder <elder@riscstar.com>, Vivian Wang <uwu@dram.page>,
linux-gpio@vger.kernel.org, linux-riscv@lists.infradead.org,
spacemit@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] gpio: spacemit: Add missing MODULE_DEVICE_TABLE
Date: Fri, 13 Jun 2025 09:33:33 +0000 [thread overview]
Message-ID: <20250613093333-GYA135173@gentoo> (raw)
In-Reply-To: <20250613-k1-gpio-of-table-v1-1-9015da8fdfdb@iscas.ac.cn>
Hi Vivian,
On 17:25 Fri 13 Jun , Vivian Wang wrote:
> The gpio-spacemit-k1 driver can be compiled as a module. Add missing
> MODULE_DEVICE_TABLE so it can be matched by modalias and automatically
> loaded by udev.
>
> Fixes: d00553240ef8 ("gpio: spacemit: add support for K1 SoC")
> Signed-off-by: Vivian Wang <wangruikang@iscas.ac.cn>
LGTM
Reviewed-by: Yixun Lan <dlan@gentoo.org>
> ---
> This patch is available at:
>
> https://github.com/dramforever/linux/tree/k1/gpio-of-table/v1
> ---
> drivers/gpio/gpio-spacemit-k1.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpio/gpio-spacemit-k1.c b/drivers/gpio/gpio-spacemit-k1.c
> index f027066365ff8741f99da076d1e7b6339a6c1a22..3cc75c701ec40194e602b80d3f96f23204ce3b4d 100644
> --- a/drivers/gpio/gpio-spacemit-k1.c
> +++ b/drivers/gpio/gpio-spacemit-k1.c
> @@ -278,6 +278,7 @@ static const struct of_device_id spacemit_gpio_dt_ids[] = {
> { .compatible = "spacemit,k1-gpio" },
> { /* sentinel */ }
> };
> +MODULE_DEVICE_TABLE(of, spacemit_gpio_dt_ids);
>
> static struct platform_driver spacemit_gpio_driver = {
> .probe = spacemit_gpio_probe,
>
> ---
> base-commit: 19272b37aa4f83ca52bdf9c16d5d81bdd1354494
> change-id: 20250613-k1-gpio-of-table-222b4b76b453
>
> Best regards,
> --
> Vivian "dramforever" Wang
>
--
Yixun Lan (dlan)
next prev parent reply other threads:[~2025-06-13 9:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-13 9:25 [PATCH] gpio: spacemit: Add missing MODULE_DEVICE_TABLE Vivian Wang
2025-06-13 9:33 ` Yixun Lan [this message]
2025-06-16 7:44 ` Bartosz Golaszewski
2025-07-02 18:52 ` patchwork-bot+linux-riscv
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250613093333-GYA135173@gentoo \
--to=dlan@gentoo.org \
--cc=brgl@bgdev.pl \
--cc=elder@riscstar.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=spacemit@lists.linux.dev \
--cc=uwu@dram.page \
--cc=wangruikang@iscas.ac.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox