From: Bartosz Golaszewski <brgl@bgdev.pl>
To: "Mauro Carvalho Chehab" <mchehab@kernel.org>,
"Linus Walleij" <linus.walleij@linaro.org>,
"Bartosz Golaszewski" <brgl@bgdev.pl>,
"Bluecherry Maintainers" <maintainers@bluecherrydvr.com>,
"Andrey Utkin" <andrey_utkin@fastmail.com>,
"Ismael Luceno" <ismael@iodev.co.uk>,
"Tomi Valkeinen" <tomi.valkeinen@ideasonboard.com>,
"Julien Massot" <julien.massot@collabora.com>,
"Jacopo Mondi" <jacopo+renesas@jmondi.org>,
"Kieran Bingham" <kieran.bingham+renesas@ideasonboard.com>,
"Laurent Pinchart" <laurent.pinchart+renesas@ideasonboard.com>,
"Niklas Söderlund" <niklas.soderlund+renesas@ragnatech.se>
Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-gpio@vger.kernel.org,
Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
Subject: [PATCH v2 1/7] media: dvb-frontends/cxd2820r: use new GPIO line value setter callbacks
Date: Mon, 16 Jun 2025 09:18:50 +0200 [thread overview]
Message-ID: <20250616-gpiochip-set-rv-media-v2-1-6825114f18b0@linaro.org> (raw)
In-Reply-To: <20250616-gpiochip-set-rv-media-v2-0-6825114f18b0@linaro.org>
From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
struct gpio_chip now has callbacks for setting line values that return
an integer, allowing to indicate failures. Convert the driver to using
them.
Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
---
drivers/media/dvb-frontends/cxd2820r_core.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/media/dvb-frontends/cxd2820r_core.c b/drivers/media/dvb-frontends/cxd2820r_core.c
index c3d8ced6c3baa6608e17cc4797dbeddc5a5ed510..a31a8a6a494652e6aae874c399fc70df3f9ee172 100644
--- a/drivers/media/dvb-frontends/cxd2820r_core.c
+++ b/drivers/media/dvb-frontends/cxd2820r_core.c
@@ -433,7 +433,7 @@ static int cxd2820r_gpio_direction_output(struct gpio_chip *chip, unsigned nr,
return cxd2820r_gpio(&priv->fe, gpio);
}
-static void cxd2820r_gpio_set(struct gpio_chip *chip, unsigned nr, int val)
+static int cxd2820r_gpio_set(struct gpio_chip *chip, unsigned int nr, int val)
{
struct cxd2820r_priv *priv = gpiochip_get_data(chip);
struct i2c_client *client = priv->client[0];
@@ -446,7 +446,7 @@ static void cxd2820r_gpio_set(struct gpio_chip *chip, unsigned nr, int val)
(void) cxd2820r_gpio(&priv->fe, gpio);
- return;
+ return 0;
}
static int cxd2820r_gpio_get(struct gpio_chip *chip, unsigned nr)
@@ -651,7 +651,7 @@ static int cxd2820r_probe(struct i2c_client *client)
priv->gpio_chip.parent = &client->dev;
priv->gpio_chip.owner = THIS_MODULE;
priv->gpio_chip.direction_output = cxd2820r_gpio_direction_output;
- priv->gpio_chip.set = cxd2820r_gpio_set;
+ priv->gpio_chip.set_rv = cxd2820r_gpio_set;
priv->gpio_chip.get = cxd2820r_gpio_get;
priv->gpio_chip.base = -1; /* Dynamic allocation */
priv->gpio_chip.ngpio = GPIO_COUNT;
--
2.48.1
next prev parent reply other threads:[~2025-06-16 7:19 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-16 7:18 [PATCH v2 0/7] media: use new GPIO line value setter callbacks Bartosz Golaszewski
2025-06-16 7:18 ` Bartosz Golaszewski [this message]
2025-06-16 7:18 ` [PATCH v2 2/7] media: solo6x10: remove unneeded GPIO direction setters Bartosz Golaszewski
2025-06-16 7:18 ` [PATCH v2 3/7] media: solo6x10: use new GPIO line value setter callbacks Bartosz Golaszewski
2025-06-16 7:18 ` [PATCH v2 4/7] media: i2c: ds90ub953: " Bartosz Golaszewski
2025-06-16 7:18 ` [PATCH v2 5/7] media: i2c: ds90ub913: " Bartosz Golaszewski
2025-06-16 7:18 ` [PATCH v2 6/7] media: i2c: max96717: " Bartosz Golaszewski
2025-06-16 7:18 ` [PATCH v2 7/7] media: i2c: max9286: " Bartosz Golaszewski
2025-06-18 12:48 ` Jacopo Mondi
2025-06-18 12:26 ` [PATCH v2 0/7] media: " Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250616-gpiochip-set-rv-media-v2-1-6825114f18b0@linaro.org \
--to=brgl@bgdev.pl \
--cc=andrey_utkin@fastmail.com \
--cc=bartosz.golaszewski@linaro.org \
--cc=ismael@iodev.co.uk \
--cc=jacopo+renesas@jmondi.org \
--cc=julien.massot@collabora.com \
--cc=kieran.bingham+renesas@ideasonboard.com \
--cc=laurent.pinchart+renesas@ideasonboard.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=maintainers@bluecherrydvr.com \
--cc=mchehab@kernel.org \
--cc=niklas.soderlund+renesas@ragnatech.se \
--cc=tomi.valkeinen@ideasonboard.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).