From: Bartosz Golaszewski <brgl@bgdev.pl>
To: "Mauro Carvalho Chehab" <mchehab@kernel.org>,
"Linus Walleij" <linus.walleij@linaro.org>,
"Bartosz Golaszewski" <brgl@bgdev.pl>,
"Bluecherry Maintainers" <maintainers@bluecherrydvr.com>,
"Andrey Utkin" <andrey_utkin@fastmail.com>,
"Ismael Luceno" <ismael@iodev.co.uk>,
"Tomi Valkeinen" <tomi.valkeinen@ideasonboard.com>,
"Julien Massot" <julien.massot@collabora.com>,
"Jacopo Mondi" <jacopo+renesas@jmondi.org>,
"Kieran Bingham" <kieran.bingham+renesas@ideasonboard.com>,
"Laurent Pinchart" <laurent.pinchart+renesas@ideasonboard.com>,
"Niklas Söderlund" <niklas.soderlund+renesas@ragnatech.se>
Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-gpio@vger.kernel.org,
Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
Subject: [PATCH v2 4/7] media: i2c: ds90ub953: use new GPIO line value setter callbacks
Date: Mon, 16 Jun 2025 09:18:53 +0200 [thread overview]
Message-ID: <20250616-gpiochip-set-rv-media-v2-4-6825114f18b0@linaro.org> (raw)
In-Reply-To: <20250616-gpiochip-set-rv-media-v2-0-6825114f18b0@linaro.org>
From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
struct gpio_chip now has callbacks for setting line values that return
an integer, allowing to indicate failures. Convert the driver to using
them.
Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
---
drivers/media/i2c/ds90ub953.c | 11 +++++------
1 file changed, 5 insertions(+), 6 deletions(-)
diff --git a/drivers/media/i2c/ds90ub953.c b/drivers/media/i2c/ds90ub953.c
index 59bd92388845eedf64587289c7f7424ee570524a..242dbf6d48f3905c8908bbb06ede84e068e2f267 100644
--- a/drivers/media/i2c/ds90ub953.c
+++ b/drivers/media/i2c/ds90ub953.c
@@ -317,14 +317,13 @@ static int ub953_gpio_get(struct gpio_chip *gc, unsigned int offset)
return !!(v & UB953_REG_GPIO_PIN_STS_GPIO_STS(offset));
}
-static void ub953_gpio_set(struct gpio_chip *gc, unsigned int offset, int value)
+static int ub953_gpio_set(struct gpio_chip *gc, unsigned int offset, int value)
{
struct ub953_data *priv = gpiochip_get_data(gc);
- regmap_update_bits(priv->regmap, UB953_REG_LOCAL_GPIO_DATA,
- UB953_REG_LOCAL_GPIO_DATA_GPIO_OUT_SRC(offset),
- value ? UB953_REG_LOCAL_GPIO_DATA_GPIO_OUT_SRC(offset) :
- 0);
+ return regmap_update_bits(priv->regmap, UB953_REG_LOCAL_GPIO_DATA,
+ UB953_REG_LOCAL_GPIO_DATA_GPIO_OUT_SRC(offset),
+ value ? UB953_REG_LOCAL_GPIO_DATA_GPIO_OUT_SRC(offset) : 0);
}
static int ub953_gpio_of_xlate(struct gpio_chip *gc,
@@ -362,7 +361,7 @@ static int ub953_gpiochip_probe(struct ub953_data *priv)
gc->direction_input = ub953_gpio_direction_in;
gc->direction_output = ub953_gpio_direction_out;
gc->get = ub953_gpio_get;
- gc->set = ub953_gpio_set;
+ gc->set_rv = ub953_gpio_set;
gc->of_xlate = ub953_gpio_of_xlate;
gc->of_gpio_n_cells = 2;
--
2.48.1
next prev parent reply other threads:[~2025-06-16 7:19 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-16 7:18 [PATCH v2 0/7] media: use new GPIO line value setter callbacks Bartosz Golaszewski
2025-06-16 7:18 ` [PATCH v2 1/7] media: dvb-frontends/cxd2820r: " Bartosz Golaszewski
2025-06-16 7:18 ` [PATCH v2 2/7] media: solo6x10: remove unneeded GPIO direction setters Bartosz Golaszewski
2025-06-16 7:18 ` [PATCH v2 3/7] media: solo6x10: use new GPIO line value setter callbacks Bartosz Golaszewski
2025-06-16 7:18 ` Bartosz Golaszewski [this message]
2025-06-16 7:18 ` [PATCH v2 5/7] media: i2c: ds90ub913: " Bartosz Golaszewski
2025-06-16 7:18 ` [PATCH v2 6/7] media: i2c: max96717: " Bartosz Golaszewski
2025-06-16 7:18 ` [PATCH v2 7/7] media: i2c: max9286: " Bartosz Golaszewski
2025-06-18 12:48 ` Jacopo Mondi
2025-06-18 12:26 ` [PATCH v2 0/7] media: " Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250616-gpiochip-set-rv-media-v2-4-6825114f18b0@linaro.org \
--to=brgl@bgdev.pl \
--cc=andrey_utkin@fastmail.com \
--cc=bartosz.golaszewski@linaro.org \
--cc=ismael@iodev.co.uk \
--cc=jacopo+renesas@jmondi.org \
--cc=julien.massot@collabora.com \
--cc=kieran.bingham+renesas@ideasonboard.com \
--cc=laurent.pinchart+renesas@ideasonboard.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=maintainers@bluecherrydvr.com \
--cc=mchehab@kernel.org \
--cc=niklas.soderlund+renesas@ragnatech.se \
--cc=tomi.valkeinen@ideasonboard.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).