From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f49.google.com (mail-wm1-f49.google.com [209.85.128.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4C6EF298981 for ; Wed, 25 Jun 2025 10:33:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750847628; cv=none; b=aa2dVlJT7msPS84WZzrPu8YBVcA9FOaytesmst31m4J1feUngznigswnJE5cSlbfX1R8AXsKOZ6jiQsEelwSKowGDgAO4XhHpIxKER5zZYNrznHXCJrJpTimOTyORNluwdNfH2Lf0hoDzcIw7ZRB048/hkiykdpwkjGWrwz1laM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750847628; c=relaxed/simple; bh=SQMikfH54IsfeMpR+L/xaq1fah7XLopJ47ae5Iy9WUk=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=iydG2le8YpC5lIXuqBv+Wjs5YFIxL3lxE/0H1SbsabkTSTPfn8BjVFZ10K1d0V5S8k7F0i8oBXFcviI9HKpMhf5IssgLOfpmMWDVHjGTUfe//wb6o9EJdwOFMROTFi5UMXfrjuCum60A9MX9rEhp33qMZ7fM4/VzstEnZCQe1tk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=KPmqjQB0; arc=none smtp.client-ip=209.85.128.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="KPmqjQB0" Received: by mail-wm1-f49.google.com with SMTP id 5b1f17b1804b1-45377776935so30192985e9.3 for ; Wed, 25 Jun 2025 03:33:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1750847625; x=1751452425; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=8zb19l62LN7ssNNUqMMp02ypDTWsuR6UE9OCfe02DEw=; b=KPmqjQB010l80Xfc337CTcAVSAa2Pp5eYwnMPH9aQ6THbHeYAbGNyXTiQDM6ehUbZp 44R+BjLEzN2GwL8qIYBxjOSkWj9wZ9krp6X5jaydtMMnb0iimNvv9u5w3ZbeH0qSo4XR H7JhzKyPNRN9wiiHn4FQRCenUYREGJJnpkve9QKOf7LA9uyjpeATDaHL0gj3YUFkPtrY Cd3CZfp4YZkszPnHwlbsEpE9hmN3C3w10WECdxGrstUSTFkZ7Rn7223reX1J1a6AY5Eg MglUfsrN3u4pMc1D560quUGtVrZmVhtZJC2YnsYfHWfz5Ry6lkivDkCGvLAptb5wzArT U3MQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750847625; x=1751452425; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=8zb19l62LN7ssNNUqMMp02ypDTWsuR6UE9OCfe02DEw=; b=aCGN4D+2aBs/Vnh6maJSjyHJ2d95Ik68Bruto/1HrSEnVyvkXL0zKG87RzzHejbW5/ pOQbbyl+ev5jVEP3InwW8oQ/1nD4JCgMW64Gd20E19Mo6lyNFcEIVPWu6a9MzhX6YMeC irCWwvwRmdauiJkNUjApgX9629ISOEfJe9wPlAJow8EBmMA31q95nrFXZKAcFiHc6DQy z+HazkQdJ2cKtjRXgeRJBdVAgrFt3UY05n/FSRL8ZaL3gJwQw2QvvzBFrp45ce04dXAY 2/UsgJM8e7Eg8//O+c1OkzBA9eLpRVSv/tD23bikGKY52CjXh439riydM5ok+n9HWQM5 JXaA== X-Forwarded-Encrypted: i=1; AJvYcCVkewkQidKrxrAN1F/QzaIaumJAv8WUy7lMNpNcTJHwYoUjhgL72Y8xi+itPkNorATNaFykOOThPquD@vger.kernel.org X-Gm-Message-State: AOJu0Yxa2bfHmC/BEGsORydoc7a2SmRGy2qV84z9fFc2n3KQQF8rmqS/ 13pjOPWsnCai7hMbIOgJtNvJZKR9GRGfQn1WjHKvllnu8pPaSl54h4aFhNzOiiJ69o/FO913GaD rrvc6fDY= X-Gm-Gg: ASbGncvciehB0xKPY3jERgJmJueYNgifLpppbERHhJzm268W92rPLNFL6R97ag8RPb5 3a+uEUcfNmgO53ZC3zsZ6Txkk7yxXAtUhORWKcUjamLHyhO//CulGR7/UpfJL9eFqLwaBqJUBzU 05MEMK9bxDhzIcoI+uEeGfFZBm95joemjHyur//MSVaX4DWiIW8Z4dtl/zO9QK/kjHABISZCbWL 0HCDZLzlHaWVjILBf0B7BMnaxqHOnqJqVcJdREoPfGTeimPHDuqKGX7kfEa4UNdV7j2J+ytwPKw EqX9POU186ic7Mx21wE9EYv82UKXaHIBVGVMYS4wRGWUAviizcQuo2kp X-Google-Smtp-Source: AGHT+IGE1iP8Q+/UBvqDvrwiy35DOn+9cFNtjYDncbc3WiyZ+/TZLkMjhHK06lIMfzCnTiYjrVT4RA== X-Received: by 2002:a05:600c:37ca:b0:450:cf42:7565 with SMTP id 5b1f17b1804b1-45381ae5157mr21000645e9.23.1750847625330; Wed, 25 Jun 2025 03:33:45 -0700 (PDT) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:d216:42f3:1e7e:472e]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-45382373c86sm16133195e9.33.2025.06.25.03.33.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 25 Jun 2025 03:33:43 -0700 (PDT) From: Bartosz Golaszewski Date: Wed, 25 Jun 2025 12:33:28 +0200 Subject: [PATCH 05/12] gpio: spear-spics: remove unneeded callbacks Precedence: bulk X-Mailing-List: linux-gpio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20250625-gpiochip-set-rv-gpio-round2-v1-5-bc110a3b52ff@linaro.org> References: <20250625-gpiochip-set-rv-gpio-round2-v1-0-bc110a3b52ff@linaro.org> In-Reply-To: <20250625-gpiochip-set-rv-gpio-round2-v1-0-bc110a3b52ff@linaro.org> To: Ludovic Desroches , Linus Walleij , Bartosz Golaszewski , Andy Shevchenko , Thorsten Scherer , Pengutronix Kernel Team , Orson Zhai , Baolin Wang , Chunyan Zhang , Maxime Coquelin , Alexandre Torgue Cc: linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, Bartosz Golaszewski X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1789; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=CY82p8ULaZbPaJLzsSE1jBEx4Q22047mL4oX3JNu98M=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBoW9B/VUUd0S0rRYJZkJ/S3qmK/y9uGk/fty3n2 /3rwZgRjn+JAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCaFvQfwAKCRARpy6gFHHX ckPIEACZJ7YNhLX9LjsVao2rzFSTptRFTG8o45nfPlE3dmbbY3xiZpnoKARBKsndI3htD18t+Su fFS5ueGlSpJvuexYxJjGZPb8EyjUMiMd1ilvCVmZPqFkQS/BllugnD6vUj/l+iTO4mFIGg+Rl2e GFNV9Mhjupn4r+u9nSPYCjv8WfgeHF2mRHMeqM6mACuMrNoK4XShviCejqKJtIHbtXJpmd/kWw4 CyWp++UesKsLwMU4t4a8OU5Lg0uDOUNdfpx3rfp6I0dXwrHYRI1LvvHJfxxTZDaQVvptd+5Zj1x DIy+KmElvIDe8VbtEUqbf2Am9xBq0IMpV7YhioCvnedxP2WRq2uD3OTDtBEPz81V4iq0GroVTN4 /8jPC1gWkufJEJV1fgYHfU/9P7Q9P916XEXQfqN5Kw45PZUy5lQ0mtGXRy45+/eGiq3949p9zSo BFFLAV6nYTA04ChIoJEgBLJtSOIrOz5ffGpNb4RUkW6EfPxKTHYXxCyvsqIItmGrryUpDZXbmYH vvKA1o39bf4Gl6fZK5G7ffc+Fy4l8MFNoKtb5qJK7KcTMxAsuOIa9MrYYE01osnahxcGJ4znoBx CTyeRANlafMQ2TmkDUni5eowtmFeaXK2AZ+O4ZoWgoZ4kUifnBvUg9X2dUs+vzHHawl6x9psUt4 Ky1BQHapjjvhdHA== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 From: Bartosz Golaszewski GPIO core can handle output-only chips that don't implement the get() and direction_input() callbacks. There's no need to provide dummy implementations in the driver so drop them. Signed-off-by: Bartosz Golaszewski --- drivers/gpio/gpio-spear-spics.c | 13 ------------- 1 file changed, 13 deletions(-) diff --git a/drivers/gpio/gpio-spear-spics.c b/drivers/gpio/gpio-spear-spics.c index 51539185400d329c5a065d7a51c27b2ae24f672c..964b7dcb30b7a5bccda964a637f7fec97fe02aa4 100644 --- a/drivers/gpio/gpio-spear-spics.c +++ b/drivers/gpio/gpio-spear-spics.c @@ -51,12 +51,6 @@ struct spear_spics { struct gpio_chip chip; }; -/* gpio framework specific routines */ -static int spics_get_value(struct gpio_chip *chip, unsigned offset) -{ - return -ENXIO; -} - static void spics_set_value(struct gpio_chip *chip, unsigned offset, int value) { struct spear_spics *spics = gpiochip_get_data(chip); @@ -76,11 +70,6 @@ static void spics_set_value(struct gpio_chip *chip, unsigned offset, int value) writel_relaxed(tmp, spics->base + spics->perip_cfg); } -static int spics_direction_input(struct gpio_chip *chip, unsigned offset) -{ - return -ENXIO; -} - static int spics_direction_output(struct gpio_chip *chip, unsigned offset, int value) { @@ -148,9 +137,7 @@ static int spics_gpio_probe(struct platform_device *pdev) spics->chip.base = -1; spics->chip.request = spics_request; spics->chip.free = spics_free; - spics->chip.direction_input = spics_direction_input; spics->chip.direction_output = spics_direction_output; - spics->chip.get = spics_get_value; spics->chip.set = spics_set_value; spics->chip.label = dev_name(&pdev->dev); spics->chip.parent = &pdev->dev; -- 2.48.1