From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f54.google.com (mail-wm1-f54.google.com [209.85.128.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7A0952BF01E for ; Wed, 25 Jun 2025 10:33:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750847631; cv=none; b=by0pYkLlcXkmR6w7SFjdwSDLkxH811W23EYqL+y/4355weLfiYznsi6oS16MRUeA/SKbzk+YdGcvQ8f4iMcQbT0Fddks6I1lhMWVHFcKp4Kv1yTV2plmhhGBhkT/68NCg7c7xDTSut+dg0pEOEctbk12RrR8sRy198rl0GK7g68= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750847631; c=relaxed/simple; bh=8I9dRWWDYhuA4l+vSi48OR8d0DBnwZ05W+pEhASmVFI=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=G+9DfyU0oYFYb5dBbak9XDKP7roMi+iu9wGGj9C4slLxywuUsB9NxaCkyZzLxpXHXAo/vmrFhqe1tGBe9M038WNhsAW0G0Q6DbvTKuvYrZFi3yI74/jYixdiEy923ni9uFgeP1vUMkgr2v3nVxEkSSx6FLmUL5S/XFpxRKZPwkY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=xSCu69R6; arc=none smtp.client-ip=209.85.128.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="xSCu69R6" Received: by mail-wm1-f54.google.com with SMTP id 5b1f17b1804b1-442fda876a6so57515575e9.0 for ; Wed, 25 Jun 2025 03:33:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1750847627; x=1751452427; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=7iDWjP9HRVIb7sR3VThhC45lPvgyQWTusyUiyxvyENs=; b=xSCu69R6CUZltjj79cvX7cYrsHaZmUSaey2KS/lq2D4RvQXaWMAPrw4gVlXBnRM3y0 rzsHHCatALjyE9mYkyVqyI2KSTJEGZhDkkjcNlL0Pe02HjZReBYoVNbr3bfFS+Fm8cyn YOmWwMF1cy/aljus4s4KJyRZGdjKQ3zciTW1HZJ0uWp11fuHGf6M43iRBxu5Es/hTsfa QGwzQ7NHz4eYF3O4+zeoxU2s6vEXG1nAnkL8IZzS4xZc0tj7T0WzIhhSvDh2Bpuy2kf7 dzKJN/A7GyEPzogxDVzPU7GokpnQa/NW+s0zSUHzWf60CMewf/QxjA2moDDKf0acsLUt gPyQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750847627; x=1751452427; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=7iDWjP9HRVIb7sR3VThhC45lPvgyQWTusyUiyxvyENs=; b=RG9LEeRhRRMoftVNKvNro9DvV1Sdd09a0etq21pYhJOeGIcNu7KIJ6tgW+x6zbCBGI 4O0C72sKMDr92tIj1IlpzPSh2QLnYxl/9JNe20b6/3OAFX7XET9Iiwxp976LXl4dY8j2 /ux1zbERLWqJmfKsYNC/k5jYaVNEgTQ5tgMNlyEcEnSH/jkFRNQ270QO+1Gv/tZabLAO 0ulOev+4OxiUVAomnfOxZBlE81Y9Nj19CYSNz4lylJ+wp6SUeb8dwStEmfPyVd+tT8Vf Yu2tEHHTSQ+r+1T+3q0o98XAE5Hcp10kUEPd+Gjm010e6OmTJQqGGG++jmayKf5pBr5G jLxA== X-Forwarded-Encrypted: i=1; AJvYcCVEH+HT8u5dLv3np10xL/OWwqe3Q6AjJ7JYg3BtXfZ8mYd9Y9fW8QXezx48Zb8Sajn4ueAeNJDQBLxq@vger.kernel.org X-Gm-Message-State: AOJu0YzvMKCI577T+mdZA9hUhx94K7DTxXhEyEqCT6oxBub/1VlvIRT8 p0BqRTeqakmRNbu4dH3w8gg8byH1iiUB0nwXKaDHrB54wlvnp93iM1FjIE1V5P6RI17tdFDLGW6 +vCWstz0= X-Gm-Gg: ASbGncsyIhO6AQFaV2+LcrnQJNUbjmKm8Pxeu+Q3X+gcOVqtDDDXmKL9ugMxZC5JW6F Y/Ydxqp4pwOqHw1+QakcUuBSxjO+hPZkqXsv6bTayvBS3doiyg9Ad2jThnimtmgn+bteSs9dhJM +xGsuq3U8e1Elo/C7t45DVemiSLFTtrODhm4PhRkbuh/oAMYOSpvyixwveKwuMZJ2g/lxAXbx6X K4ECAkLw85QBN6uB8pM4i21dLL4tjhS4MT7AElZPebkYcNmeKIHhvoF9qVyCJV9UX6oYnYVpuJh +rHIZbkrwf4wKYJJycMVAbIwMYnyoS3nzpBNgsgo01SzTdxSIJOCiNGU X-Google-Smtp-Source: AGHT+IELePDfCHlBYQA947q59vgnMIBS0qmkpmIXczdAGAGH53ivPNqjGgKeUUibjSMbaCpIrdAsng== X-Received: by 2002:a05:600c:a302:b0:43c:fda5:41e9 with SMTP id 5b1f17b1804b1-453821b0a2amr16718975e9.31.1750847627484; Wed, 25 Jun 2025 03:33:47 -0700 (PDT) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:d216:42f3:1e7e:472e]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-45382373c86sm16133195e9.33.2025.06.25.03.33.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 25 Jun 2025 03:33:46 -0700 (PDT) From: Bartosz Golaszewski Date: Wed, 25 Jun 2025 12:33:30 +0200 Subject: [PATCH 07/12] gpio: sprd: use new GPIO line value setter callbacks Precedence: bulk X-Mailing-List: linux-gpio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20250625-gpiochip-set-rv-gpio-round2-v1-7-bc110a3b52ff@linaro.org> References: <20250625-gpiochip-set-rv-gpio-round2-v1-0-bc110a3b52ff@linaro.org> In-Reply-To: <20250625-gpiochip-set-rv-gpio-round2-v1-0-bc110a3b52ff@linaro.org> To: Ludovic Desroches , Linus Walleij , Bartosz Golaszewski , Andy Shevchenko , Thorsten Scherer , Pengutronix Kernel Team , Orson Zhai , Baolin Wang , Chunyan Zhang , Maxime Coquelin , Alexandre Torgue Cc: linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, Bartosz Golaszewski X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1462; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=VMUhzabI6TJSSEFS1lhCE2pMbGfsNwLrSf77JeJz6/w=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBoW9B/PT5QyhI466mXWQVK5eZlhAG2qptU0Jkjk YBlIjzP9muJAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCaFvQfwAKCRARpy6gFHHX cmjfD/95UQq01tmrRM1DzYdnerQeB3FFvKTQyd2fjDFNLy9dtXqfSNiftQA7k79L0u6uDb4TdYS zi+7vE56uklzOxkqrdBlFLv1eviupQLOy0Lo1o8B97QDAW8bfdlWushg08bvClpa4i4S4RN3zrF HMSuPvKlhrGDXidpLumdsrLg5XGbkqyAgAF/q32+Bl/OfGwv6000fdWfoydiq7JXLHqObRe7lLt wE0GbE/H4Yg/tSKKRd8ddQgS5zbAvXCKNo7KwXlTqwRg2t1E0c8kOpTf/OdftZ9/3dCfQI0ptMb lxwLYLcofM4g3TqBdVzbd1SK4EAG8zl7gMfAMlgbb1XlD502kJ9t0eBGlf2mjBsHdXZLKx1w0w2 4BS/nXvbFE8KEBYIXWVF8WeAs9XJuUkCDCAOTCu89w+x5npYmQRlHaAsS8PqW2NsCKu/9MGBnX0 x+0WdyPAA8tIxz4FCcsis54cIhLEiNSaCvxWBgdSDMFCu0H6Zvtl9UH0fCdldLPheqqb7cU6PQL QEq13Ow1loF3vWheP8IdWLLxQCfq/+gufdsNv8wP4Azdw4wH7kaT7W4nbGUReg+D4nXT6H1Spt4 QxwERElhaH1l0gwnAEQt7yxu1L25+NykUVwAdwaOCMXFGdE/ffigUG71qFAxkCLEtCL0aOiiugx BB64jdkmLzfuudg== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 From: Bartosz Golaszewski struct gpio_chip now has callbacks for setting line values that return an integer, allowing to indicate failures. Convert the driver to using them. Signed-off-by: Bartosz Golaszewski --- drivers/gpio/gpio-sprd.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/gpio/gpio-sprd.c b/drivers/gpio/gpio-sprd.c index c117c11bfb29a84d814706e383faa19afe513e93..bbd5bf51c0882704a9ead35d9fbc7d4b9bceec50 100644 --- a/drivers/gpio/gpio-sprd.c +++ b/drivers/gpio/gpio-sprd.c @@ -108,10 +108,12 @@ static int sprd_gpio_get(struct gpio_chip *chip, unsigned int offset) return sprd_gpio_read(chip, offset, SPRD_GPIO_DATA); } -static void sprd_gpio_set(struct gpio_chip *chip, unsigned int offset, - int value) +static int sprd_gpio_set(struct gpio_chip *chip, unsigned int offset, + int value) { sprd_gpio_update(chip, offset, SPRD_GPIO_DATA, value); + + return 0; } static void sprd_gpio_irq_mask(struct irq_data *data) @@ -243,7 +245,7 @@ static int sprd_gpio_probe(struct platform_device *pdev) sprd_gpio->chip.request = sprd_gpio_request; sprd_gpio->chip.free = sprd_gpio_free; sprd_gpio->chip.get = sprd_gpio_get; - sprd_gpio->chip.set = sprd_gpio_set; + sprd_gpio->chip.set_rv = sprd_gpio_set; sprd_gpio->chip.direction_input = sprd_gpio_direction_input; sprd_gpio->chip.direction_output = sprd_gpio_direction_output; -- 2.48.1