From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f46.google.com (mail-wm1-f46.google.com [209.85.128.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 19A7125392C for ; Wed, 2 Jul 2025 09:14:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751447666; cv=none; b=g3qwYuvx1L2mc2vGj9jcZ64v80eKM+V2+kvuE67NTdmBFxG4JV0yzbmck6xjsxhp/UxLDMgCReCewFn+RphZlqNxVksVDqW6vSaGBybuGDDMjES9X62x85QrlFnpQdXiKJnopJBaLf4/O6QkjIJ4qZfDhLg74Hxo+EBfUpgdKy4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751447666; c=relaxed/simple; bh=RkJAhHI9guhFeGcgAo0p+bb9aQhe35Qaf3tHDdTBIcE=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=UDV4j145l/EQoC4bIP6nCimbjfQRAtzL/JntOl1/JAK8Lx+nefHEXDACMkULtL9OzP5La3Qo8Sbb3Aj1wCfqYdIRAEAJZOITpvOLVkJxBTOu8NKval+JQ9MeXDVj72voxG8eaFhKAC8wdwM6UjZQHFlvD6epHMy8hqtJgaXTJ0A= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=OQsQnP4K; arc=none smtp.client-ip=209.85.128.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="OQsQnP4K" Received: by mail-wm1-f46.google.com with SMTP id 5b1f17b1804b1-4537edf2c3cso65000495e9.3 for ; Wed, 02 Jul 2025 02:14:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1751447661; x=1752052461; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=9PbvP7ii94AY3d065syIHwar8NBZworl3T0ee2JlaVU=; b=OQsQnP4KRRNHT+M7psK8vg7yyPO3Ldg62k9zn96bFhn2EPQ8CcARz5631zKTir3I/e lITguTP2coD4pQ2cbg4AvQN+rhFskUgCDzVlOAh0aT8BnJ74vjUOcmj0aIPipp6ftwE+ LZBda/rEJP5amyE9fZV2NhvBMnZmtKMdb3FH3uq2uccX9idtj1E2oCqJ5hgqhiNg20ar kr948xlQomhnV3mq1yUnCfzMg3iAuyUTZZSPilpVbAwoJsDFkTh3Clb9lE2MBWzDC0qh Si5K7f7+87koN9Usy7A2TtbmLCA5+T/BO2cc8VkKd4328rxqwh4yy9oUOLJNUJv6QcMM Go9g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751447661; x=1752052461; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=9PbvP7ii94AY3d065syIHwar8NBZworl3T0ee2JlaVU=; b=ElIkyTO9/cfvu0dZ7ks8MZu0OgbcvAGsaQsWXduot4cHHEdv/ha7OC2K3ssSkD80QP fju9rfD95yM7OsBK+ZpBT/53QqxQdnQmojG+Le9tmJmZTm/Li6uegUZ50SIYe8dtJ4Qy 24wrN29ex8/U3EthrxHjUppFNgp0FFV8AcfKR7nY0vtKPQzeWA7zOmclyohy9pikmYD6 XjdY+m+KWwA+ssF6Cduvo1fPMnDLTK5tRm1UZp5hWlNrMPd/HKtfld/mgS5qGaWBPzeZ 1pr9nHcHIOYPPO4ieHcldCLaGTtTmfNiVMFxNHbkwUjOaiMxJYNDqnNPsSOmBnhBcGf3 4X5w== X-Gm-Message-State: AOJu0YxQEhpBKAOf/A6Q+Od6D1DqqKXwtd2tO0Cc7DJ7Nbsj7LwMCHke CGbYNbKL4nur4MoaLC0wpGUwqeWKPGW4H3NK53FshUuTamhzCYO+SHBdydQssbIUVNk= X-Gm-Gg: ASbGncu5SycSpQ1+bZotDw0Hgx4TBj3+CR+SI8DWF5nEdKfX8qicdccmNRTeNBdGq7h EfdK91hL7LWM1Tc2kjcaVbYY6DXFer6iv41sFUxjHrFmfosgwrz4WizfbRI3b1gwJCh2B0elIz/ Wrumbwh89r1LlkcaP8NPfxtglfSEhC+OBky3bGJV+OC6ZmGm5aPPv1mHRavKtOQynRsDsKCRxQ1 g33z1uiiTHclHyEK215lZXsSGO+NinlLekeeAa3mi7aPIMl/jNwFpsUn+oxzWz/80wM/dLhhaEF HSvJWSiQZGLGxLg7mAA/HKUsonnsx6gA6zG0seq4Ki+VGtPfCdSfmg== X-Google-Smtp-Source: AGHT+IGsbQpNGpsWwygDJDy3w5MbAg5foRLDcgsBAjfS4y6V4+H+CNdcJLnsDTe/iGDKUgTVRhzcmA== X-Received: by 2002:a05:600c:c109:b0:441:a715:664a with SMTP id 5b1f17b1804b1-454a3a4b4c1mr11962395e9.20.1751447661251; Wed, 02 Jul 2025 02:14:21 -0700 (PDT) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:8827:d0e:25e:834a]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a88c7e6f8bsm16027213f8f.17.2025.07.02.02.14.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 02 Jul 2025 02:14:20 -0700 (PDT) From: Bartosz Golaszewski Date: Wed, 02 Jul 2025 11:14:10 +0200 Subject: [PATCH 09/12] gpio: tps65218: remove unneeded callbacks Precedence: bulk X-Mailing-List: linux-gpio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20250702-gpiochip-set-rv-gpio-round3-v1-9-0d23be74f71d@linaro.org> References: <20250702-gpiochip-set-rv-gpio-round3-v1-0-0d23be74f71d@linaro.org> In-Reply-To: <20250702-gpiochip-set-rv-gpio-round3-v1-0-0d23be74f71d@linaro.org> To: Linus Walleij , Bartosz Golaszewski , Thierry Reding , Jonathan Hunter , Robert Richter , Aaro Koskinen , Andreas Kemnade , Kevin Hilman , Roger Quadros , Tony Lindgren Cc: linux-gpio@vger.kernel.org, linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org, Bartosz Golaszewski X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1287; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=zWboDg3N5zb2XaEN8szzzSbn3MNGMgClzlNJIPkFkw0=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBoZPhh62c0BZgIE/W4nLb0zSNR0o9OQNiyi80Tk T9Q+te1SxeJAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCaGT4YQAKCRARpy6gFHHX cmhoEADSugLmkmZIlBjfyk6OsGwx0kWZkz3LDtgzG7vF4qCBoUG4qyO1UbUJDB10WokBoagJCGD 2e7Z+XEcLJ6lar/VXAkUrVFYRMu8W0MyMZsExZ6QTuPNBF+b9+1B/umRU6CUTi685wEFahmg9Uk yNSKWLWOvz2DOZ/6ajvV/LQIzGe05CIFyAVAeDxwN2zE89jtNZuiCNfeFhhE6caIGxM865QUKH5 4ssfYViRBXxJ1Rl9aVjBLbWUIX6n6ZxWxBbT9i6xpDV5RGzKQDQgcWqQTrRwjuJ099eJUqyRkFD qCYveWbmcA/hr/iiM5dOx3ZFT3B11TVZmfeggQrSAUSar5dtZKrEzhE2sGyPls8GwK/u++b2PK9 v5mzQyRNmFd6Pa1Nnt7NrGu5mAKUCFLAJDW/Vj1tPM8M3tYVVG9tqJEby5I1TjslidTtLIVDnsm bh/ItfgNTqBzXh/2RB7MmPYLN92Ml3OkUiGu0rpBH9P7ALFYBY0b9OJ7khmI9xARo7XlncCCQDm CrC4FpK4vx/HhQcRDnFNAMjMASQ8oW6+bIppzr4q8ntbz7M2RUUOmKkS+lZBadAc7iDrelqQ2v/ NGCYVWUUQG63xkfeQ23Ewj/KhqyAmLBhMeGWn/5N7bZV9gsLfUuo04zHZyoL4nu1ILRZiWB0Ymu 3IXsWxrJhSVu+TQ== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 From: Bartosz Golaszewski GPIO core can handle output-only chips that don't implement the get() and direction_input() callbacks. There's no need to provide dummy implementation of the latter in the driver so drop it. Signed-off-by: Bartosz Golaszewski --- drivers/gpio/gpio-tps65218.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/drivers/gpio/gpio-tps65218.c b/drivers/gpio/gpio-tps65218.c index d7d9d50dcddf432c0825246d8ff54a5c980b0ae4..68e4f0a19f4eb945b33e5992fdf30a29a40bfc1e 100644 --- a/drivers/gpio/gpio-tps65218.c +++ b/drivers/gpio/gpio-tps65218.c @@ -59,11 +59,6 @@ static int tps65218_gpio_output(struct gpio_chip *gc, unsigned offset, return 0; } -static int tps65218_gpio_input(struct gpio_chip *gc, unsigned offset) -{ - return -EPERM; -} - static int tps65218_gpio_request(struct gpio_chip *gc, unsigned offset) { struct tps65218_gpio *tps65218_gpio = gpiochip_get_data(gc); @@ -174,7 +169,6 @@ static const struct gpio_chip template_chip = { .owner = THIS_MODULE, .request = tps65218_gpio_request, .direction_output = tps65218_gpio_output, - .direction_input = tps65218_gpio_input, .get = tps65218_gpio_get, .set = tps65218_gpio_set, .set_config = tps65218_gpio_set_config, -- 2.48.1