From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f49.google.com (mail-wm1-f49.google.com [209.85.128.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 96C90276041 for ; Wed, 9 Jul 2025 06:42:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752043352; cv=none; b=byLGPxEIckZo67Yg0kxfMY7ewBuYL1bZIod+TjOcUvmmn5/aDdJ9CvrqZtFaL9zGt0a6Bs5CUHphI439pdaaTXUiYsNe0aT7arIkjHD+89IP/hkjnfOj/ROSVUVFSdBGM/fhqDodZ8N0AnOn99t1uz5s+qsf/1aGxLiWMUDuD5k= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752043352; c=relaxed/simple; bh=vgZikG7Ep+QVUd5wW3DPZfI2mYJuJ/v++wBP5JlNjj4=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=VN2jl6Wqw1V1DtZPMol32M3cBvewmjwycD+nDhXyIw+qMVg3wTeQacmnS1lQpzdUuuD8LtEBVR6zaCLGtmYNsZBAygE3x0ftm07i8vX3sSS1yNebGJTuBIRnbnrnajbsK+oaVcBfBqMaxJQJrtFLVwUvKnrGp4+YUjfjt+bBlnc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=EzYZ0x8K; arc=none smtp.client-ip=209.85.128.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="EzYZ0x8K" Received: by mail-wm1-f49.google.com with SMTP id 5b1f17b1804b1-45310223677so31949825e9.0 for ; Tue, 08 Jul 2025 23:42:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1752043349; x=1752648149; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=KPGUhdmlwfDijB5p8c2jdqMRyyLRw0XzIvWRRxywz5g=; b=EzYZ0x8K6/FPXiWEoYVMOtMF+8wF0LfpXSD6ZbMkdaPL2HuKqzw3U8W23x3/G1+zSC RHRHiRSmJML1fuBLu0R1NFPAf7R8seDlMQNShas0CP/WnVyiRLv4HbZSLPBqXgWkZ0uA uTKB8ua/Q8DzCYTdYjySMLxhKczJyoODjZhNgulhhPW6ji7rzdLIhrrHsc4nWomlf1cx SCB0CxHpOwpf5q0r32zuLWr8RA/o2nmTBML7cGOu2FNMRyzVMpcTMmlLVVjDu49U+4we p8cwjD4pdUsDZTdA4ipQn5S2raNWsKhTmGJ2HXJgrKSDxHwGH5hwmAi4SFPmqyHG7vXJ b3kw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752043349; x=1752648149; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=KPGUhdmlwfDijB5p8c2jdqMRyyLRw0XzIvWRRxywz5g=; b=v8p4Jkldlw7dsO0HunjW+VZxw+cuRyJ9zZqdP/aFP//LbicHvdvPSEob8+8j8NAlo0 tvqaoYZnIXw0sLb4pmeyZ01ha5r2L0Znsp1w2WpzJlTAIFqyJ40IF9ZVvzcE4Kji4PXw syFP3Ktpi0lnNnVN9ZGhUlzq9cKm6ZL61KLX1Oce19W7vLNZWE9+8t1UHEMGIO5VcNq9 mtOxg7j2zaOrEOvFhbE8hWA0nTuBXzZNncC3UEwImtI+F2ti25QnlkAK41+JA4lkB8w0 eBWEvR5h9pdFBplRx4aUihBCIF55n8aPm48lhMDml5SI0HVS/xzx8RDsuMoZUU1ssBX6 2NFw== X-Gm-Message-State: AOJu0YwCWMMcxR6veFRBy8dJxZEkRo3XSt1gUCANs34AzsL3o/cgAmOh 1YoLu+xiyWl0BPZCclPYUdXKuBrYGqPJCT0t+hvVLxdEOL9IJ/cF3HiGb3CBzb4a6Bc= X-Gm-Gg: ASbGnctnScYThB5ObeQvo+SPluPNMlFi2hhacgCs/iboX/hpwaVEm+n2QnVCkoUVYYD bvUVxEbEbVvO9PoiMEn2KyM5UC6QvJ/NNMX+jy0GTdOr+Pa5zSb32kvX8ONRtQFwAqlXmogGGgQ 1kpRzLtGoJmH87e92h7FkaU8eexZ3rPJvyCdjHiVmzTeJJ0mMbf/wtcWPGjsqCcO5OhqGIQjnku r8tdl2AyDEMQ/5kEqHd4Jp5Y5Q2u1AD5bvQXeiBARSOMbTi8mYO0W3uQK7Bt0mZcaWKUagaWoBA ktHTL5KeK1qx/FFEIpPpXR/NVzRG2JsuKx4/EumndJJXaRub6wKL+e46 X-Google-Smtp-Source: AGHT+IE2jvkZ74rwtuTBLN0s4Szaycx+neThxKbyunEms3rb2frFFesUKJYspBXp7dISaXs9HS/W2Q== X-Received: by 2002:a05:600c:1911:b0:43c:ec97:75db with SMTP id 5b1f17b1804b1-454d53255d2mr8934065e9.11.1752043349033; Tue, 08 Jul 2025 23:42:29 -0700 (PDT) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:b04e:cfc4:3bd9:6180]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3b47030c443sm15115341f8f.11.2025.07.08.23.42.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Jul 2025 23:42:28 -0700 (PDT) From: Bartosz Golaszewski Date: Wed, 09 Jul 2025 08:41:49 +0200 Subject: [PATCH 12/19] gpio: xlp: use new GPIO line value setter callbacks Precedence: bulk X-Mailing-List: linux-gpio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20250709-gpiochip-set-rv-gpio-remaining-v1-12-b8950f69618d@linaro.org> References: <20250709-gpiochip-set-rv-gpio-remaining-v1-0-b8950f69618d@linaro.org> In-Reply-To: <20250709-gpiochip-set-rv-gpio-remaining-v1-0-b8950f69618d@linaro.org> To: Linus Walleij , Bartosz Golaszewski , Kuppuswamy Sathyanarayanan , Andy Shevchenko , Shubhrajyoti Datta , Srinivas Neeli , Michal Simek , Nandor Han Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, patches@opensource.cirrus.com, linux-arm-kernel@lists.infradead.org, Bartosz Golaszewski X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1354; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=x5FG4U/gJyhRjJj1XtGDAFvboyuoHh6dqBdfJYy1RfI=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBobg9Dsiv5Ee6xWbG1tOxvjELtQVLwaBXfailSx fKyWGQWASOJAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCaG4PQwAKCRARpy6gFHHX cksoEADFcZiJ30xLcfVWrKzRcZxE1q3PPoKP43SjyxcmuIi+zrZ+y3J0LisV+VlPko2f7Ph+Euy ZkoyRKhuRLBLJEuKWrCSbPCk72/wNJ+eCmeOJKewpEyBK2mQpm4BD0TwIan8yCbiJAPQ1/8r4W9 iFfDTWQC9SxufumDbCAmrLcVogjijtJyVYw8pjfdxgFQWy8hfj2dJ6+A+IfZYnjSis928pwaWrP TgVXoZ7vBx3GldWKPa9hY3iPT2hl9/oS/nQpSszD3D/azPMEYsXbU/zQ8axfcp4Njw3WNRE2BUb 3s2ovfGkB2LFIXazVw12zmDMVTREnvNUf2GzR3N3u7RueeOAa9wyr3f0YGrNLRkX0gaGnfOviC8 nZ87GozcWVrc9RZ5y+T9vu4vUzLD0MBn+vh+1jciOhiW66Nc1Xe7WjAH2uShR0WNULKl4Hz3sD6 zAVMTg49cvmhEypnXfwgi9YG39a9FO7Qd6iJXQQcSCVtwn8kD08g+HO9nNk+9pqMcCcYu+L4Lb6 8b/c8IEAobs7tkOc3aO2QiUond9/n9Cb5i6QGVgthUfWd2SVeMtWYjMYa6wN1+X5Hb7ZxTtr1gH 4pOz0ptwjPI2wuFqf0WZX6ahORlE+PPFtQESv55c01xRhZXg1eioM/ROW8Hjof4FbwqfEZQEVT3 r4jRxEPJehu5fOg== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 From: Bartosz Golaszewski struct gpio_chip now has callbacks for setting line values that return an integer, allowing to indicate failures. Convert the driver to using them. Signed-off-by: Bartosz Golaszewski --- drivers/gpio/gpio-xlp.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/gpio/gpio-xlp.c b/drivers/gpio/gpio-xlp.c index 35b376c73ce312df1312ab09b53246fb5905152a..bcd2dfec462d0d25b3f97d682866ab035f207c3a 100644 --- a/drivers/gpio/gpio-xlp.c +++ b/drivers/gpio/gpio-xlp.c @@ -227,11 +227,13 @@ static int xlp_gpio_get(struct gpio_chip *gc, unsigned gpio) return xlp_gpio_get_reg(priv->gpio_paddrv, gpio); } -static void xlp_gpio_set(struct gpio_chip *gc, unsigned gpio, int state) +static int xlp_gpio_set(struct gpio_chip *gc, unsigned int gpio, int state) { struct xlp_gpio_priv *priv = gpiochip_get_data(gc); xlp_gpio_set_reg(priv->gpio_paddrv, gpio, state); + + return 0; } static int xlp_gpio_probe(struct platform_device *pdev) @@ -272,7 +274,7 @@ static int xlp_gpio_probe(struct platform_device *pdev) gc->ngpio = 70; gc->direction_output = xlp_gpio_dir_output; gc->direction_input = xlp_gpio_dir_input; - gc->set = xlp_gpio_set; + gc->set_rv = xlp_gpio_set; gc->get = xlp_gpio_get; spin_lock_init(&priv->lock); -- 2.48.1