From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f44.google.com (mail-wr1-f44.google.com [209.85.221.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3B79126CE21 for ; Wed, 9 Jul 2025 06:42:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752043341; cv=none; b=YyE2aLUoSeDABeZUz3+9AWDYm5l6FqDLZAZdWdFfDm6HdIhcNmnIELgikwKDzjq6n9mlQf4PltqR/Ty/kKigXsf2TrEsSNbRLXO9pZZORDplrSKt6nRmksySb+YLVKXly7mzm3Nu4n9z3X+7EWd9u0UpjN81jtst4+0NtB7lctc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752043341; c=relaxed/simple; bh=URNrSWHV7G9o6r4qyGnEPBeM2eKMBuscOiq6l7X9CB4=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=gZlZC3yFNEB82OdUK3PuuDyEZH8LgoJxYUWaKSuPrhDjpNtVEQ6v3U8NNrlMVTAbNv1PQ8Dxu4sqdN0JanDCbdQdG8aD26MIQwW1MeB/Encyqi58Xrg5WyCBHbASYO9c/1kGOpQ7dF0kthrmf4dfWGJvBlTmQvM8XCIx3BsF4+4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=ALhk9X6e; arc=none smtp.client-ip=209.85.221.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="ALhk9X6e" Received: by mail-wr1-f44.google.com with SMTP id ffacd0b85a97d-3a54690d369so5105194f8f.3 for ; Tue, 08 Jul 2025 23:42:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1752043337; x=1752648137; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=3sOO8GRYzH1LAIie/qr6XG8UhR9sQ84kZJSd2ImbOfE=; b=ALhk9X6emabY5SN2Si1aqe0gLJWNnCgddgCKl6rBBnYTburiqcxmz0QEs3hgEVOG/Q nJnnaoubHrLXmIVRwxeQImWjo+2cw/JBSB5zjEABYyZ/Y3h5BSpfF3ubquKFIkXLT0fC F4rUvnHPuVFeFpKmkZS13/XVi69eKR1pFFb+KZ/fyY6skkhVZdK66PohLpxIGmrYrvsl 9+/3W4EQZIxTx/HcIVX+J5izgF8w7BJnIOZ+GEwdbOgp+qCpYu6UD2h8W+iSNZvAY8GR oWWaQvOTolN4QS0qD74uvf4sF2icVKZqg5Em2mO66cOJ3AW0N5mShQX4eOGt+vPqzDRy kCYA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752043337; x=1752648137; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=3sOO8GRYzH1LAIie/qr6XG8UhR9sQ84kZJSd2ImbOfE=; b=HPF4JQboesm3rwtLockaGvUv0NzUfR5jBuWj7hNevyTP5ThhalG6amGVVvsxwwK9l/ TtCQ7xu6/B1xg1maXJlKTa3Ev6/6PDEkffS6fzt9FXkA6s/VJ2XdLzLy870oPZxqk/EO MUewk2nJ9Cqg66o8MRxFsgAYsBuxgHqzwgg+Z6pPq26PbL3Og9LjMQYfO4xZhSNmz5FP baV2saglXOXS+ocVBz6OarX8XEOAZj1pMjOA8b80NFz0iLSOQAWusGmM3mSo3o08IHOp vtntP/AZ+FzBXlJ2S2L0Uz/EPi0PGf7J0SrN38mqRiyU8B/X/OttcUPpaO3Dvi1VnGHo K+Zg== X-Gm-Message-State: AOJu0YwfK6mwGCf9zDzNnJzCUE3qk/ydvavLlDL7AgRkguswZyPyNhkk OQ3GcxSFFZmCnMB1uzjdsQDiHR2VilGcXPZiC0JAGfxfPJdr4HsuNuGpdoyd8dZ5EMc= X-Gm-Gg: ASbGncteMU9z/CA5p/XIWSba3qlZsAkGpKHwSom9AM0rpiL271f3Z7PBTD+cKT09uUT prAs0XxXbP3sSL+b5IY83MlVIgMyfi2PH0Cm8nSKkcC6N9cWhWnN9wKBPhfXvLn+W0J7YyXGMO/ 28yxGsrQDctYPeU5y0VX0B1TIRm+9XxYIP3qunAhSJbRI6XJwEogwj8d5EGnOD2dOHP+s36T5d7 CMg3PqeeBgDL3hXIKBLcMzLrJVJ3daYpqMc8JayFjaA1+xuyCQq5Eh5MwJqgJYerKpZq2gMvhUo nT6pT2+MW8tQG2x8sW+owJesqkv7Ah3kQuLGALOxIx7M8G9VGOOXNGuX X-Google-Smtp-Source: AGHT+IFWKDqKOZ2L/KZvqJCnN8qQD3YIoVrT5a1mUHbgBeSL6yTbT0/+VvV21K5H/B4ELkfg4LvHuw== X-Received: by 2002:a5d:5f89:0:b0:3a3:7baf:f06a with SMTP id ffacd0b85a97d-3b5e4521ecbmr757039f8f.37.1752043337411; Tue, 08 Jul 2025 23:42:17 -0700 (PDT) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:b04e:cfc4:3bd9:6180]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3b47030c443sm15115341f8f.11.2025.07.08.23.42.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Jul 2025 23:42:16 -0700 (PDT) From: Bartosz Golaszewski Date: Wed, 09 Jul 2025 08:41:40 +0200 Subject: [PATCH 03/19] gpio: wcd934x: use new GPIO line value setter callbacks Precedence: bulk X-Mailing-List: linux-gpio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20250709-gpiochip-set-rv-gpio-remaining-v1-3-b8950f69618d@linaro.org> References: <20250709-gpiochip-set-rv-gpio-remaining-v1-0-b8950f69618d@linaro.org> In-Reply-To: <20250709-gpiochip-set-rv-gpio-remaining-v1-0-b8950f69618d@linaro.org> To: Linus Walleij , Bartosz Golaszewski , Kuppuswamy Sathyanarayanan , Andy Shevchenko , Shubhrajyoti Datta , Srinivas Neeli , Michal Simek , Nandor Han Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, patches@opensource.cirrus.com, linux-arm-kernel@lists.infradead.org, Bartosz Golaszewski X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1583; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=Tl8ZXK09HDgun+whKg1NHBj4f20MoyV0KnJ4JPr3RU4=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBobg9BRffvSvflEPnMK75nSizEGaQYFrRJKallm FD14255i/6JAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCaG4PQQAKCRARpy6gFHHX cjPGEADR4Pmj4bWhhCGStbfaVxmL+G8r4NKc5ZarOliqjTvy7GZovvlqcvpXCk35GFbc8S+ub+7 I+BqSvZHhvJMvj0xv+bVfT7r8/0HkAdbyrgx0QzylGDEz1eo72GCy9fz2XRokyv+UsU4DRmE/Zr uiMKQXEQqBQE1Xnk5o3bzF1xgZ56rvGZmIpSIbrUg6rnTmCQGokPzLq9JLI4l8UwDt3tTqTxlJe RedE9ojZ7CQSp/H0RTDIn/V9FVa64XfYjZso2bUPUw16DWID1U1iFLdqO8miKnaNlYolLDEB//o Zmhvs68VMxqq6S0DhFhdhujpiCV5vbenuMFnyruHQFCvo706gnRwHha/la9gI4bsMs/J11A7Rpv js1gm+ApMryxCgH3OFiCzLJ3n7xDdsXTMhf37QFtrvpCeuX4XbjEoES/UcMIyUS+A8T/pkK4w7J 8LMRGbge0CxDuGHXUqLyLEGylFmMJDMiEeJyEpfhV1CsQGhinblP2+eKd2Db0dEVr25fFdGO1XY okolfMaZMS0cenMDpy/TlSMpJSmjXOfZ0M9ESoOotBlDqDNjLrOhIqx2XiQhQypJbGK8TK9xNeB uPgO1XhHt3FSmzMr7QZIMU9UxCnWa7f+jypq9DchT9R6zASZXFV184GGUc7WDSXEXn8fNKcIE4m GrdZs5+ohNuqkIA== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 From: Bartosz Golaszewski struct gpio_chip now has callbacks for setting line values that return an integer, allowing to indicate failures. Convert the driver to using them. Signed-off-by: Bartosz Golaszewski --- drivers/gpio/gpio-wcd934x.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/gpio/gpio-wcd934x.c b/drivers/gpio/gpio-wcd934x.c index cfa7b0a50c8e339603bc5fc70a8d7354f3bc6486..c89da9a220168e1317131d2428fa4105ebae2aab 100644 --- a/drivers/gpio/gpio-wcd934x.c +++ b/drivers/gpio/gpio-wcd934x.c @@ -68,12 +68,13 @@ static int wcd_gpio_get(struct gpio_chip *chip, unsigned int pin) return !!(value & WCD_PIN_MASK(pin)); } -static void wcd_gpio_set(struct gpio_chip *chip, unsigned int pin, int val) +static int wcd_gpio_set(struct gpio_chip *chip, unsigned int pin, int val) { struct wcd_gpio_data *data = gpiochip_get_data(chip); - regmap_update_bits(data->map, WCD_REG_VAL_CTL_OFFSET, - WCD_PIN_MASK(pin), val ? WCD_PIN_MASK(pin) : 0); + return regmap_update_bits(data->map, WCD_REG_VAL_CTL_OFFSET, + WCD_PIN_MASK(pin), + val ? WCD_PIN_MASK(pin) : 0); } static int wcd_gpio_probe(struct platform_device *pdev) @@ -97,7 +98,7 @@ static int wcd_gpio_probe(struct platform_device *pdev) chip->direction_output = wcd_gpio_direction_output; chip->get_direction = wcd_gpio_get_direction; chip->get = wcd_gpio_get; - chip->set = wcd_gpio_set; + chip->set_rv = wcd_gpio_set; chip->parent = dev; chip->base = -1; chip->ngpio = WCD934X_NPINS; -- 2.48.1