From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Bartosz Golaszewski <brgl@bgdev.pl>
Cc: Romain Gantois <romain.gantois@bootlin.com>,
Arnd Bergmann <arnd@arndb.de>,
Linus Walleij <linus.walleij@linaro.org>,
linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org,
Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
Subject: Re: [PATCH 2/2] misc: ti-fpc202: use new GPIO line value setter callbacks
Date: Thu, 17 Jul 2025 16:34:13 +0200 [thread overview]
Message-ID: <2025071759-john-puzzling-b3af@gregkh> (raw)
In-Reply-To: <CAMRc=MeMyocMa6eCOw--uBic4Zk9OG9A=VKvMP+T6bnEuOttng@mail.gmail.com>
On Thu, Jul 17, 2025 at 03:32:07PM +0200, Bartosz Golaszewski wrote:
> On Thu, Jul 17, 2025 at 3:04 PM Bartosz Golaszewski <brgl@bgdev.pl> wrote:
> >
> > From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
> >
> > struct gpio_chip now has callbacks for setting line values that return
> > an integer, allowing to indicate failures. Convert the driver to using
> > them.
> >
> > Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
> > ---
>
> Greg: this patch comes in late into the cycle but the driver in
> question got merged for v6.16-rc1 despite the set() callback in struct
> gpio_chip being already deprecated and it went below my radar. This is
> one of the few remaining conversions and if we get it queued for
> v6.17, we'll be able to complete it next release and drop legacy
> callbacks. I know you're busy so if you could Ack it (and I hope I can
> get a review from Romain and Linus), I'm more than happy to take it
> through the GPIO tree to speed up the process.
No worries, please take it through your tree, now acked.
greg k-h
next prev parent reply other threads:[~2025-07-17 14:34 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-17 13:03 [PATCH 1/2] misc: ti-fpc202: remove unneeded direction check Bartosz Golaszewski
2025-07-17 13:03 ` [PATCH 2/2] misc: ti-fpc202: use new GPIO line value setter callbacks Bartosz Golaszewski
2025-07-17 13:32 ` Bartosz Golaszewski
2025-07-17 14:34 ` Greg Kroah-Hartman [this message]
2025-07-17 14:33 ` Greg Kroah-Hartman
2025-07-17 15:32 ` Romain Gantois
2025-07-17 14:33 ` [PATCH 1/2] misc: ti-fpc202: remove unneeded direction check Greg Kroah-Hartman
2025-07-17 15:26 ` Romain Gantois
2025-07-18 7:55 ` Bartosz Golaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2025071759-john-puzzling-b3af@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=arnd@arndb.de \
--cc=bartosz.golaszewski@linaro.org \
--cc=brgl@bgdev.pl \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=romain.gantois@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).