From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f52.google.com (mail-wm1-f52.google.com [209.85.128.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5B5A32EFDA7 for ; Tue, 12 Aug 2025 12:12:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755000778; cv=none; b=IWp35co38Lb+Ll8NDiifQXeiZz8c69dWn6EcMcdSIdzxAbOvWj+tpACYd9dazm04u1UapVMNtZ6n+huygC0sLT53wkeumQOY/xXCbawtUUMfIAOXc/TuZjFy2Nk61euxJsDavSxqORznicp8qH6YR/qK1Q+KINStitKsZmifUa8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755000778; c=relaxed/simple; bh=gsmPjfJ2QmHUYm2T6GbsR3/AGbz0mExN80EXjsadE2I=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=bpDY0C/fIL/7jKqB4vS9RPt45boZew27nH2+HhFo7gmxFyScx2rBDQNCCLS7fxE3BebgndLoYjAlr+uFWpytKg4m12eR1TTRLfU4S2L7SFMT0DhKMkPEIw7nl1TWMxN79V4KeO+hYeCAH8/NEjXLGBWCTuG1TQ+VeBUIfwOji2k= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=tmOD0cKN; arc=none smtp.client-ip=209.85.128.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="tmOD0cKN" Received: by mail-wm1-f52.google.com with SMTP id 5b1f17b1804b1-45994a72356so42715225e9.0 for ; Tue, 12 Aug 2025 05:12:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1755000775; x=1755605575; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=X1M2z9RjV0ZuXBRlE0vMWSKVCPkQUD2amGo6k0F1OlA=; b=tmOD0cKNTd2GSZossG7W7lMCci1+TigzwNrda7LpLrCwhzY7fFWVE4VwKahnE6e62p zrB65+/ok+ATWuodMPjXN7AgzMt4JO8YTamGoyMaT5YuPnERaQ4AnAt6OSzu2aApN4Kd lYGyFGM8cHH+P5BqRjwYt5CS10ftBAM1cubdmUGbxa1PBUA+SDXcCldZZNkRwO+MvFps oJX/shfhHFLM/mFJhFumzfH/kyFxarNbjQhkcpuspSLEGZ7uA9XKWdscRSUFGd5m+lzw 5wYBbIaoYl8TzKvjBczJGwBrIr1+GaVbDCwh9MoaE4mYLRzNE1XxWD+N3FK4wKoEMjhR g4tA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1755000775; x=1755605575; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=X1M2z9RjV0ZuXBRlE0vMWSKVCPkQUD2amGo6k0F1OlA=; b=Dx17HqtsEMsaMYMF7jXrt9t2YOUnfvud4HBvW+R+rwMsV99YUuNf6iDslmYvw5320H 9+2uMppBVmE6nJV4yS9WpN3ghX959orFNwTc9sw118xOFk8CQ4A5LgNOXSAhTsBcI70L smJ7+uzRTz5pTzSSOattVO30JmcmIlNlUef3sOVseMhW47SoQ8py1ES4KbaJu/tPZYvN CX1xWFebFJbwmaYSwFNi/q0Y4NPRZN95baNm1bxcdeqEwfgdSnS2bNFk8G28cYdjFxQ4 2avoTGWJ4Q8lPIGDwBJkp0Me8Rukbw9Xa3k2dQq5UtIJVHqipX5wv5+goLSP42W8a2gF tO8g== X-Gm-Message-State: AOJu0YyZSUL8uqUjp49S4yw20TnV5yPKnge3AFAcZJjoIWMYjo0zTeyk 1rwGpUYLY/4APr4+cvJK1oc4rAW6rhA325+bthKlb8Ig1VfHJRL/UIVc9+jRcFOHd4W9+5a7/SY 4yT/I X-Gm-Gg: ASbGncso1Yh6UPoWrfDXtfzd5bzVeVp445tu2QnPQ6UVMVWqBSv0Ec7pc3INcbNGl8t AvRKEYewJPSgM30qXJR99WWcdxv/WMs9m2Iys8PQEoLN5vXxvx0HXSK/6EdoY0Q4rxh1iGAvLOn 5kr8GrxdbPY9HBWWn3v8NTVUhRwTgSDZ4K0GndAxm/AlOHfZo+QOqlfyRzgbcByerE2m35uOvft spnGGE2LKV7R6qNIiyZOoNoJFJT+Yaq9LM9G2H/jmHQdWb0ZdOuE1xocYdUONpg4SPjyQunANXd mAylTvzk0bNk2/giPTEN5hoVLEG0MnetGncRipW0lDb5Pl+z0cpXTZDjy6eJ3x4+ASNhfqtFc9f tsU8hSJWxjbrvQsM= X-Google-Smtp-Source: AGHT+IE2LcKw8rjS26CcRnR5lLe9kyK4DWUbNSa945JYdSNP/FB2BhvPQUNxmFpnWH6teI1ZO0UI8Q== X-Received: by 2002:a05:600c:8903:b0:43c:ed33:a500 with SMTP id 5b1f17b1804b1-45a152e2fb4mr2926755e9.10.1755000774439; Tue, 12 Aug 2025 05:12:54 -0700 (PDT) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:16c8:50:27fe:4d94]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-459e6867193sm298878535e9.6.2025.08.12.05.12.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Aug 2025 05:12:53 -0700 (PDT) From: Bartosz Golaszewski Date: Tue, 12 Aug 2025 14:12:45 +0200 Subject: [PATCH RESEND 03/14] gpio: hisi: use the BGPIOF_UNREADABLE_REG_DIR flag Precedence: bulk X-Mailing-List: linux-gpio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20250812-gpio-mmio-gpio-conv-v1-3-aac41d656979@linaro.org> References: <20250812-gpio-mmio-gpio-conv-v1-0-aac41d656979@linaro.org> In-Reply-To: <20250812-gpio-mmio-gpio-conv-v1-0-aac41d656979@linaro.org> To: Linus Walleij , Bartosz Golaszewski , Yinbo Zhu , Hoan Tran , Manivannan Sadhasivam , Yang Shen Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-unisoc@lists.infradead.org, Bartosz Golaszewski X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1294; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=LGZlUs6AQDs8ng5Nn7ommqnFHh3w6/vhUJqzq5JniBE=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBomy+/mio72vVpANuTm+f6vM7UHBMPRPfzU4rJg eqw8jyheiiJAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCaJsvvwAKCRARpy6gFHHX ck0fEACNnQ0xuf1zm0bcXc4sWxmEp3tOkYyBQwtaCRBVqm/HoJdnPpkSK8qx0sulRperBpUkNKK C+RTJqLjVPlBJmnc0F88+P++7wbHardUSAhVj9bC9h4e+lf9fcOiSDQsmJa4W9fqdWgDA0Gxd2f yhOz+mAcQP93HOFDY2MQLZ0tuY6fjqv64hcXPht55HbMvAyVMHpJeKiibOLNXxvSuMKLzxptgRM PGuj+Nlwkalow2pp3vkHb8jm58K/8KCpKCb6oSCjSSzTRjNI856ZSB6ckSto8L0eRQMwtw4wTUW 7tCIju4zu/Td3Z+p4Mdmh/SopuNCI8t8Y7XNUCJCpDhOMpxZ5dr1dkM9m265yvFAHR5aTgk0Bdq g/fVt1H9CiOPYaXS+uyc2YiTs60HSk9M6H5QVPhBtD9+lIUF5nBVEBVFwjBwvmVHYG+kRVs7luw JUCFCGJ+y2PXHazzlFdTBCDORR4iKWzBILE8rK3aJ6pAdB8ZG5qg6EL/jPlZ0lPrCXitueygA+U ErK5hxEzYcROEe8Qz5TmJUczRD7mVBcMXUxS86DRP3O/b7LRLzADpow3ioCNF4JzsN3C3fVYMss bb/YtS29AtLHA3JTMY0wMwm2puAbX4ZFUWo1wb5NvSm+pox6Hi1As5vNk9mtc0n+l9ViWu3Viu1 pDQc6mC+42cYmJQ== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 From: Bartosz Golaszewski There's no reason for this driver to touch the gpio-mmio internals, we have a dedicated flag passed to bgpio_init() indicating to the module that the DIR register is unreadable. Signed-off-by: Bartosz Golaszewski --- drivers/gpio/gpio-hisi.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/gpio/gpio-hisi.c b/drivers/gpio/gpio-hisi.c index ef5cc654a24e2327510b872563e68fb0b9aaef71..6016e6f0ed0fb80ea670ebb575452d9ec23976fa 100644 --- a/drivers/gpio/gpio-hisi.c +++ b/drivers/gpio/gpio-hisi.c @@ -295,7 +295,7 @@ static int hisi_gpio_probe(struct platform_device *pdev) hisi_gpio->reg_base + HISI_GPIO_SWPORT_DR_CLR_WX, hisi_gpio->reg_base + HISI_GPIO_SWPORT_DDR_SET_WX, hisi_gpio->reg_base + HISI_GPIO_SWPORT_DDR_CLR_WX, - BGPIOF_NO_SET_ON_INPUT); + BGPIOF_NO_SET_ON_INPUT | BGPIOF_UNREADABLE_REG_DIR); if (ret) { dev_err(dev, "failed to init, ret = %d\n", ret); return ret; @@ -303,7 +303,6 @@ static int hisi_gpio_probe(struct platform_device *pdev) hisi_gpio->chip.set_config = hisi_gpio_set_config; hisi_gpio->chip.ngpio = hisi_gpio->line_num; - hisi_gpio->chip.bgpio_dir_unreadable = 1; hisi_gpio->chip.base = -1; if (hisi_gpio->irq > 0) -- 2.48.1