From: Jisheng Zhang <jszhang@kernel.org>
To: Doug Berger <opendmb@gmail.com>,
Florian Fainelli <florian.fainelli@broadcom.com>,
Linus Walleij <linus.walleij@linaro.org>,
Bartosz Golaszewski <brgl@bgdev.pl>, Michael Buesch <m@bues.ch>,
Hoan Tran <hoan@os.amperecomputing.com>,
Andy Shevchenko <andy@kernel.org>,
Daniel Palmer <daniel@thingy.jp>,
Romain Perier <romain.perier@gmail.com>,
Grygorii Strashko <grygorii.strashko@ti.com>,
Santosh Shilimkar <ssantosh@kernel.org>,
Kevin Hilman <khilman@kernel.org>,
Robert Jarzmik <robert.jarzmik@free.fr>,
Kunihiko Hayashi <hayashi.kunihiko@socionext.com>,
Masami Hiramatsu <mhiramat@kernel.org>,
Shubhrajyoti Datta <shubhrajyoti.datta@amd.com>,
Srinivas Neeli <srinivas.neeli@amd.com>,
Michal Simek <michal.simek@amd.com>
Cc: Broadcom internal kernel review list
<bcm-kernel-feedback-list@broadcom.com>,
linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org,
linux@ew.tq-group.com
Subject: [PATCH 14/16] gpio: xgene: Use modern PM macros
Date: Wed, 20 Aug 2025 23:40:35 +0800 [thread overview]
Message-ID: <20250820154037.22228-15-jszhang@kernel.org> (raw)
In-Reply-To: <20250820154037.22228-1-jszhang@kernel.org>
Use the modern PM macros for the suspend and resume functions to be
automatically dropped by the compiler when CONFIG_PM or
CONFIG_PM_SLEEP are disabled, without having to use __maybe_unused
Signed-off-by: Jisheng Zhang <jszhang@kernel.org>
---
drivers/gpio/gpio-xgene.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/gpio/gpio-xgene.c b/drivers/gpio/gpio-xgene.c
index 4f627de3f56c..809668449dbe 100644
--- a/drivers/gpio/gpio-xgene.c
+++ b/drivers/gpio/gpio-xgene.c
@@ -130,7 +130,7 @@ static int xgene_gpio_dir_out(struct gpio_chip *gc,
return 0;
}
-static __maybe_unused int xgene_gpio_suspend(struct device *dev)
+static int xgene_gpio_suspend(struct device *dev)
{
struct xgene_gpio *gpio = dev_get_drvdata(dev);
unsigned long bank_offset;
@@ -143,7 +143,7 @@ static __maybe_unused int xgene_gpio_suspend(struct device *dev)
return 0;
}
-static __maybe_unused int xgene_gpio_resume(struct device *dev)
+static int xgene_gpio_resume(struct device *dev)
{
struct xgene_gpio *gpio = dev_get_drvdata(dev);
unsigned long bank_offset;
@@ -156,7 +156,7 @@ static __maybe_unused int xgene_gpio_resume(struct device *dev)
return 0;
}
-static SIMPLE_DEV_PM_OPS(xgene_gpio_pm, xgene_gpio_suspend, xgene_gpio_resume);
+static DEFINE_SIMPLE_DEV_PM_OPS(xgene_gpio_pm, xgene_gpio_suspend, xgene_gpio_resume);
static int xgene_gpio_probe(struct platform_device *pdev)
{
@@ -204,7 +204,7 @@ static struct platform_driver xgene_gpio_driver = {
.name = "xgene-gpio",
.of_match_table = xgene_gpio_of_match,
.acpi_match_table = ACPI_PTR(xgene_gpio_acpi_match),
- .pm = &xgene_gpio_pm,
+ .pm = pm_sleep_ptr(&xgene_gpio_pm),
},
.probe = xgene_gpio_probe,
};
--
2.50.1
next prev parent reply other threads:[~2025-08-20 15:59 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-20 15:40 [PATCH 00/16] gpio: Use modern PM macros Jisheng Zhang
2025-08-20 15:40 ` [PATCH 01/16] gpio: dwapb: " Jisheng Zhang
2025-08-20 16:54 ` Andy Shevchenko
2025-08-20 17:10 ` Michael Büsch
2025-08-20 19:04 ` Andy Shevchenko
2025-08-21 16:44 ` Jisheng Zhang
2025-08-21 19:32 ` Andy Shevchenko
2025-08-22 0:42 ` Jisheng Zhang
2025-08-20 15:40 ` [PATCH 02/16] gpio: brcmstb: " Jisheng Zhang
2025-08-26 21:47 ` Doug Berger
2025-08-20 15:40 ` [PATCH 03/16] gpio: bt8xx: " Jisheng Zhang
2025-08-20 17:08 ` Michael Büsch
2025-08-20 15:40 ` [PATCH 04/16] gpio: htc-egpio: " Jisheng Zhang
2025-08-20 15:40 ` [PATCH 05/16] gpio: pl061: " Jisheng Zhang
2025-08-21 11:52 ` Linus Walleij
2025-08-21 12:50 ` Andy Shevchenko
2025-08-20 15:40 ` [PATCH 06/16] gpio: pxa: " Jisheng Zhang
2025-08-20 15:40 ` [PATCH 07/16] gpio: ml-ioh: " Jisheng Zhang
2025-08-20 16:56 ` Andy Shevchenko
2025-08-20 15:40 ` [PATCH 08/16] gpio: mlxbf2: " Jisheng Zhang
2025-08-20 15:40 ` [PATCH 09/16] gpio: msc313: " Jisheng Zhang
2025-08-20 15:40 ` [PATCH 10/16] gpio: omap: " Jisheng Zhang
2025-08-20 15:40 ` [PATCH 11/16] gpio: pch: " Jisheng Zhang
2025-08-20 16:55 ` Andy Shevchenko
2025-08-20 15:40 ` [PATCH 12/16] gpio: tqmx86: " Jisheng Zhang
2025-08-20 15:40 ` [PATCH 13/16] gpio: uniphier: " Jisheng Zhang
2025-08-20 15:40 ` Jisheng Zhang [this message]
2025-08-20 15:40 ` [PATCH 15/16] gpio: xilinx: " Jisheng Zhang
2025-08-20 15:40 ` [PATCH 16/16] gpio: zynq: " Jisheng Zhang
2025-08-28 13:39 ` [PATCH 00/16] gpio: " Bartosz Golaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250820154037.22228-15-jszhang@kernel.org \
--to=jszhang@kernel.org \
--cc=andy@kernel.org \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=brgl@bgdev.pl \
--cc=daniel@thingy.jp \
--cc=florian.fainelli@broadcom.com \
--cc=grygorii.strashko@ti.com \
--cc=hayashi.kunihiko@socionext.com \
--cc=hoan@os.amperecomputing.com \
--cc=khilman@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux@ew.tq-group.com \
--cc=m@bues.ch \
--cc=mhiramat@kernel.org \
--cc=michal.simek@amd.com \
--cc=opendmb@gmail.com \
--cc=robert.jarzmik@free.fr \
--cc=romain.perier@gmail.com \
--cc=shubhrajyoti.datta@amd.com \
--cc=srinivas.neeli@amd.com \
--cc=ssantosh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).