From: Jisheng Zhang <jszhang@kernel.org>
To: Doug Berger <opendmb@gmail.com>,
Florian Fainelli <florian.fainelli@broadcom.com>,
Linus Walleij <linus.walleij@linaro.org>,
Bartosz Golaszewski <brgl@bgdev.pl>, Michael Buesch <m@bues.ch>,
Hoan Tran <hoan@os.amperecomputing.com>,
Andy Shevchenko <andy@kernel.org>,
Daniel Palmer <daniel@thingy.jp>,
Romain Perier <romain.perier@gmail.com>,
Grygorii Strashko <grygorii.strashko@ti.com>,
Santosh Shilimkar <ssantosh@kernel.org>,
Kevin Hilman <khilman@kernel.org>,
Robert Jarzmik <robert.jarzmik@free.fr>,
Kunihiko Hayashi <hayashi.kunihiko@socionext.com>,
Masami Hiramatsu <mhiramat@kernel.org>,
Shubhrajyoti Datta <shubhrajyoti.datta@amd.com>,
Srinivas Neeli <srinivas.neeli@amd.com>,
Michal Simek <michal.simek@amd.com>
Cc: Broadcom internal kernel review list
<bcm-kernel-feedback-list@broadcom.com>,
linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org,
linux@ew.tq-group.com
Subject: [PATCH 15/16] gpio: xilinx: Use modern PM macros
Date: Wed, 20 Aug 2025 23:40:36 +0800 [thread overview]
Message-ID: <20250820154037.22228-16-jszhang@kernel.org> (raw)
In-Reply-To: <20250820154037.22228-1-jszhang@kernel.org>
Use the modern PM macros for the suspend and resume functions to be
automatically dropped by the compiler when CONFIG_PM or
CONFIG_PM_SLEEP are disabled, without having to use __maybe_unused
Signed-off-by: Jisheng Zhang <jszhang@kernel.org>
---
drivers/gpio/gpio-xilinx.c | 15 +++++++--------
1 file changed, 7 insertions(+), 8 deletions(-)
diff --git a/drivers/gpio/gpio-xilinx.c b/drivers/gpio/gpio-xilinx.c
index 83675ac81077..be4b4d730547 100644
--- a/drivers/gpio/gpio-xilinx.c
+++ b/drivers/gpio/gpio-xilinx.c
@@ -286,7 +286,7 @@ static void xgpio_free(struct gpio_chip *chip, unsigned int offset)
pm_runtime_put(chip->parent);
}
-static int __maybe_unused xgpio_suspend(struct device *dev)
+static int xgpio_suspend(struct device *dev)
{
struct xgpio_instance *gpio = dev_get_drvdata(dev);
struct irq_data *data = irq_get_irq_data(gpio->irq);
@@ -327,7 +327,7 @@ static void xgpio_irq_ack(struct irq_data *irq_data)
{
}
-static int __maybe_unused xgpio_resume(struct device *dev)
+static int xgpio_resume(struct device *dev)
{
struct xgpio_instance *gpio = dev_get_drvdata(dev);
struct irq_data *data = irq_get_irq_data(gpio->irq);
@@ -343,7 +343,7 @@ static int __maybe_unused xgpio_resume(struct device *dev)
return 0;
}
-static int __maybe_unused xgpio_runtime_suspend(struct device *dev)
+static int xgpio_runtime_suspend(struct device *dev)
{
struct xgpio_instance *gpio = dev_get_drvdata(dev);
@@ -352,7 +352,7 @@ static int __maybe_unused xgpio_runtime_suspend(struct device *dev)
return 0;
}
-static int __maybe_unused xgpio_runtime_resume(struct device *dev)
+static int xgpio_runtime_resume(struct device *dev)
{
struct xgpio_instance *gpio = dev_get_drvdata(dev);
@@ -360,9 +360,8 @@ static int __maybe_unused xgpio_runtime_resume(struct device *dev)
}
static const struct dev_pm_ops xgpio_dev_pm_ops = {
- SET_SYSTEM_SLEEP_PM_OPS(xgpio_suspend, xgpio_resume)
- SET_RUNTIME_PM_OPS(xgpio_runtime_suspend,
- xgpio_runtime_resume, NULL)
+ SYSTEM_SLEEP_PM_OPS(xgpio_suspend, xgpio_resume)
+ RUNTIME_PM_OPS(xgpio_runtime_suspend, xgpio_runtime_resume, NULL)
};
/**
@@ -682,7 +681,7 @@ static struct platform_driver xgpio_plat_driver = {
.driver = {
.name = "gpio-xilinx",
.of_match_table = xgpio_of_match,
- .pm = &xgpio_dev_pm_ops,
+ .pm = pm_ptr(&xgpio_dev_pm_ops),
},
};
--
2.50.1
next prev parent reply other threads:[~2025-08-20 15:59 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-20 15:40 [PATCH 00/16] gpio: Use modern PM macros Jisheng Zhang
2025-08-20 15:40 ` [PATCH 01/16] gpio: dwapb: " Jisheng Zhang
2025-08-20 16:54 ` Andy Shevchenko
2025-08-20 17:10 ` Michael Büsch
2025-08-20 19:04 ` Andy Shevchenko
2025-08-21 16:44 ` Jisheng Zhang
2025-08-21 19:32 ` Andy Shevchenko
2025-08-22 0:42 ` Jisheng Zhang
2025-08-20 15:40 ` [PATCH 02/16] gpio: brcmstb: " Jisheng Zhang
2025-08-26 21:47 ` Doug Berger
2025-08-20 15:40 ` [PATCH 03/16] gpio: bt8xx: " Jisheng Zhang
2025-08-20 17:08 ` Michael Büsch
2025-08-20 15:40 ` [PATCH 04/16] gpio: htc-egpio: " Jisheng Zhang
2025-08-20 15:40 ` [PATCH 05/16] gpio: pl061: " Jisheng Zhang
2025-08-21 11:52 ` Linus Walleij
2025-08-21 12:50 ` Andy Shevchenko
2025-08-20 15:40 ` [PATCH 06/16] gpio: pxa: " Jisheng Zhang
2025-08-20 15:40 ` [PATCH 07/16] gpio: ml-ioh: " Jisheng Zhang
2025-08-20 16:56 ` Andy Shevchenko
2025-08-20 15:40 ` [PATCH 08/16] gpio: mlxbf2: " Jisheng Zhang
2025-08-20 15:40 ` [PATCH 09/16] gpio: msc313: " Jisheng Zhang
2025-08-20 15:40 ` [PATCH 10/16] gpio: omap: " Jisheng Zhang
2025-08-20 15:40 ` [PATCH 11/16] gpio: pch: " Jisheng Zhang
2025-08-20 16:55 ` Andy Shevchenko
2025-08-20 15:40 ` [PATCH 12/16] gpio: tqmx86: " Jisheng Zhang
2025-08-20 15:40 ` [PATCH 13/16] gpio: uniphier: " Jisheng Zhang
2025-08-20 15:40 ` [PATCH 14/16] gpio: xgene: " Jisheng Zhang
2025-08-20 15:40 ` Jisheng Zhang [this message]
2025-08-20 15:40 ` [PATCH 16/16] gpio: zynq: " Jisheng Zhang
2025-08-28 13:39 ` [PATCH 00/16] gpio: " Bartosz Golaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250820154037.22228-16-jszhang@kernel.org \
--to=jszhang@kernel.org \
--cc=andy@kernel.org \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=brgl@bgdev.pl \
--cc=daniel@thingy.jp \
--cc=florian.fainelli@broadcom.com \
--cc=grygorii.strashko@ti.com \
--cc=hayashi.kunihiko@socionext.com \
--cc=hoan@os.amperecomputing.com \
--cc=khilman@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux@ew.tq-group.com \
--cc=m@bues.ch \
--cc=mhiramat@kernel.org \
--cc=michal.simek@amd.com \
--cc=opendmb@gmail.com \
--cc=robert.jarzmik@free.fr \
--cc=romain.perier@gmail.com \
--cc=shubhrajyoti.datta@amd.com \
--cc=srinivas.neeli@amd.com \
--cc=ssantosh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).