From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f50.google.com (mail-wm1-f50.google.com [209.85.128.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2C448319866 for ; Tue, 26 Aug 2025 09:35:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.50 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756200919; cv=none; b=MJq2OLeNKZqtmcdCD8LFrHdo1do0m9BGBZLH2RuWwFuVzXiJkzaL/C+x5nHh5TvLVRCf6AJHSnqKSAb+z8SRjrL5lA46aIOwSzdbXQWJoiyQgWOXoGkYb/taq0gUtSCVsVgTmPBy0L7RpWcAlTk/hNqMKHZzk0+rNMMx3PmSIbg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756200919; c=relaxed/simple; bh=eJYObQcFDw7m310+2ZfUoUQs1zqBlwtoyN+n2YWx1X8=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=Rl11ltw1pJ+Ljk5ae33Jq9c3yt7PKrM8Lu4vszuW0Bm53vTStVZ77Lz3/RobF3AHjV95fJssZhdXuoyA6YOgOb6AK75lu9udfa2XEggC4Sr8y5hWF31TKl9g4weSKtNos8PDvBW7Sz1rfWfZl3dW0K6q2LsRhe6zou9ugS1HFmY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=Lob6an2u; arc=none smtp.client-ip=209.85.128.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="Lob6an2u" Received: by mail-wm1-f50.google.com with SMTP id 5b1f17b1804b1-45a1b065d59so29985745e9.1 for ; Tue, 26 Aug 2025 02:35:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1756200916; x=1756805716; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=o6UVlAeR3fwHCFjy4a5d3B3zx2pe4QnNId31mWH7HxM=; b=Lob6an2uBcBMUUKdEPFqRiaRjeKO2kghVeB7r9edvceNOPuMPrchYMxTVLI3KLyvmF ai0QMnS3DGvVHOJaCevNyn2do4chlpHTZiXlvIl+bP6HqgYslKhHcZInqMbbIHiCJRMz 9E7D48qTtQl/8/OPqvIdsY0++olmGwdNhuvrJ3kJ1pwryQD88wmNeWSV42b/KY0c+xkf IFO8tBetq6OCKVoYfhy4/Q48SDIx8hERhvujNAdKx/RdXuAoozLtV9nY84T0FTEb7TAK 5b6KsQs2NYlIvR4F8AbzI4pjs4jBBzK9v6c5F1ex1PeQFlz1DtbtMvkRpYMOUd4XuzfP wcPw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1756200916; x=1756805716; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=o6UVlAeR3fwHCFjy4a5d3B3zx2pe4QnNId31mWH7HxM=; b=sNejbFa6A1VErZ/bDVksS8/qgsrSUFGrFXgTFuZmDzP/lhhfkohPN9i0Jk7QrowJjO wOJrA07xh5ojyTyTzH8lEn2TFRhA5nlLuZ/VfcradGEwbCbKOHmN/cF8bZdAhkJVZxA+ 2JPagvEjQcMvnq+mISVPSKjjdYdx2xTZMmvr49XEbhGc4cEVbv3nlxsiTydbTQNUoJFs IHdioFypo2xtvQ8P1BlOAoREvuCg/A4Oz2I6lp4Is36APFsuHt1JqUAD+m9lsGD1LW/v VdhKQtGa/LhIVbXXyjsnyEafTy6up7PMp72pbNKhGFoDK6hA5J4AX5fMv4xYMu/Zu0nE xrzA== X-Gm-Message-State: AOJu0Yx01hpQJ0SwxZ8/BMROKkYw0p2sqzlVuHp6LEUEI6yZ+QZ9D2xB xqBg+0TVW4R6IMH2UqRPY30FPHrheN0/u8QEI2nO0W6e2/EJ4dYE4kMuwzVfTNHEnUs= X-Gm-Gg: ASbGncsQo/HEUFYcVVvn9PlUvIivJyBaDeLN/CC5DRxFwZw5Hz58EQWCjL12jEH6ZmX 6jooeyhinA2a1dXieV8Us9V1mtRcyZqpfY8fMI/Lo9Yk1tOdlI3iIklEiVcW3+uBoXmIldmrBhc p9YN1REY+uH9Azu8pXDP9VV9LKyG/zWwWhjnQZwsG1uHHqZG6e5Yc1vtWzIcQC7fBOAsKvxRkQF rdk6Cm2C+DmPHLRUStRZaXK8+eMnEX5fEdnoINr373byWbSn0abjO5QzYRIM5AvISdTmKJWEFzo Pm054GP6VusE4P3oNZpdGnj/GwjTG0/9UVI7q/iCj8C4CL4++VvrJkZCmfPCrEGtuTrnwq9C2aS W+7nAEEGmKJTXyOGU X-Google-Smtp-Source: AGHT+IHHMs8HHGoX5pQrBguiSZlF9A3BQe4UKuEJbCj0cIrDBD5J1SUnyxSXmIGXuAVtd2TxeU4iVA== X-Received: by 2002:a5d:5d0a:0:b0:3b8:f358:e80d with SMTP id ffacd0b85a97d-3c5db8ab097mr12681160f8f.5.1756200916017; Tue, 26 Aug 2025 02:35:16 -0700 (PDT) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:fed4:79fc:9440:6629]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3c7117d5b10sm15308255f8f.47.2025.08.26.02.35.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Aug 2025 02:35:15 -0700 (PDT) From: Bartosz Golaszewski Date: Tue, 26 Aug 2025 11:35:05 +0200 Subject: [PATCH 04/12] gpio: mlxbf2: use dev_err_probe() where applicable Precedence: bulk X-Mailing-List: linux-gpio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20250826-gpio-mmio-gpio-conv-part2-v1-4-f67603e4b27e@linaro.org> References: <20250826-gpio-mmio-gpio-conv-part2-v1-0-f67603e4b27e@linaro.org> In-Reply-To: <20250826-gpio-mmio-gpio-conv-part2-v1-0-f67603e4b27e@linaro.org> To: Linus Walleij , Bartosz Golaszewski , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Ray Jui , Scott Branden , Broadcom internal kernel review list , Yang Shen , Nobuhiro Iwamatsu Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, Bartosz Golaszewski X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1971; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=4Y9QgbF00FoI4B/3f7jAJj3cl2aWhCMkDNYuPbS1EZY=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBorX/Mp2Ad+I7SUoOZM6v519gOx/CLUv6RIzX8O Ar5I9b0l/mJAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCaK1/zAAKCRARpy6gFHHX csC1D/4se4kSHgMsVlmXVig251ULGbAuknuYAURfTPA+Gx/KWNnNaq2HC17vXfvReZjWV+38lSW RKsntS3xYeQEEwKabO82u1QzKaWhqgxHiWa2HPldhJNj4h24871wvnXhv4sMXdHFHa+FhVexotj tJIw9MPiRgqECLk4Sq4ww6+9xZ3KlEPSjEYfz6mHT0rQeO8vpzHge3towl0LkAar3hPV37QjEAg 6kmt58UNYU6ZoAaRB6YZHmkKDCOPNY4YdrtKxv+wGTsqGizXc0KDHgU1mdyj4Xln+g6ZYFyKtLy F/WXoZPBa8oTZpYXi4yC+at09xkqkNquwPrMkSvUweF5lZSxWqyKRlS3mklC2K729dq3ykdFsoQ vESYOohtsAMjdEusqxNc4hAlbIfWcb3DHsOKpWPKm2VBMJ7WMX4xHWE5vOdrpga0dac6pKDMhFH uWmPPI7P8kqcHGdfVe+UaGyTxGasjE5z2B2r6Zs+V/rTJ/zMpVMjZ/sSXGEDejFQhyazm+MV+04 eh5BDWYp9VbxaAIjL0IfIK6CMkIrCMgpoeDIV/Tz3lj4ZYNQCuHi3fe5u3nCDwEUjUb+j3PdUE0 3hOTlZKXsSLqw1CyligsQHbM6AlryxzOPZTeW5jD3psp16PB1l3ih/gQWZGfMYL1zGuj3ROcDdR 6ZxueVzBhI6xB+A== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 From: Bartosz Golaszewski Simplify error handling and shrink the code by using dev_err_probe() consistently across the driver. Signed-off-by: Bartosz Golaszewski --- drivers/gpio/gpio-mlxbf2.c | 24 ++++++++---------------- 1 file changed, 8 insertions(+), 16 deletions(-) diff --git a/drivers/gpio/gpio-mlxbf2.c b/drivers/gpio/gpio-mlxbf2.c index 390f2e74a9d8193f924ee50f4a8f2d7bc6ae2168..bc4bba8b567c2605a77d4f9d4d7d916e8b096569 100644 --- a/drivers/gpio/gpio-mlxbf2.c +++ b/drivers/gpio/gpio-mlxbf2.c @@ -369,10 +369,8 @@ mlxbf2_gpio_probe(struct platform_device *pdev) return PTR_ERR(gs->gpio_io); ret = mlxbf2_gpio_get_lock_res(pdev); - if (ret) { - dev_err(dev, "Failed to get yu_arm_gpio_lock resource\n"); - return ret; - } + if (ret) + return dev_err_probe(dev, ret, "Failed to get yu_arm_gpio_lock resource\n"); if (device_property_read_u32(dev, "npins", &npins)) npins = MLXBF2_GPIO_MAX_PINS_PER_BLOCK; @@ -387,10 +385,8 @@ mlxbf2_gpio_probe(struct platform_device *pdev) NULL, 0); - if (ret) { - dev_err(dev, "bgpio_init failed\n"); - return ret; - } + if (ret) + return dev_err_probe(dev, ret, "bgpio_init failed\n"); gc->direction_input = mlxbf2_gpio_direction_input; gc->direction_output = mlxbf2_gpio_direction_output; @@ -414,19 +410,15 @@ mlxbf2_gpio_probe(struct platform_device *pdev) */ ret = devm_request_irq(dev, irq, mlxbf2_gpio_irq_handler, IRQF_SHARED, name, gs); - if (ret) { - dev_err(dev, "failed to request IRQ"); - return ret; - } + if (ret) + return dev_err_probe(dev, ret, "failed to request IRQ"); } platform_set_drvdata(pdev, gs); ret = devm_gpiochip_add_data(dev, &gs->gc, gs); - if (ret) { - dev_err(dev, "Failed adding memory mapped gpiochip\n"); - return ret; - } + if (ret) + return dev_err_probe(dev, ret, "Failed adding memory mapped gpiochip\n"); return 0; } -- 2.48.1