[PATCH AUTOSEL 6.16] gpiolib: acpi: Add quirk for ASUS ProArt PX13

[PATCH AUTOSEL 6.16] gpiolib: acpi: Add quirk for ASUS ProArt PX13

[Sasha Levin]

From: "Mario Limonciello (AMD)" <superm1@kernel.org>

[ Upstream commit 23800ad1265f10c2bc6f42154ce4d20e59f2900e ]

The ASUS ProArt PX13 has a spurious wakeup event from the touchpad
a few moments after entering hardware sleep.  This can be avoided
by preventing the touchpad from being a wake source.

Add to the wakeup ignore list.

Reported-by: Amit Chaudhari <amitchaudhari@mac.com>
Closes: https://gitlab.freedesktop.org/drm/amd/-/issues/4482
Tested-by: Amit Chaudhari <amitchaudhari@mac.com>
Signed-off-by: Mario Limonciello (AMD) <superm1@kernel.org>
Reviewed-by: Mika Westerberg <mika.westerberg@linux.intel.com>
Link: https://lore.kernel.org/20250814183430.3887973-1-superm1@kernel.org
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
---

LLM Generated explanations, may be completely bogus:

Based on my comprehensive analysis of this commit and the context, here
is my assessment:

**Backport Status: YES**

## Extensive Analysis:

### 1. **Nature of the Fix**
This commit fixes a real hardware bug - spurious wakeup events from the
touchpad on the ASUS ProArt PX13 laptop. The code change adds a DMI-
based quirk entry to the `gpiolib_acpi_quirks` table in
`/home/sasha/linux/drivers/gpio/gpiolib-acpi-quirks.c:350-359`, which
instructs the GPIO subsystem to ignore wake events from the specific
touchpad GPIO pin (`ASCP1A00:00@8`).

### 2. **符合稳定内核规则 (Meets Stable Kernel Rules)**
According to `/home/sasha/linux/Documentation/process/stable-kernel-
rules.rst`:
- **Fixes a real bug**: Yes - spurious wakeups are a real hardware issue
  that impacts users' ability to use sleep/suspend effectively (lines
  18-19 of rules)
- **Obviously correct and tested**: Yes - the fix is straightforward
  (adding a quirk entry), has been tested by the reporter (Amit
  Chaudhari), and reviewed by Mika Westerberg
- **Size constraint**: The patch is only ~20 lines with context, well
  under the 100-line limit
- **Already in mainline**: Yes - commit
  23800ad1265f10c2bc6f42154ce4d20e59f2900e

### 3. **Historical Precedent**
Multiple similar commits for spurious wakeup quirks have been backported
to stable:
- Commit `805c74eac8cb3` (GPD G1619-04 touchpad wakeup) - explicitly
  marked with `Cc: stable@vger.kernel.org`
- Commit `782eea0c89f7d` (Clevo NL5xNU) - marked with `Cc:
  stable@vger.kernel.org`
- Commit `a69982c37cd05` (Clevo NH5xAx) - marked with `Cc:
  <stable@vger.kernel.org> # v6.1+`

### 4. **Code Structure Analysis**
The change follows the exact same pattern as other quirk entries in the
file:
```c
.driver_data = &(struct acpi_gpiolib_dmi_quirk) {
    .ignore_wake = "ASCP1A00:00@8",
},
```
This is a data-only addition to an existing quirk table - no logic
changes, no new code paths, minimal regression risk.

### 5. **User Impact**
The bug causes spurious wakeups "a few moments after entering hardware
sleep", which:
- Prevents proper system suspend/sleep functionality
- Drains battery life on laptops
- Disrupts user workflow
- Is a clear hardware-specific issue that cannot be worked around by
  users

### 6. **Risk Assessment**
- **Extremely low risk**: The change only affects systems that match the
  specific DMI strings (ASUSTeK COMPUTER INC. + ProArt PX13)
- **No impact on other systems**: DMI matching ensures this quirk only
  applies to the affected hardware
- **Well-established mechanism**: The ignore_wake infrastructure is
  mature and widely used

### 7. **Backporting Considerations**
While this specific commit wasn't explicitly marked with `Cc: stable`,
it follows the exact same pattern as commits that were. The commit has
already been picked up by Sasha Levin's stable tree (as shown in the `[
Upstream commit ]` tag in the local repository), suggesting the stable
maintainers recognize its importance.

The fix is self-contained, requires no prerequisites, and can be cleanly
applied to any kernel version that has the `gpiolib-acpi-quirks.c` file
structure (introduced in commit `92dc572852ddc`).

### Conclusion
This is a textbook example of a stable-appropriate fix: it addresses a
specific hardware bug affecting real users, uses a well-established
quirk mechanism, has zero impact on unaffected systems, and follows the
exact pattern of previously backported fixes for identical issues on
different hardware.

 drivers/gpio/gpiolib-acpi-quirks.c | 14 ++++++++++++++
 1 file changed, 14 insertions(+)

diff --git a/drivers/gpio/gpiolib-acpi-quirks.c b/drivers/gpio/gpiolib-acpi-quirks.c
index c13545dce3492..bfb04e67c4bc8 100644
--- a/drivers/gpio/gpiolib-acpi-quirks.c
+++ b/drivers/gpio/gpiolib-acpi-quirks.c
@@ -344,6 +344,20 @@ static const struct dmi_system_id gpiolib_acpi_quirks[] __initconst = {
 			.ignore_interrupt = "AMDI0030:00@8",
 		},
 	},
+	{
+		/*
+		 * Spurious wakeups from TP_ATTN# pin
+		 * Found in BIOS 5.35
+		 * https://gitlab.freedesktop.org/drm/amd/-/issues/4482
+		 */
+		.matches = {
+			DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
+			DMI_MATCH(DMI_PRODUCT_FAMILY, "ProArt PX13"),
+		},
+		.driver_data = &(struct acpi_gpiolib_dmi_quirk) {
+			.ignore_wake = "ASCP1A00:00@8",
+		},
+	},
 	{} /* Terminating entry */
 };
 
-- 
2.50.1

[PATCH AUTOSEL 6.16] pinctrl: meson: Fix typo in device table macro

[Sasha Levin]

From: Alexey Gladkov <legion@kernel.org>

[ Upstream commit bd7c2312128e31d056d30d34d60503de056e15f0 ]

The typo when using the MODULE_DEVICE_TABLE macro was not noticeable
because the macro was defined only if the module was built as a separate
module.

Cc: Xianwei Zhao <xianwei.zhao@amlogic.com>
Cc: Linus Walleij <linus.walleij@linaro.org>
Cc: Neil Armstrong <neil.armstrong@linaro.org>
Cc: Kevin Hilman <khilman@baylibre.com>
Cc: linux-amlogic@lists.infradead.org
Cc: linux-gpio@vger.kernel.org
Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202507220009.8HKbNP16-lkp@intel.com/
Signed-off-by: Alexey Gladkov <legion@kernel.org>
Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
Link: https://lore.kernel.org/e548b7761302defec15aa2098172eabb1ce1ad4a.1755170493.git.legion@kernel.org
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
---

LLM Generated explanations, may be completely bogus:

**YES**

This commit should be backported to stable kernel trees for the
following reasons:

1. **Clear bug fix**: The commit fixes a typo where
   `MODULE_DEVICE_TABLE(of, aml_pctl_dt_match)` incorrectly referenced
   `aml_pctl_dt_match` instead of the actual device table name
   `aml_pctl_of_match` (line 1022-1025 shows the table is named
   `aml_pctl_of_match`).

2. **Prevents module loading failure**: This typo would cause the module
   to fail to load properly when built as a loadable module, as the
   MODULE_DEVICE_TABLE macro creates an alias for module autoloading.
   The incorrect reference means the device matching wouldn't work
   correctly for module loading.

3. **Small, contained change**: The fix is a simple one-line change that
   only corrects the typo - changing `aml_pctl_dt_match` to
   `aml_pctl_of_match`. There are no architectural changes or feature
   additions.

4. **Low regression risk**: This is a straightforward typo fix with
   minimal risk. The change only affects the MODULE_DEVICE_TABLE macro
   invocation and doesn't modify any functional code paths.

5. **Affects user functionality**: When the pinctrl driver is built as a
   module (CONFIG_PINCTRL_AMLOGIC_A4=m), this bug would prevent proper
   module autoloading and device matching, affecting users of Amlogic
   A4/S6/S7 SoCs.

6. **Recently introduced code**: The driver was added very recently
   (February 2025 based on commit 6e9be3abb78c2), and this typo was
   present from the initial submission. Fixing it in stable trees
   ensures users get a working driver.

The commit message indicates it was caught by the kernel test robot, and
the fix has already been reviewed by the subsystem maintainer (Neil
Armstrong). This is exactly the type of bug fix that stable kernels
should include - it fixes a real problem, is minimal in scope, and has
very low risk of introducing regressions.

 drivers/pinctrl/meson/pinctrl-amlogic-a4.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/pinctrl/meson/pinctrl-amlogic-a4.c b/drivers/pinctrl/meson/pinctrl-amlogic-a4.c
index 385cc619df13c..95525e66e5c00 100644
--- a/drivers/pinctrl/meson/pinctrl-amlogic-a4.c
+++ b/drivers/pinctrl/meson/pinctrl-amlogic-a4.c
@@ -1023,7 +1023,7 @@ static const struct of_device_id aml_pctl_of_match[] = {
 	{ .compatible = "amlogic,pinctrl-a4", },
 	{ /* sentinel */ }
 };
-MODULE_DEVICE_TABLE(of, aml_pctl_dt_match);
+MODULE_DEVICE_TABLE(of, aml_pctl_of_match);
 
 static struct platform_driver aml_pctl_driver = {
 	.driver = {
-- 
2.50.1

[PATCH AUTOSEL 6.16-5.4] gpio: timberdale: fix off-by-one in IRQ type boundary check

[Sasha Levin]

From: Junjie Cao <junjie.cao@intel.com>

[ Upstream commit 810e154d90f44127239957b06ee51a55553a5815 ]

timbgpio_irq_type() currently accepts offset == ngpio, violating
gpiolib's [0..ngpio-1] contract. This can lead to undefined behavior
when computing '1 << offset', and it is also inconsistent with users
that iterate with for_each_set_bit(..., ngpio).

Tighten the upper bound to reject offset == ngpio. No functional change
for in-range offsets.

Signed-off-by: Junjie Cao <junjie.cao@intel.com>
Link: https://lore.kernel.org/r/20250825090850.127163-1-junjie.cao@intel.com
Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
---

LLM Generated explanations, may be completely bogus:

**YES**

This commit should be backported to stable kernel trees. Here's my
extensive analysis:

## Bug Severity and Impact

The commit fixes a critical **off-by-one boundary check bug** in
`timbgpio_irq_type()` at drivers/gpio/gpio-timberdale.c:141. The bug
allows `offset == tgpio->gpio.ngpio`, which violates the GPIO
subsystem's fundamental contract of valid offsets being in the range
`[0..ngpio-1]`.

## Specific Code Analysis

1. **The Bug**: The original check `if (offset < 0 || offset >
   tgpio->gpio.ngpio)` incorrectly accepts `offset == ngpio` as valid.

2. **Undefined Behavior Risk**: When `offset == ngpio`, the subsequent
   bit shift operations become problematic:
   - Line 154: `bflr &= ~(1 << offset)`
   - Line 157: `lvr |= 1 << offset`
   - Line 167: `flr |= 1 << offset`
   - Line 184: `iowrite32(1 << offset, tgpio->membase + TGPIO_ICR)`

   Shifting by 32 or more bits (assuming 32-bit registers) results in
**undefined behavior** in C, potentially causing:
   - Memory corruption
   - System crashes
   - Security vulnerabilities through out-of-bounds writes

3. **Inconsistency with GPIO Framework**: The bug creates inconsistency
   with `for_each_set_bit()` usage at line 208, which correctly iterates
   from 0 to ngpio-1.

## Backport Criteria Met

✓ **Fixes a real bug**: Prevents undefined behavior and potential memory
corruption
✓ **Small and contained**: Single-line change (`>` to `>=`)
✓ **No side effects**: Only tightens validation, doesn't change behavior
for valid inputs
✓ **No architectural changes**: Simple boundary check fix
✓ **Long-standing bug**: Present since driver introduction in 2009
(commit 35570ac6039ef4)
✓ **Clear fix**: The correction is obvious and mathematically correct
✓ **Low regression risk**: More restrictive validation cannot break
correctly functioning code

## Additional Considerations

- The bug has existed for **15+ years** since the driver's introduction,
  making it a candidate for all maintained stable trees
- While the timberdale GPIO driver may not be widely used, the fix
  prevents potential security issues from invalid array indexing
- Similar boundary check issues in kernel drivers have historically been
  backported to stable
- The fix aligns with kernel security best practices of proper input
  validation

The commit message accurately describes the issue, and the fix is the
minimal change necessary to resolve the bug without introducing new
functionality or risk.

 drivers/gpio/gpio-timberdale.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpio/gpio-timberdale.c b/drivers/gpio/gpio-timberdale.c
index cb303a26f4d3c..61f15a864a5ad 100644
--- a/drivers/gpio/gpio-timberdale.c
+++ b/drivers/gpio/gpio-timberdale.c
@@ -138,7 +138,7 @@ static int timbgpio_irq_type(struct irq_data *d, unsigned trigger)
 	u32 ver;
 	int ret = 0;
 
-	if (offset < 0 || offset > tgpio->gpio.ngpio)
+	if (offset < 0 || offset >= tgpio->gpio.ngpio)
 		return -EINVAL;
 
 	ver = ioread32(tgpio->membase + TGPIO_VER);
-- 
2.50.1