linux-gpio.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Bartosz Golaszewski <brgl@bgdev.pl>
To: Linus Walleij <linus.walleij@linaro.org>,
	 Kent Gibson <warthog618@gmail.com>,
	Vincent Fazio <vfazio@xes-inc.com>,
	 Erik Wierich <erik@riscstar.com>,
	Viresh Kumar <viresh.kumar@linaro.org>
Cc: linux-gpio@vger.kernel.org,
	 Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
Subject: [PATCH libgpiod 1/7] bindings: cxx: move misc.hpp inclusion to the correct place
Date: Wed, 03 Sep 2025 15:01:59 +0200	[thread overview]
Message-ID: <20250903-api-version-detach-v1-1-027ca5928518@linaro.org> (raw)
In-Reply-To: <20250903-api-version-detach-v1-0-027ca5928518@linaro.org>

From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>

The symbols from gpiodcxx/misc.hpp are correctly exported to users of
gpiod.hpp because it's implicitly pulled in by line-request.hpp but
that's incorrect: line-request.hpp has no need for any of the symbols
from misc.hpp and it should be part of the set of headers included by
the top-level gpiod.hpp. Move it to the correct place.

Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
---
 bindings/cxx/gpiod.hpp                 | 1 +
 bindings/cxx/gpiodcxx/line-request.hpp | 2 --
 2 files changed, 1 insertion(+), 2 deletions(-)

diff --git a/bindings/cxx/gpiod.hpp b/bindings/cxx/gpiod.hpp
index 606994dd606a19d63bfcccff90fdce972148397f..c5fda421ffadad83f5f7dd1e60eed1de55354095 100644
--- a/bindings/cxx/gpiod.hpp
+++ b/bindings/cxx/gpiod.hpp
@@ -35,6 +35,7 @@
 #include "gpiodcxx/line-info.hpp"
 #include "gpiodcxx/line-request.hpp"
 #include "gpiodcxx/line-settings.hpp"
+#include "gpiodcxx/misc.hpp"
 #include "gpiodcxx/request-builder.hpp"
 #include "gpiodcxx/request-config.hpp"
 #undef __LIBGPIOD_GPIOD_CXX_INSIDE__
diff --git a/bindings/cxx/gpiodcxx/line-request.hpp b/bindings/cxx/gpiodcxx/line-request.hpp
index 96050191317f1790c6322d93439af6f93bcbd960..e41f31a115ce86d469236f33730112333a495519 100644
--- a/bindings/cxx/gpiodcxx/line-request.hpp
+++ b/bindings/cxx/gpiodcxx/line-request.hpp
@@ -17,8 +17,6 @@
 #include <iostream>
 #include <memory>
 
-#include "misc.hpp"
-
 namespace gpiod {
 
 class chip;

-- 
2.48.1


  reply	other threads:[~2025-09-03 13:02 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-03 13:01 [PATCH libgpiod 0/7] build: detach the libgpiod API version from the libgpiod package version Bartosz Golaszewski
2025-09-03 13:01 ` Bartosz Golaszewski [this message]
2025-09-03 13:02 ` [PATCH libgpiod 2/7] build: define a separate API version for the core C library Bartosz Golaszewski
2025-09-03 13:02 ` [PATCH libgpiod 3/7] core: change the behavior of gpiod_api_version() Bartosz Golaszewski
2025-09-03 13:02 ` [PATCH libgpiod 4/7] tests: update library API version string tests Bartosz Golaszewski
2025-09-03 13:02 ` [PATCH libgpiod 5/7] tools: display C API *and* libgpiod package version for '-v' Bartosz Golaszewski
2025-09-03 13:02 ` [PATCH libgpiod 6/7] dbus: manager: " Bartosz Golaszewski
2025-09-03 13:02 ` [PATCH libgpiod 7/7] dbus: gpiocli: display the libgpiod package version for --version Bartosz Golaszewski
2025-09-04  6:13 ` [PATCH libgpiod 0/7] build: detach the libgpiod API version from the libgpiod package version Erik Schilling
2025-09-09  9:25 ` Bartosz Golaszewski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250903-api-version-detach-v1-1-027ca5928518@linaro.org \
    --to=brgl@bgdev.pl \
    --cc=bartosz.golaszewski@linaro.org \
    --cc=erik@riscstar.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=vfazio@xes-inc.com \
    --cc=viresh.kumar@linaro.org \
    --cc=warthog618@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).