[PATCH 0/2] pinctrl: qcom: glymur: Fix gpio pin functions and clean-up match table

[PATCH 0/2] pinctrl: qcom: glymur: Fix gpio pin functions and clean-up match table

[Abel Vesa]

This glymur pinctrl driver is not currently being used by any platforms
upstream, but once the entire platform support will be merged, there
will be some issues with the gpios as they will be wrongly requested by
the pin muxing config in DT, if the gpio pin function is not marked via
the generic macro as GPIO category function. Fix this issue now by
marking the gpio function properly.

While at it, drop the useless compatible specific match data from the
table.

Signed-off-by: Abel Vesa <abel.vesa@linaro.org>
---
Abel Vesa (2):
      pinctrl: qcom: glymur: Drop unnecessary platform data from match table
      pinctrl: qcom: glymur: Fix the gpio and egpio pin functions

 drivers/pinctrl/qcom/pinctrl-glymur.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
---
base-commit: 8f7f8b1b3f4c613dd886f53f768f82816b41eaa3
change-id: 20250919-pinctrl-qcom-glymur-fixes-7ea30c8202f1

Best regards,
-- 
Abel Vesa <abel.vesa@linaro.org>

[PATCH 1/2] pinctrl: qcom: glymur: Drop unnecessary platform data from match table

[Abel Vesa]

The platform specific configuration is already passed on to the generic
msm probe. So it's useless to exist in the match table next to the
compatible. So drop it from match table.

Fixes: 87ebcd8baebf ("pinctrl: qcom: Add glymur pinctrl driver")
Signed-off-by: Abel Vesa <abel.vesa@linaro.org>
---
 drivers/pinctrl/qcom/pinctrl-glymur.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/pinctrl/qcom/pinctrl-glymur.c b/drivers/pinctrl/qcom/pinctrl-glymur.c
index 9913f98e953110d32e804c8d210220857583ba46..9781e7fcb3a11c85dbd5497170188e2da051215b 100644
--- a/drivers/pinctrl/qcom/pinctrl-glymur.c
+++ b/drivers/pinctrl/qcom/pinctrl-glymur.c
@@ -1743,7 +1743,7 @@ static const struct msm_pinctrl_soc_data glymur_tlmm = {
 };
 
 static const struct of_device_id glymur_tlmm_of_match[] = {
-	{ .compatible = "qcom,glymur-tlmm", .data = &glymur_tlmm },
+	{ .compatible = "qcom,glymur-tlmm", },
 	{ }
 };
 

-- 
2.48.1

Re: [PATCH 1/2] pinctrl: qcom: glymur: Drop unnecessary platform data from match table

[Dmitry Baryshkov]

On Fri, Sep 19, 2025 at 03:17:11PM +0300, Abel Vesa wrote:
> The platform specific configuration is already passed on to the generic
> msm probe. So it's useless to exist in the match table next to the
> compatible. So drop it from match table.
> 
> Fixes: 87ebcd8baebf ("pinctrl: qcom: Add glymur pinctrl driver")

No need for this tag.

Other than that:


Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>



> Signed-off-by: Abel Vesa <abel.vesa@linaro.org>
> ---
>  drivers/pinctrl/qcom/pinctrl-glymur.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/pinctrl/qcom/pinctrl-glymur.c b/drivers/pinctrl/qcom/pinctrl-glymur.c
> index 9913f98e953110d32e804c8d210220857583ba46..9781e7fcb3a11c85dbd5497170188e2da051215b 100644
> --- a/drivers/pinctrl/qcom/pinctrl-glymur.c
> +++ b/drivers/pinctrl/qcom/pinctrl-glymur.c
> @@ -1743,7 +1743,7 @@ static const struct msm_pinctrl_soc_data glymur_tlmm = {
>  };
>  
>  static const struct of_device_id glymur_tlmm_of_match[] = {
> -	{ .compatible = "qcom,glymur-tlmm", .data = &glymur_tlmm },
> +	{ .compatible = "qcom,glymur-tlmm", },
>  	{ }
>  };
>  
> 
> -- 
> 2.48.1
> 

-- 
With best wishes
Dmitry

[PATCH 2/2] pinctrl: qcom: glymur: Fix the gpio and egpio pin functions

[Abel Vesa]

Mark the gpio/egpio as GPIO specific pin functions, othewise
the pin muxing generic framework will complain about the gpio
being already requested by a different owner.

Fixes: 87ebcd8baebf ("pinctrl: qcom: Add glymur pinctrl driver")
Signed-off-by: Abel Vesa <abel.vesa@linaro.org>
---
 drivers/pinctrl/qcom/pinctrl-glymur.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/pinctrl/qcom/pinctrl-glymur.c b/drivers/pinctrl/qcom/pinctrl-glymur.c
index 9781e7fcb3a11c85dbd5497170188e2da051215b..335005084b6bc87db6d700471264edde00370ca0 100644
--- a/drivers/pinctrl/qcom/pinctrl-glymur.c
+++ b/drivers/pinctrl/qcom/pinctrl-glymur.c
@@ -1316,7 +1316,7 @@ static const char *const wcn_sw_ctrl_groups[] = {
 };
 
 static const struct pinfunction glymur_functions[] = {
-	MSM_PIN_FUNCTION(gpio),
+	MSM_GPIO_PIN_FUNCTION(gpio),
 	MSM_PIN_FUNCTION(resout_gpio_n),
 	MSM_PIN_FUNCTION(aoss_cti),
 	MSM_PIN_FUNCTION(asc_cci),
@@ -1342,7 +1342,7 @@ static const struct pinfunction glymur_functions[] = {
 	MSM_PIN_FUNCTION(edp0_hot),
 	MSM_PIN_FUNCTION(edp0_lcd),
 	MSM_PIN_FUNCTION(edp1_lcd),
-	MSM_PIN_FUNCTION(egpio),
+	MSM_GPIO_PIN_FUNCTION(egpio),
 	MSM_PIN_FUNCTION(eusb_ac_en),
 	MSM_PIN_FUNCTION(gcc_gp1),
 	MSM_PIN_FUNCTION(gcc_gp2),

-- 
2.48.1

Re: [PATCH 2/2] pinctrl: qcom: glymur: Fix the gpio and egpio pin functions

[Dmitry Baryshkov]

On Fri, Sep 19, 2025 at 03:17:12PM +0300, Abel Vesa wrote:
> Mark the gpio/egpio as GPIO specific pin functions, othewise
> the pin muxing generic framework will complain about the gpio
> being already requested by a different owner.
> 
> Fixes: 87ebcd8baebf ("pinctrl: qcom: Add glymur pinctrl driver")
> Signed-off-by: Abel Vesa <abel.vesa@linaro.org>
> ---
>  drivers/pinctrl/qcom/pinctrl-glymur.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 

Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>


-- 
With best wishes
Dmitry

Re: [PATCH 2/2] pinctrl: qcom: glymur: Fix the gpio and egpio pin functions

[Bartosz Golaszewski]

On Fri, Sep 19, 2025 at 2:18 PM Abel Vesa <abel.vesa@linaro.org> wrote:
>
> Mark the gpio/egpio as GPIO specific pin functions, othewise
> the pin muxing generic framework will complain about the gpio
> being already requested by a different owner.
>
> Fixes: 87ebcd8baebf ("pinctrl: qcom: Add glymur pinctrl driver")
> Signed-off-by: Abel Vesa <abel.vesa@linaro.org>
> ---

Reviewed-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>

Re: [PATCH 0/2] pinctrl: qcom: glymur: Fix gpio pin functions and clean-up match table

[Linus Walleij]

On Fri, Sep 19, 2025 at 2:17 PM Abel Vesa <abel.vesa@linaro.org> wrote:

> This glymur pinctrl driver is not currently being used by any platforms
> upstream, but once the entire platform support will be merged, there
> will be some issues with the gpios as they will be wrongly requested by
> the pin muxing config in DT, if the gpio pin function is not marked via
> the generic macro as GPIO category function. Fix this issue now by
> marking the gpio function properly.
>
> While at it, drop the useless compatible specific match data from the
> table.
>
> Signed-off-by: Abel Vesa <abel.vesa@linaro.org>

Patches applied for next since they are not regressions.

Yours,
Linus Walleij