From: Dang Huynh via B4 Relay <devnull+dang.huynh.mainlining.org@kernel.org>
To: Manivannan Sadhasivam <mani@kernel.org>,
Linus Walleij <linus.walleij@linaro.org>,
Bartosz Golaszewski <brgl@bgdev.pl>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>, Vinod Koul <vkoul@kernel.org>,
Ulf Hansson <ulf.hansson@linaro.org>,
Philipp Zabel <p.zabel@pengutronix.de>,
Kees Cook <kees@kernel.org>,
"Gustavo A. R. Silva" <gustavoars@kernel.org>
Cc: linux-arm-kernel@lists.infradead.org,
linux-unisoc@lists.infradead.org, linux-gpio@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-clk@vger.kernel.org, dmaengine@vger.kernel.org,
linux-mmc@vger.kernel.org, linux-hardening@vger.kernel.org,
Dang Huynh <dang.huynh@mainlining.org>
Subject: [PATCH 06/10] gpio: rda: Make direction register unreadable
Date: Fri, 19 Sep 2025 01:48:46 +0700 [thread overview]
Message-ID: <20250919-rda8810pl-mmc-v1-6-d4f08a05ba4d@mainlining.org> (raw)
In-Reply-To: <20250919-rda8810pl-mmc-v1-0-d4f08a05ba4d@mainlining.org>
From: Dang Huynh <dang.huynh@mainlining.org>
The register doesn't like to be read and would cause all the input
to be switched to output.
This causes the SD Card Detect GPIO to misbehaves in the OS and/or
may cause hardware to malfunction.
Signed-off-by: Dang Huynh <dang.huynh@mainlining.org>
---
drivers/gpio/gpio-rda.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpio/gpio-rda.c b/drivers/gpio/gpio-rda.c
index 7d20dbbb6ec41149a1dbf4d9ef9ac86449773c35..ae2efa22755986b5445fdb8d4f004d595c189590 100644
--- a/drivers/gpio/gpio-rda.c
+++ b/drivers/gpio/gpio-rda.c
@@ -245,7 +245,7 @@ static int rda_gpio_probe(struct platform_device *pdev)
.clr = rda_gpio->base + RDA_GPIO_CLR,
.dirout = rda_gpio->base + RDA_GPIO_OEN_SET_OUT,
.dirin = rda_gpio->base + RDA_GPIO_OEN_SET_IN,
- .flags = BGPIOF_READ_OUTPUT_REG_SET,
+ .flags = BGPIOF_READ_OUTPUT_REG_SET | BGPIOF_UNREADABLE_REG_DIR,
};
ret = gpio_generic_chip_init(&rda_gpio->chip, &config);
--
2.51.0
next prev parent reply other threads:[~2025-09-18 18:49 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-18 18:48 [PATCH 00/10] RDA8810PL SD/MMC support Dang Huynh via B4 Relay
2025-09-18 18:48 ` [PATCH 01/10] dt-bindings: gpio: rda: Make interrupts optional Dang Huynh via B4 Relay
2025-09-18 18:48 ` [PATCH 02/10] dt-bindings: clock: Add RDA Micro RDA8810PL clock/reset controller Dang Huynh via B4 Relay
2025-09-22 18:04 ` Rob Herring
2025-09-18 18:48 ` [PATCH 03/10] dt-bindings: dma: Add RDA IFC DMA Dang Huynh via B4 Relay
2025-09-22 18:07 ` Rob Herring
2025-09-22 18:08 ` Rob Herring
2025-09-18 18:48 ` [PATCH 04/10] dt-bindings: mmc: Add RDA SDMMC controller Dang Huynh via B4 Relay
2025-09-22 18:13 ` Rob Herring
2025-09-18 18:48 ` [PATCH 05/10] gpio: rda: Make IRQ optional Dang Huynh via B4 Relay
2025-09-18 18:48 ` Dang Huynh via B4 Relay [this message]
2025-09-22 14:20 ` [PATCH 06/10] gpio: rda: Make direction register unreadable Bartosz Golaszewski
2025-09-18 18:48 ` [PATCH 07/10] clk: Add Clock and Reset Driver for RDA Micro RDA8810PL SoC Dang Huynh via B4 Relay
2025-09-18 18:48 ` [PATCH 08/10] dmaengine: Add RDA IFC driver Dang Huynh via B4 Relay
2025-09-21 4:42 ` kernel test robot
2025-09-18 18:48 ` [PATCH 09/10] mmc: host: Add RDA Micro SD/MMC driver Dang Huynh via B4 Relay
2025-10-17 10:25 ` Ulf Hansson
2025-09-18 18:48 ` [PATCH 10/10] ARM: dts: unisoc: rda8810pl: Add SDMMC controllers Dang Huynh via B4 Relay
2025-09-22 14:17 ` [PATCH 00/10] RDA8810PL SD/MMC support Bartosz Golaszewski
2025-09-23 3:40 ` Dang Huynh
2025-09-23 7:48 ` Bartosz Golaszewski
2025-09-25 5:30 ` Dang Huynh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250919-rda8810pl-mmc-v1-6-d4f08a05ba4d@mainlining.org \
--to=devnull+dang.huynh.mainlining.org@kernel.org \
--cc=brgl@bgdev.pl \
--cc=conor+dt@kernel.org \
--cc=dang.huynh@mainlining.org \
--cc=devicetree@vger.kernel.org \
--cc=dmaengine@vger.kernel.org \
--cc=gustavoars@kernel.org \
--cc=kees@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-unisoc@lists.infradead.org \
--cc=mani@kernel.org \
--cc=mturquette@baylibre.com \
--cc=p.zabel@pengutronix.de \
--cc=robh@kernel.org \
--cc=sboyd@kernel.org \
--cc=ulf.hansson@linaro.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).