From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lf1-f44.google.com (mail-lf1-f44.google.com [209.85.167.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D7F0530F815 for ; Thu, 25 Sep 2025 15:17:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758813464; cv=none; b=LipvZf96nZUEXrM5hh7RdkHxlc6JkcAlG+hmev3Mj0DuUsGQ6gUcA9WhdQBeTfBj6z6zPPn9QB4WZ5pj+WytmPWkEnxTLdCmNqrkV65O+9TXJeLMDg8R0ivKfLkXBbYWDSdtHcz7dsP4RsVKKmiOGWMvtXXEQm1zofHEa9BM7Jk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758813464; c=relaxed/simple; bh=Cd+31InyjedttBn2jPLwH1b53yKe5Q/mKZB/CRG/JDY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=OlUroJFvRPWA8r89LEQ3sdZPwRtOXVPGoYcoxEMZnOy8BNxMAnUor1MchMt8slURsO6gKCI4lq040xHdrNJKx3rqQhmG2kGCPVDVQSRbDby/iiip7Z9xAq0QMtClyOgFJqzfoFN43Bmnz85A2OIVhS3M4WRMgwWAKPGTSk653Sg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=nSfAv0WM; arc=none smtp.client-ip=209.85.167.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="nSfAv0WM" Received: by mail-lf1-f44.google.com with SMTP id 2adb3069b0e04-57d8ff3944dso1090702e87.3 for ; Thu, 25 Sep 2025 08:17:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1758813458; x=1759418258; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=8swc3KhKVsBZovpQQIlz8qOzKsdH3lFJ6rE9nIfvYyI=; b=nSfAv0WM12ZekDcMBXNvE6Xs3QcvKIZoFsXDHe6hfzUAOJQqtDW1inK5M9ppgZMvcX lnPxXMG0DBzXCaRpfCf57GZKL/nx9cTMSTdanKQ8IHhf90zXo0OILPN95rPxmNSL+HAO GAEl/LN2uVlck3tb4omnWnpSgaAw3R5e+NXHURdzxyxzfKa0mY8Q+g1kMcVxTqCEEByK tJjR/QXFfXxYRq5parxnSnuCY5WPjp6jHxbEr3QipC6OMQIfQVsavZ0Pf3GlnxKHh2gz F4Ohu0sEqpH6q0m7kOR2628DRaqwU4GAbAqtbyWP+uSP0X8/YIz73wqID6RoE9OasOfR HLzQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1758813458; x=1759418258; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=8swc3KhKVsBZovpQQIlz8qOzKsdH3lFJ6rE9nIfvYyI=; b=f0iA2gUM9Pz5Ufhksl7wtjIlFtC2m0XtJbuoGIOBv947U3oklPyAWcftUa2QIldbLK V4Ie4xp3CeB71ZT/jmgSIhYq62reDDTMFV0khRVr+h21/Fzhab0HwVAulgcZ1etZvB4d xEaXnhy+/6rid2qWbttjDahP7vgqzLywCn6c2XVCoAQnAdIXvdB3X8i/Oa/djTqHZ4YP 2WVygR5Y+/QRXDGAAtJLad+spzHVfrP5uHXQp5ypxd31mjEWpHFJrg4TdhqjywyOQAmC 1MPhg+WPK4xbF38gCsyqnPXQtZzTa4t5x81QUKUOKoIWYLiGtEmt5LJe9v8CouTbSE3T 6/9w== X-Forwarded-Encrypted: i=1; AJvYcCX9WVjBD0K8p35W50dr0ugSLBCPZ0P4d1kJ567JtvFO+Qcp2DBERzW7hY+FRRoal4ShVm9dzz7UWdO4@vger.kernel.org X-Gm-Message-State: AOJu0YyAvamRFq/ebc64l09vX5yNIwWXx4/AC4buOduk0HlFF/2CnQ8W QeTIj2xTm8wtBvmQ/sQzJfIxaSQ4jExju5RmBYTGT7PBfyFWn9tL8evL X-Gm-Gg: ASbGncuBfHxp0Bgk/nqevXOFnUNFOKCwVZFH2ofihJeH2E8XL8H3WGKVmV9idEZXkY3 mNfEcfYadaLJTbmkhce1tQknSpvcLQ2aKFVpqKOdnZ4z+RrsRMDmWThR+84pYv+D9qAkrHEj+me HcGFrUupXhe4R7Joru1/GVfc+na0uQADi1U2t8adni+ZvGXT4VUFNA28ZlDVL9lQVFpUs+cp1X1 14ZR8u6Ozyy2AZ5e5QvaEUvVJKr1pufTvagKy577gRxLAj/KtIFksn+P8NquzTPzwZe3r9Ctih4 w7/xSiftoEKqD+WsJLOiQ6AvS8F7scemAr5tXu9kou7xwiscSlbyIJxLSTBZjIdhg1YYp+PPu7f eU5VSN5h7/I9ZFw== X-Google-Smtp-Source: AGHT+IGaPEzbqVLifBj6VMV1u7ov2ufzTFhND39AMWYuMrWlxeUCOc7nQIX5EVr4wX9P3chS0k2O3Q== X-Received: by 2002:a05:6512:1328:b0:56b:1f30:6734 with SMTP id 2adb3069b0e04-582d41623d6mr1140908e87.54.1758813457759; Thu, 25 Sep 2025 08:17:37 -0700 (PDT) Received: from xeon.. ([188.163.112.70]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-58313430496sm870084e87.27.2025.09.25.08.17.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 25 Sep 2025 08:17:37 -0700 (PDT) From: Svyatoslav Ryhel To: David Airlie , Simona Vetter , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Thierry Reding , Jonathan Hunter , Sowjanya Komatineni , Luca Ceresoli , Prashant Gaikwad , Michael Turquette , Stephen Boyd , Mikko Perttunen , Linus Walleij , Mauro Carvalho Chehab , Greg Kroah-Hartman , Svyatoslav Ryhel , =?UTF-8?q?Jonas=20Schw=C3=B6bel?= , Dmitry Osipenko , Charan Pedumuru , Diogo Ivo , Aaron Kling , Arnd Bergmann Cc: dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, linux-clk@vger.kernel.org, linux-gpio@vger.kernel.org, linux-staging@lists.linux.dev Subject: [PATCH v3 15/22] staging: media: tegra-video: tegra20: simplify format align calculations Date: Thu, 25 Sep 2025 18:16:41 +0300 Message-ID: <20250925151648.79510-16-clamor95@gmail.com> X-Mailer: git-send-email 2.48.1 In-Reply-To: <20250925151648.79510-1-clamor95@gmail.com> References: <20250925151648.79510-1-clamor95@gmail.com> Precedence: bulk X-Mailing-List: linux-gpio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Simplify format align calculations by slightly modifying supported formats structure. Adjusted U and V offset calculations for planar formats since YUV420P bits per pixel is 12 (1 full plane for Y + 2 * 1/4 planes for U and V) so stride is width * 3/2, but offset must be calculated with plain width since each plain has stride width * 1. This aligns with downstream behavior which uses same approach for offset calculations. Signed-off-by: Svyatoslav Ryhel --- drivers/staging/media/tegra-video/tegra20.c | 58 +++++++++------------ drivers/staging/media/tegra-video/vi.h | 3 +- 2 files changed, 27 insertions(+), 34 deletions(-) diff --git a/drivers/staging/media/tegra-video/tegra20.c b/drivers/staging/media/tegra-video/tegra20.c index 7c3ff843235d..b7a39723dfc2 100644 --- a/drivers/staging/media/tegra-video/tegra20.c +++ b/drivers/staging/media/tegra-video/tegra20.c @@ -280,20 +280,8 @@ static void tegra20_fmt_align(struct v4l2_pix_format *pix, unsigned int bpp) pix->width = clamp(pix->width, TEGRA20_MIN_WIDTH, TEGRA20_MAX_WIDTH); pix->height = clamp(pix->height, TEGRA20_MIN_HEIGHT, TEGRA20_MAX_HEIGHT); - switch (pix->pixelformat) { - case V4L2_PIX_FMT_UYVY: - case V4L2_PIX_FMT_VYUY: - case V4L2_PIX_FMT_YUYV: - case V4L2_PIX_FMT_YVYU: - pix->bytesperline = roundup(pix->width, 2) * 2; - pix->sizeimage = roundup(pix->width, 2) * 2 * pix->height; - break; - case V4L2_PIX_FMT_YUV420: - case V4L2_PIX_FMT_YVU420: - pix->bytesperline = roundup(pix->width, 8); - pix->sizeimage = roundup(pix->width, 8) * pix->height * 3 / 2; - break; - } + pix->bytesperline = DIV_ROUND_UP(pix->width * bpp, 8); + pix->sizeimage = pix->bytesperline * pix->height; } /* @@ -305,6 +293,7 @@ static void tegra20_channel_queue_setup(struct tegra_vi_channel *chan) { unsigned int stride = chan->format.bytesperline; unsigned int height = chan->format.height; + unsigned int width = chan->format.width; chan->start_offset = 0; @@ -321,8 +310,8 @@ static void tegra20_channel_queue_setup(struct tegra_vi_channel *chan) case V4L2_PIX_FMT_YUV420: case V4L2_PIX_FMT_YVU420: - chan->addr_offset_u = stride * height; - chan->addr_offset_v = chan->addr_offset_u + stride * height / 4; + chan->addr_offset_u = width * height; + chan->addr_offset_v = chan->addr_offset_u + width * height / 4; /* For YVU420, we swap the locations of the U and V planes. */ if (chan->format.pixelformat == V4L2_PIX_FMT_YVU420) @@ -332,14 +321,14 @@ static void tegra20_channel_queue_setup(struct tegra_vi_channel *chan) chan->start_offset_v = chan->addr_offset_v; if (chan->vflip) { - chan->start_offset += stride * (height - 1); - chan->start_offset_u += (stride / 2) * ((height / 2) - 1); - chan->start_offset_v += (stride / 2) * ((height / 2) - 1); + chan->start_offset += width * (height - 1); + chan->start_offset_u += (width / 2) * ((height / 2) - 1); + chan->start_offset_v += (width / 2) * ((height / 2) - 1); } if (chan->hflip) { - chan->start_offset += stride - 1; - chan->start_offset_u += (stride / 2) - 1; - chan->start_offset_v += (stride / 2) - 1; + chan->start_offset += width - 1; + chan->start_offset_u += (width / 2) - 1; + chan->start_offset_v += (width / 2) - 1; } break; } @@ -576,20 +565,23 @@ static const struct tegra_vi_ops tegra20_vi_ops = { .vi_stop_streaming = tegra20_vi_stop_streaming, }; -#define TEGRA20_VIDEO_FMT(MBUS_CODE, BPP, FOURCC) \ -{ \ - .code = MEDIA_BUS_FMT_##MBUS_CODE, \ - .bpp = BPP, \ - .fourcc = V4L2_PIX_FMT_##FOURCC, \ +#define TEGRA20_VIDEO_FMT(DATA_TYPE, BIT_WIDTH, MBUS_CODE, BPP, FOURCC) \ +{ \ + .img_dt = TEGRA_IMAGE_DT_##DATA_TYPE, \ + .bit_width = BIT_WIDTH, \ + .code = MEDIA_BUS_FMT_##MBUS_CODE, \ + .bpp = BPP, \ + .fourcc = V4L2_PIX_FMT_##FOURCC, \ } static const struct tegra_video_format tegra20_video_formats[] = { - TEGRA20_VIDEO_FMT(UYVY8_2X8, 2, UYVY), - TEGRA20_VIDEO_FMT(VYUY8_2X8, 2, VYUY), - TEGRA20_VIDEO_FMT(YUYV8_2X8, 2, YUYV), - TEGRA20_VIDEO_FMT(YVYU8_2X8, 2, YVYU), - TEGRA20_VIDEO_FMT(UYVY8_2X8, 1, YUV420), - TEGRA20_VIDEO_FMT(UYVY8_2X8, 1, YVU420), + /* YUV422 */ + TEGRA20_VIDEO_FMT(YUV422_8, 16, UYVY8_2X8, 16, UYVY), + TEGRA20_VIDEO_FMT(YUV422_8, 16, VYUY8_2X8, 16, VYUY), + TEGRA20_VIDEO_FMT(YUV422_8, 16, YUYV8_2X8, 16, YUYV), + TEGRA20_VIDEO_FMT(YUV422_8, 16, YVYU8_2X8, 16, YVYU), + TEGRA20_VIDEO_FMT(YUV422_8, 16, UYVY8_2X8, 12, YUV420), + TEGRA20_VIDEO_FMT(YUV422_8, 16, UYVY8_2X8, 12, YVU420), }; const struct tegra_vi_soc tegra20_vi_soc = { diff --git a/drivers/staging/media/tegra-video/vi.h b/drivers/staging/media/tegra-video/vi.h index bfadde8858d4..5cbc0606ed6c 100644 --- a/drivers/staging/media/tegra-video/vi.h +++ b/drivers/staging/media/tegra-video/vi.h @@ -281,7 +281,8 @@ enum tegra_image_dt { * @img_dt: MIPI CSI-2 data type (for CSI-2 only) * @bit_width: format width in bits per component (for CSI/Tegra210 only) * @code: media bus format code - * @bpp: bytes per pixel (when stored in memory) + * @bpp: bytes per pixel (when stored in memory) for Tegra210, + * bits per pixel for Tegra20/Tegra30 * @img_fmt: image format (for CSI/Tegra210 only) * @fourcc: V4L2 pixel format FCC identifier */ -- 2.48.1