From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lf1-f42.google.com (mail-lf1-f42.google.com [209.85.167.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7617B2F617F for ; Fri, 26 Sep 2025 13:11:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758892301; cv=none; b=ZleeSZDEKiliY8O4HTu8kwYGOqNuLoy1P+dn4YlxPXCNvh897H+vXEa8p+lnGCknyxa+1jPg6wP9oSF+XbbvxjoIjW9pT4DD0xQTzGJfPsCY6k0dC2Erfqbpptcnv1nXuEHsrsh7HNY5GwU7tmYVh5k5X8Fhywu3IY/2gTQgT1M= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758892301; c=relaxed/simple; bh=K3KdMz7C2S+sjjhpcJ2VrrH58ALa5ic8heuJ7M4ymXs=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=LXZF6WbeMsGtjTj1ntD8x81PkhWVIxL3cJL2lGl15zLPU6vGB8qqfCgMEgYe8jv/SdqGLt+WPe+oEht9j/guv8ATvm9ZBhuPqNoLlgNsKpCUiBv+k2722IWN8XUao5rDHnzXANvkgcgWEb7EMjHfyW4R8pnld7FuGhVZkRTvbjk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=mSIAMbl3; arc=none smtp.client-ip=209.85.167.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="mSIAMbl3" Received: by mail-lf1-f42.google.com with SMTP id 2adb3069b0e04-55ce508d4d6so1859892e87.0 for ; Fri, 26 Sep 2025 06:11:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1758892295; x=1759497095; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=yK5cgdjGWBYF8FS7tGEMMwrGVxWyiTSoe6v1uuSmXRU=; b=mSIAMbl3eTr+7VxRl3P0MNZWVUQCXmyAjlkt5xOkpMbeNLAm9uAl2J4pO453MmOiyC eR5BMfA+XUNGxAiTsSzXwXqHSZzFU9i+OYryqN1Jl1ZL6RtN9qcT+nxc2ooHY/hse2s3 ulTqMpeG3GcGMWldTAcmsbyQxrV4t+Q/9ig48= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1758892295; x=1759497095; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=yK5cgdjGWBYF8FS7tGEMMwrGVxWyiTSoe6v1uuSmXRU=; b=FgpInKRGs04TctYHIQMySgrdQ99HqBCDtlMifU83YILOcpck1EZEuA/p7JtOyOsQf8 312kc/bPc5b9Cs3KTiONmDiOr5B0A9ASrkSZEkKBVHU18valpnBC9295n7HyhgU9DqLq rsZBxgVtRYTD+g7U+9sOTfB/d5G32vzmIjPrbQxPDV61K6oVYdQ81W2rjfmPCiJoSt/U gR5H+lhH7xCVf2014uYzBWzMyXYJPCyy4RUSeKVzZkIn2Nl/1UODfK+zfGVw7tJ5c0Sl GTWCZaubq8q/tNyTFKIhMpKM4yHtMRW57gSARxFRarwh8H7c4jX8s3ot4zP3QxHeN1Nb sazA== X-Forwarded-Encrypted: i=1; AJvYcCWLdPSP0ywQCKMPl6mFOvedo4KV9kJG7sGz9c//oO6VsV1Ty3VVpl+jiM90WzAQpw7Sf1sCNRDxSkOu@vger.kernel.org X-Gm-Message-State: AOJu0YzpIQzw29f+QwbMkSrTohDMf7xcgIbRJ5bxhD6Bs9dR/t6GoJRZ dzZqp7uieYETS6zYBFrWzvrVzmfp/fqNm4Os2dN0ReLCUkV95iRQ1RdSNCRXSu1QpQ== X-Gm-Gg: ASbGncuSRFSWv3M4E3ji3jmKZ0anwYHglmUr5YAcU5n0tzpwtpKVQchr6Aybn2nQ2FZ EPvv6rQFM8+MeR8aoANDwDJUpfjbUCpxZZcKt10lIVgIRfEyeg0n1xbDiJkt0m9NFCcKso71yh4 GtD9KrN05pDaNrZczX2E8uNdOgMOy0qnAg0a8aQwLdDM+rhEciEMzg2aQVzAKPe2KSwQxKwG6dX LibWz+QBZRZY0+UCZfpKPwjz8EPJbx22XprfHx2rXNTDKaNuV11rlsoH+XiJDOXjO7NwqK5GA4A EviiXybYiW+cOjR3OndltDo4uEohTqRCvOcgeKZdEgMm0kLBnDTyXr2dwzypggLv7N4jhXYWZ1d U1nT0srpFE+6RCApB3/+1OelY6ELTWBg/Be5wARLsIrYt1+t7CwCgAMJzhu2iT1x7eq0GD1jwiE 7iYOrQT2Gj3Mqg X-Google-Smtp-Source: AGHT+IGFsjXQDMDVCJ1rn/evMz3fd3PTtDOlV/BZM7pcfvKWARbqj04ku2ig/REcBSICwb5/1B/aQQ== X-Received: by 2002:a05:6512:23a8:b0:57b:3600:8b4b with SMTP id 2adb3069b0e04-582d092964emr2268576e87.7.1758892295046; Fri, 26 Sep 2025 06:11:35 -0700 (PDT) Received: from ribalda.c.googlers.com (64.153.228.35.bc.googleusercontent.com. [35.228.153.64]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-58527c6b014sm123872e87.43.2025.09.26.06.11.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 26 Sep 2025 06:11:34 -0700 (PDT) From: Ricardo Ribalda Date: Fri, 26 Sep 2025 13:11:33 +0000 Subject: [PATCH v3 09/12] media: uvcvideo: Fill ctrl->info.selector earlier Precedence: bulk X-Mailing-List: linux-gpio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20250926-uvc-orientation-v3-9-6dc2fa5b4220@chromium.org> References: <20250926-uvc-orientation-v3-0-6dc2fa5b4220@chromium.org> In-Reply-To: <20250926-uvc-orientation-v3-0-6dc2fa5b4220@chromium.org> To: Hans de Goede , Laurent Pinchart , Mauro Carvalho Chehab , Sakari Ailus , Greg Kroah-Hartman , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Linus Walleij , Bartosz Golaszewski , "Rafael J. Wysocki" , Len Brown , Robert Moore , Hans Verkuil Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, devicetree@vger.kernel.org, linux-gpio@vger.kernel.org, linux-acpi@vger.kernel.org, acpica-devel@lists.linux.dev, Ricardo Ribalda X-Mailer: b4 0.14.2 This is a preparation patch. A future helper will remove the selector argument and use the information embedded in the uvc_control structure. Signed-off-by: Ricardo Ribalda --- drivers/media/usb/uvc/uvc_ctrl.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/media/usb/uvc/uvc_ctrl.c b/drivers/media/usb/uvc/uvc_ctrl.c index aa9de84de9236540c46ee78fb8458873d503786e..98e454fcdeb2ee36d334068fd750e6203931699d 100644 --- a/drivers/media/usb/uvc/uvc_ctrl.c +++ b/drivers/media/usb/uvc/uvc_ctrl.c @@ -2720,7 +2720,8 @@ static void uvc_ctrl_fixup_xu_info(struct uvc_device *dev, * Query control information (size and flags) for XU controls. */ static int uvc_ctrl_fill_xu_info(struct uvc_device *dev, - const struct uvc_control *ctrl, struct uvc_control_info *info) + struct uvc_control *ctrl, + struct uvc_control_info *info) { u8 *data; int ret; @@ -2733,6 +2734,9 @@ static int uvc_ctrl_fill_xu_info(struct uvc_device *dev, info->index = ctrl->index; info->selector = ctrl->index + 1; + /* We need to fill info.selector to get the flags and the length. */ + ctrl->info.selector = info->selector; + /* Query and verify the control length (GET_LEN) */ ret = uvc_query_ctrl(dev, UVC_GET_LEN, ctrl->entity->id, dev->intfnum, info->selector, data, 2); -- 2.51.0.536.g15c5d4f767-goog