From: Bartosz Golaszewski <brgl@bgdev.pl>
To: Linus Walleij <linus.walleij@linaro.org>,
Bartosz Golaszewski <brgl@bgdev.pl>,
Joel Stanley <joel@jms.id.au>,
Andrew Jeffery <andrew@codeconstruct.com.au>,
Kent Gibson <warthog618@gmail.com>
Cc: linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org,
Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
Subject: [PATCH 0/3] gpio: aspeed: remove the "gpiolib.h" include
Date: Thu, 16 Oct 2025 11:09:24 +0200 [thread overview]
Message-ID: <20251016-aspeed-gpiolib-include-v1-0-31201c06d124@linaro.org> (raw)
gpiolib.h is a header internal to the GPIO core. Drivers should not
include them. gpio-aspeed only needs to be able to determine the
hardware offset of the GPIO given the descriptor. Expose the relevant
symbol in the consumer header which allows us to stop pulling in the
private one.
Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
---
Bartosz Golaszewski (3):
gpio: rename gpio_chip_hwgpio() to gpiod_hwgpio()
gpio: export gpiod_hwgpio()
gpio: aspeed: remove unneeded include
drivers/gpio/gpio-aspeed.c | 7 +++--
drivers/gpio/gpiolib-cdev.c | 12 ++++-----
drivers/gpio/gpiolib-sysfs.c | 14 +++++-----
drivers/gpio/gpiolib.c | 59 ++++++++++++++++++++++++++-----------------
drivers/gpio/gpiolib.h | 8 ------
include/linux/gpio/consumer.h | 2 ++
6 files changed, 54 insertions(+), 48 deletions(-)
---
base-commit: 13863a59e410cab46d26751941980dc8f088b9b3
change-id: 20251015-aspeed-gpiolib-include-249a3529efd5
Best regards,
--
Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
next reply other threads:[~2025-10-16 9:09 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-16 9:09 Bartosz Golaszewski [this message]
2025-10-16 9:09 ` [PATCH 1/3] gpio: rename gpio_chip_hwgpio() to gpiod_hwgpio() Bartosz Golaszewski
2025-10-16 9:09 ` [PATCH 2/3] gpio: export gpiod_hwgpio() Bartosz Golaszewski
2025-10-16 9:09 ` [PATCH 3/3] gpio: aspeed: remove unneeded include Bartosz Golaszewski
2025-10-17 6:31 ` [PATCH 0/3] gpio: aspeed: remove the "gpiolib.h" include Andrew Jeffery
2025-10-20 21:18 ` Linus Walleij
2025-10-21 9:01 ` Bartosz Golaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251016-aspeed-gpiolib-include-v1-0-31201c06d124@linaro.org \
--to=brgl@bgdev.pl \
--cc=andrew@codeconstruct.com.au \
--cc=bartosz.golaszewski@linaro.org \
--cc=joel@jms.id.au \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=warthog618@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).