linux-gpio.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [brgl:gpio/for-current 3/3] drivers/gpio/gpio-idio-16.c:170:20: error: 'struct gpio_regmap_config' has no member named 'fixed_direction_output'
@ 2025-10-21 13:17 kernel test robot
  2025-10-21 13:23 ` Bartosz Golaszewski
  0 siblings, 1 reply; 3+ messages in thread
From: kernel test robot @ 2025-10-21 13:17 UTC (permalink / raw)
  To: William Breathitt Gray
  Cc: oe-kbuild-all, linux-gpio, Bartosz Golaszewski, Andy Shevchenko,
	Linus Walleij

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/brgl/linux.git gpio/for-current
head:   0d3f95740ced3acb6171cdec8c5bef336b0cabdb
commit: 0d3f95740ced3acb6171cdec8c5bef336b0cabdb [3/3] gpio: idio-16: Define fixed direction of the GPIO lines
config: x86_64-buildonly-randconfig-005-20251021 (https://download.01.org/0day-ci/archive/20251021/202510212126.mVDMC2iC-lkp@intel.com/config)
compiler: gcc-14 (Debian 14.2.0-19) 14.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20251021/202510212126.mVDMC2iC-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202510212126.mVDMC2iC-lkp@intel.com/

All errors (new ones prefixed by >>):

   drivers/gpio/gpio-idio-16.c: In function 'devm_idio_16_regmap_register':
>> drivers/gpio/gpio-idio-16.c:170:20: error: 'struct gpio_regmap_config' has no member named 'fixed_direction_output'
     170 |         gpio_config.fixed_direction_output = fixed_direction_output;
         |                    ^


vim +170 drivers/gpio/gpio-idio-16.c

    95	
    96	/**
    97	 * devm_idio_16_regmap_register - Register an IDIO-16 GPIO device
    98	 * @dev:	device that is registering this IDIO-16 GPIO device
    99	 * @config:	configuration for idio_16_regmap_config
   100	 *
   101	 * Registers an IDIO-16 GPIO device. Returns 0 on success and negative error number on failure.
   102	 */
   103	int devm_idio_16_regmap_register(struct device *const dev,
   104					 const struct idio_16_regmap_config *const config)
   105	{
   106		struct gpio_regmap_config gpio_config = {};
   107		int err;
   108		struct idio_16_data *data;
   109		struct regmap_irq_chip *chip;
   110		struct regmap_irq_chip_data *chip_data;
   111		DECLARE_BITMAP(fixed_direction_output, IDIO_16_NGPIO);
   112	
   113		if (!config->parent)
   114			return -EINVAL;
   115	
   116		if (!config->map)
   117			return -EINVAL;
   118	
   119		if (!config->regmap_irqs)
   120			return -EINVAL;
   121	
   122		data = devm_kzalloc(dev, sizeof(*data), GFP_KERNEL);
   123		if (!data)
   124			return -ENOMEM;
   125		data->map = config->map;
   126	
   127		chip = devm_kzalloc(dev, sizeof(*chip), GFP_KERNEL);
   128		if (!chip)
   129			return -ENOMEM;
   130	
   131		chip->name = dev_name(dev);
   132		chip->status_base = IDIO_16_INTERRUPT_STATUS;
   133		chip->mask_base = IDIO_16_ENABLE_IRQ;
   134		chip->ack_base = IDIO_16_CLEAR_INTERRUPT;
   135		chip->no_status = config->no_status;
   136		chip->num_regs = 1;
   137		chip->irqs = config->regmap_irqs;
   138		chip->num_irqs = config->num_regmap_irqs;
   139		chip->handle_mask_sync = idio_16_handle_mask_sync;
   140		chip->irq_drv_data = data;
   141	
   142		/* Disable IRQ to prevent spurious interrupts before we're ready */
   143		err = regmap_write(data->map, IDIO_16_DISABLE_IRQ, 0x00);
   144		if (err)
   145			return err;
   146	
   147		err = devm_regmap_add_irq_chip(dev, data->map, config->irq, 0, 0, chip, &chip_data);
   148		if (err)
   149			return dev_err_probe(dev, err, "IRQ registration failed\n");
   150	
   151		if (config->filters) {
   152			/* Deactivate input filters */
   153			err = regmap_write(data->map, IDIO_16_DEACTIVATE_INPUT_FILTERS, 0x00);
   154			if (err)
   155				return err;
   156		}
   157	
   158		gpio_config.parent = config->parent;
   159		gpio_config.regmap = data->map;
   160		gpio_config.ngpio = IDIO_16_NGPIO;
   161		gpio_config.names = idio_16_names;
   162		gpio_config.reg_dat_base = GPIO_REGMAP_ADDR(IDIO_16_DAT_BASE);
   163		gpio_config.reg_set_base = GPIO_REGMAP_ADDR(IDIO_16_DAT_BASE);
   164		gpio_config.ngpio_per_reg = IDIO_16_NGPIO_PER_REG;
   165		gpio_config.reg_stride = IDIO_16_REG_STRIDE;
   166		gpio_config.irq_domain = regmap_irq_get_domain(chip_data);
   167		gpio_config.reg_mask_xlate = idio_16_reg_mask_xlate;
   168	
   169		bitmap_from_u64(fixed_direction_output, GENMASK_U64(15, 0));
 > 170		gpio_config.fixed_direction_output = fixed_direction_output;
   171	
   172		return PTR_ERR_OR_ZERO(devm_gpio_regmap_register(dev, &gpio_config));
   173	}
   174	EXPORT_SYMBOL_GPL(devm_idio_16_regmap_register);
   175	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [brgl:gpio/for-current 3/3] drivers/gpio/gpio-idio-16.c:170:20: error: 'struct gpio_regmap_config' has no member named 'fixed_direction_output'
  2025-10-21 13:17 [brgl:gpio/for-current 3/3] drivers/gpio/gpio-idio-16.c:170:20: error: 'struct gpio_regmap_config' has no member named 'fixed_direction_output' kernel test robot
@ 2025-10-21 13:23 ` Bartosz Golaszewski
  2025-10-21 14:30   ` Andy Shevchenko
  0 siblings, 1 reply; 3+ messages in thread
From: Bartosz Golaszewski @ 2025-10-21 13:23 UTC (permalink / raw)
  To: kernel test robot
  Cc: William Breathitt Gray, oe-kbuild-all, linux-gpio,
	Bartosz Golaszewski, Andy Shevchenko, Linus Walleij

On Tue, Oct 21, 2025 at 3:17 PM kernel test robot <lkp@intel.com> wrote:
>
> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/brgl/linux.git gpio/for-current
> head:   0d3f95740ced3acb6171cdec8c5bef336b0cabdb
> commit: 0d3f95740ced3acb6171cdec8c5bef336b0cabdb [3/3] gpio: idio-16: Define fixed direction of the GPIO lines
> config: x86_64-buildonly-randconfig-005-20251021 (https://download.01.org/0day-ci/archive/20251021/202510212126.mVDMC2iC-lkp@intel.com/config)
> compiler: gcc-14 (Debian 14.2.0-19) 14.2.0
> reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20251021/202510212126.mVDMC2iC-lkp@intel.com/reproduce)
>
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@intel.com>
> | Closes: https://lore.kernel.org/oe-kbuild-all/202510212126.mVDMC2iC-lkp@intel.com/
>
> All errors (new ones prefixed by >>):
>
>    drivers/gpio/gpio-idio-16.c: In function 'devm_idio_16_regmap_register':
> >> drivers/gpio/gpio-idio-16.c:170:20: error: 'struct gpio_regmap_config' has no member named 'fixed_direction_output'
>      170 |         gpio_config.fixed_direction_output = fixed_direction_output;
>          |                    ^
>
>
> vim +170 drivers/gpio/gpio-idio-16.c
>

I removed the offending commit from my queue.

Bartosz

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [brgl:gpio/for-current 3/3] drivers/gpio/gpio-idio-16.c:170:20: error: 'struct gpio_regmap_config' has no member named 'fixed_direction_output'
  2025-10-21 13:23 ` Bartosz Golaszewski
@ 2025-10-21 14:30   ` Andy Shevchenko
  0 siblings, 0 replies; 3+ messages in thread
From: Andy Shevchenko @ 2025-10-21 14:30 UTC (permalink / raw)
  To: Bartosz Golaszewski
  Cc: kernel test robot, William Breathitt Gray, oe-kbuild-all,
	linux-gpio, Bartosz Golaszewski, Linus Walleij

On Tue, Oct 21, 2025 at 03:23:12PM +0200, Bartosz Golaszewski wrote:
> On Tue, Oct 21, 2025 at 3:17 PM kernel test robot <lkp@intel.com> wrote:
> >
> > tree:   https://git.kernel.org/pub/scm/linux/kernel/git/brgl/linux.git gpio/for-current
> > head:   0d3f95740ced3acb6171cdec8c5bef336b0cabdb
> > commit: 0d3f95740ced3acb6171cdec8c5bef336b0cabdb [3/3] gpio: idio-16: Define fixed direction of the GPIO lines
> > config: x86_64-buildonly-randconfig-005-20251021 (https://download.01.org/0day-ci/archive/20251021/202510212126.mVDMC2iC-lkp@intel.com/config)
> > compiler: gcc-14 (Debian 14.2.0-19) 14.2.0
> > reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20251021/202510212126.mVDMC2iC-lkp@intel.com/reproduce)
> >
> > If you fix the issue in a separate patch/commit (i.e. not just a new version of
> > the same patch/commit), kindly add following tags
> > | Reported-by: kernel test robot <lkp@intel.com>
> > | Closes: https://lore.kernel.org/oe-kbuild-all/202510212126.mVDMC2iC-lkp@intel.com/
> >
> > All errors (new ones prefixed by >>):
> >
> >    drivers/gpio/gpio-idio-16.c: In function 'devm_idio_16_regmap_register':
> > >> drivers/gpio/gpio-idio-16.c:170:20: error: 'struct gpio_regmap_config' has no member named 'fixed_direction_output'
> >      170 |         gpio_config.fixed_direction_output = fixed_direction_output;
> >          |                    ^
> >
> >
> > vim +170 drivers/gpio/gpio-idio-16.c
> >
> 
> I removed the offending commit from my queue.

I dunno if we call it "offending", but I think this should include
a prerequisite as it was mentioned in one of the Cc: stable@ lines.

-- 
With Best Regards,
Andy Shevchenko



^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2025-10-21 14:30 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-10-21 13:17 [brgl:gpio/for-current 3/3] drivers/gpio/gpio-idio-16.c:170:20: error: 'struct gpio_regmap_config' has no member named 'fixed_direction_output' kernel test robot
2025-10-21 13:23 ` Bartosz Golaszewski
2025-10-21 14:30   ` Andy Shevchenko

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).